| Message ID | 20160926182917.27531-18-paul.burton@imgtec.com |
|---|---|
| State | Deferred |
| Delegated to: | Daniel Schwierzeck |
| Headers | show |
2016-09-26 20:29 GMT+02:00 Paul Burton <paul.burton@imgtec.com>: > Without adding a prompt for CONFIG_MIPS_CM_BASE, Kconfig doesn't allow > defconfigs to set it. Provide the prompt in order to allow for that. > > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > --- > > arch/mips/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 097ad58..b425414 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -352,7 +352,8 @@ config MIPS_CM > information such as cache configuration. > > config MIPS_CM_BASE > - hex > + hex "MIPS CM GCR Base Address" > + depends on MIPS_CM > default 0x1fbf8000 > help > The physical base address at which to map the MIPS Coherence Manager > -- > 2.10.0 > I guess that is board-specific and shouldn't be modified by a user. How about this: > config MIPS_CM_BASE > hex > depends on MIPS_CM > default 0x16100000 if TARGET_BOSTON > default 0x1fbf8000 > help > The physical base address at which to map the MIPS Coherence Manager Then you don't have to add this option to your board's defconfig files. This would also help if we want to support builds with "make randconfig" in the future.
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 097ad58..b425414 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -352,7 +352,8 @@ config MIPS_CM information such as cache configuration. config MIPS_CM_BASE - hex + hex "MIPS CM GCR Base Address" + depends on MIPS_CM default 0x1fbf8000 help The physical base address at which to map the MIPS Coherence Manager
Without adding a prompt for CONFIG_MIPS_CM_BASE, Kconfig doesn't allow defconfigs to set it. Provide the prompt in order to allow for that. Signed-off-by: Paul Burton <paul.burton@imgtec.com> --- arch/mips/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)