| Message ID | f9dd122f-b0ed-0398-2a13-4d31693356fa@users.sourceforge.net |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 2016-09-26 at 19:44 +0200, SF Markus Elfring wrote: > v2: Position the desired closing parenthesis behind the variable name for > a character buffer. Please wait a reasonable amount of time (say a week or two) to collect all feedback on all patches of a series. If there's feedback you should resend the entire series (minus those patches that have been NAK-ed, of course) as an update (v2, v3, etc.). Don't resubmit one single patch of a series (within hours!) as you did here. I hope to have a look at your series within a few days. Show some patience. Thanks, Paul Bolle
> Don't resubmit one single patch of a series (within hours!) > as you did here. I hope that I could reduce the confusion a bit which I introduced with a change in the last step of my questionable update suggestion. > I hope to have a look at your series within a few days. > Show some patience. Yes, of course. Regards, Markus
When you need to make changes to patches that are part of a series, you must resubmit the entire series, not just the things that are changes.
> When you need to make changes to patches that are part of a series, > you must resubmit the entire series, I imagine that will happen when the patch review time passed by a bit more as Paul Bolle requested it yesterday. > not just the things that are changes. Thanks for your reminder. Regards, Markus
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index 2e9382f..dba44e1 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, { unsigned char outbuf[80]; unsigned char c; - size_t space = sizeof outbuf - 1; + size_t space = sizeof(outbuf) - 1; unsigned char *out = outbuf; size_t numin = len; @@ -1079,7 +1079,7 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors, unsigned long flags; unsigned i; - drv = kmalloc(sizeof *drv, GFP_KERNEL); + drv = kmalloc(sizeof(*drv), GFP_KERNEL); if (!drv) return NULL;