From patchwork Mon Sep 26 17:44:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 675271 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sjWb76MnCz9sBR for ; Tue, 27 Sep 2016 03:45:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161498AbcIZRp1 (ORCPT ); Mon, 26 Sep 2016 13:45:27 -0400 Received: from mout.web.de ([212.227.15.4]:65479 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966506AbcIZRpZ (ORCPT ); Mon, 26 Sep 2016 13:45:25 -0400 Received: from [192.168.1.2] ([77.182.186.67]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0Lylol-1auq0z1i9X-016BAs; Mon, 26 Sep 2016 19:44:58 +0200 Subject: [PATCH v2 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses To: Joe Perches , David Laight , "gigaset307x-common@lists.sourceforge.net" , "netdev@vger.kernel.org" , Karsten Keil , Paul Bolle References: <566ABCD9.1060404@users.sourceforge.net> <6d4bbb77-914f-19b8-a1a9-2731d1158612@users.sourceforge.net> <063D6719AE5E284EB5DD2968C1650D6DB0109E63@AcuExch.aculab.com> <1474907003.2238.13.camel@perches.com> Cc: LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall From: SF Markus Elfring Message-ID: Date: Mon, 26 Sep 2016 19:44:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474907003.2238.13.camel@perches.com> X-Provags-ID: V03:K0:dsaYgOkwyl7uoxmrb8MHrR/6lRcSZ2Q+xDzQSOTRcvzbUPqxVdd 2X3O3GqB107ezjYSeb5vkTLDE4PkwcpNxhKdM75RZ1YV9QKIBniJ7Vc/2dXcK19TTFLRNVR FzMhXkZxoyIQp+DnnubbaEt4UQ+ikO6VgApGELrO/X9DLm3dPL07RvcPY8nDx+NuL20BQmd DFFz4dg2kJMrzZ2epr7vQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:qCO7MmMFNPw=:YohjzQocq8X+oIrVDZddM7 afDoQf2c6KrAF0GqaRLvfPUCqkPdxjjZp8C9oJqa86LEgi5oE5PAORDgaK7NBBqlY8XgrPWdz YuP1POGT4zLJ1YsMrqhC6LOFJII7AusA4Z34GKexk1Z5mVsNSFqkoChcZ2jriTzABZep3Utnq uYdFjUt2sg1qEs/gbnYA6fm8UTH9O0rFO6Qr+PjHhgpS4adAsK3PcGcO3OJNVuPicCY+3Lr0g LE//THYFKu80PpQvZtxYHMnzBJ9bt20vQZBfoxpjZf7ZxjhDP+OEvOcmg03RW9h6AGFXc1oTA Fwv0xXbvDyuww8ZGIAUtzx4k+8AwvcvraxolAlOnjTkVigtGiXPHD3e2V0937IbK7D9jgLf9U 3SHwut90vNyRaXw7CKwqpPA4wx6t44xQMbuVqnvwpKP6Za8s31Kbo86KDy2MJHZ6rMIKXZ//4 iOOO9tLgpI6bI0YskVeK+1FpocAMRJvfHnVT8IjMzoniWNlyM0a4RE0nTlAIhuUIbdmycEsRs 0FcZBsDqMhy8W9u2bUayduVGXI4/NFIyumeeG5p+ixQBTNLJNko5lGgxgrQrRRLaBZHB2QWD2 fvODQss9eiJdCBvD8+As49G2qIVZA5LodVq6DJnFWOyCEmVl2sDcw/9V3XLLUUymKarvrokwd 2Pu3z08Dyh3XxI/IV+/XCjLBY52KixZT8zTVxe8A0hRTbcw3peHGgnuSVoi0HpuWLfcR06z79 oRmiypTtAnk5A6PdHoFcr4s+IjC4IMI6YQcgdp74KqJ9W07N1iNrMLEkvseI6gBWjRiaHakmm 1Mv9zIm Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Markus Elfring Date: Mon, 26 Sep 2016 19:34:27 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. WARNING: sizeof … should be sizeof(…) Thus fix the affected source code places. Signed-off-by: Markus Elfring --- v2: Position the desired closing parenthesis behind the variable name for a character buffer. drivers/isdn/gigaset/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index 2e9382f..dba44e1 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, { unsigned char outbuf[80]; unsigned char c; - size_t space = sizeof outbuf - 1; + size_t space = sizeof(outbuf) - 1; unsigned char *out = outbuf; size_t numin = len; @@ -1079,7 +1079,7 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors, unsigned long flags; unsigned i; - drv = kmalloc(sizeof *drv, GFP_KERNEL); + drv = kmalloc(sizeof(*drv), GFP_KERNEL); if (!drv) return NULL;