| Message ID | 1474668213-15643-1-git-send-email-mst@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1474668213-15643-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PULL v2 00/19] virtio, pc: fixes and features
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1474658044-9479-1-git-send-email-dgilbert@redhat.com -> patchew/1474658044-9479-1-git-send-email-dgilbert@redhat.com
- [tag update] patchew/1474658051-18617-1-git-send-email-mst@redhat.com -> patchew/1474658051-18617-1-git-send-email-mst@redhat.com
* [new tag] patchew/1474668213-15643-1-git-send-email-mst@redhat.com -> patchew/1474668213-15643-1-git-send-email-mst@redhat.com
Switched to a new branch 'test'
e60318a hw/i386: AMD IOMMU IVRS table
a37e600 hw/i386: Introduce AMD IOMMU
d14baae hw/i386/trace-events: Add AMD IOMMU trace events
26b9d41 hw/pci: Prepare for AMD IOMMU
965cf43 virtio: handle virtqueue_get_head() errors
9514f00 virtio: handle virtqueue_num_heads() errors
6b81ab8 virtio: handle virtqueue_read_next_desc() errors
4bb1905 virtio: use unsigned int for virtqueue_get_avail_bytes() index
868b390 virtio: handle virtqueue_get_avail_bytes() errors
a307efe virtio: handle virtqueue_map_desc() errors
f7549bd virtio: migrate vdev->broken flag
1b80c3a virtio: stop virtqueue processing if device is broken
1649672 virtio: fix stray tab character
77e188d target-i386: turn off CPU.l3-cache only for 2.7 and older machine types
c8d0f2f pc: clean up COMPAT macro chaining
0d59009 virtio: add check for descriptor's mapped address
d9efd63 tests: add /vhost-user/flags-mismatch test
7aa9333 tests: add a simple /vhost-user/multiqueue test
5f1b5da tests: add /vhost-user/connect-fail test
=== OUTPUT BEGIN ===
Checking PATCH 1/19: tests: add /vhost-user/connect-fail test...
Checking PATCH 2/19: tests: add a simple /vhost-user/multiqueue test...
WARNING: line over 80 characters
#192: FILE: tests/vhost-user-test.c:824:
+ cmd = g_strdup_printf(QEMU_CMD_MEM QEMU_CMD_CHR QEMU_CMD_NETDEV ",queues=%d "
total: 0 errors, 1 warnings, 198 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/19: tests: add /vhost-user/flags-mismatch test...
Checking PATCH 4/19: virtio: add check for descriptor's mapped address...
Checking PATCH 5/19: pc: clean up COMPAT macro chaining...
Checking PATCH 6/19: target-i386: turn off CPU.l3-cache only for 2.7 and older machine types...
Checking PATCH 7/19: virtio: fix stray tab character...
Checking PATCH 8/19: virtio: stop virtqueue processing if device is broken...
Checking PATCH 9/19: virtio: migrate vdev->broken flag...
Checking PATCH 10/19: virtio: handle virtqueue_map_desc() errors...
Checking PATCH 11/19: virtio: handle virtqueue_get_avail_bytes() errors...
Checking PATCH 12/19: virtio: use unsigned int for virtqueue_get_avail_bytes() index...
Checking PATCH 13/19: virtio: handle virtqueue_read_next_desc() errors...
Checking PATCH 14/19: virtio: handle virtqueue_num_heads() errors...
Checking PATCH 15/19: virtio: handle virtqueue_get_head() errors...
Checking PATCH 16/19: hw/pci: Prepare for AMD IOMMU...
Checking PATCH 17/19: hw/i386/trace-events: Add AMD IOMMU trace events...
Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
ERROR: struct MemoryRegionIOMMUOps should normally be const
#1528: FILE: hw/i386/amd_iommu.h:280:
+ MemoryRegionIOMMUOps iommu_ops;
total: 1 errors, 0 warnings, 1496 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/19: hw/i386: AMD IOMMU IVRS table...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 23 September 2016 at 15:04, Michael S. Tsirkin <mst@redhat.com> wrote: > The following changes since commit eaff9c4367ac3f7ac44f6c6f4cb7bcd4daa89af5: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160923' into staging (2016-09-23 15:28:07 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to fb9f592623b0f9bb82a88d68d7921fb581918ef5: > > hw/i386: AMD IOMMU IVRS table (2016-09-24 01:02:01 +0300) > > changes since v1: > fixed a build failure due to a duplicate typedef > which trips up older gccs > > ---------------------------------------------------------------- > virtio, pc: fixes and features > > beginning of guest error handling for virtio devices > amd iommu > pc compat fixes > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Applied, thanks. -- PMM
The following changes since commit eaff9c4367ac3f7ac44f6c6f4cb7bcd4daa89af5: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160923' into staging (2016-09-23 15:28:07 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to fb9f592623b0f9bb82a88d68d7921fb581918ef5: hw/i386: AMD IOMMU IVRS table (2016-09-24 01:02:01 +0300) changes since v1: fixed a build failure due to a duplicate typedef which trips up older gccs ---------------------------------------------------------------- virtio, pc: fixes and features beginning of guest error handling for virtio devices amd iommu pc compat fixes Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- David Kiarie (4): hw/pci: Prepare for AMD IOMMU hw/i386/trace-events: Add AMD IOMMU trace events hw/i386: Introduce AMD IOMMU hw/i386: AMD IOMMU IVRS table Igor Mammedov (2): pc: clean up COMPAT macro chaining target-i386: turn off CPU.l3-cache only for 2.7 and older machine types Marc-André Lureau (3): tests: add /vhost-user/connect-fail test tests: add a simple /vhost-user/multiqueue test tests: add /vhost-user/flags-mismatch test Prasad J Pandit (1): virtio: add check for descriptor's mapped address Stefan Hajnoczi (9): virtio: fix stray tab character virtio: stop virtqueue processing if device is broken virtio: migrate vdev->broken flag virtio: handle virtqueue_map_desc() errors virtio: handle virtqueue_get_avail_bytes() errors virtio: use unsigned int for virtqueue_get_avail_bytes() index virtio: handle virtqueue_read_next_desc() errors virtio: handle virtqueue_num_heads() errors virtio: handle virtqueue_get_head() errors hw/i386/amd_iommu.h | 289 +++++++++++ include/hw/acpi/aml-build.h | 1 + include/hw/i386/pc.h | 9 +- include/hw/i386/x86-iommu.h | 12 + include/hw/pci/pci.h | 3 + include/hw/virtio/virtio.h | 3 + hw/acpi/aml-build.c | 2 +- hw/i386/acpi-build.c | 76 ++- hw/i386/amd_iommu.c | 1202 +++++++++++++++++++++++++++++++++++++++++++ hw/i386/intel_iommu.c | 1 + hw/i386/x86-iommu.c | 6 + hw/virtio/virtio.c | 237 +++++++-- tests/vhost-user-test.c | 208 +++++++- hw/i386/Makefile.objs | 1 + hw/i386/trace-events | 29 ++ tests/Makefile.include | 2 +- 16 files changed, 2009 insertions(+), 72 deletions(-) create mode 100644 hw/i386/amd_iommu.h create mode 100644 hw/i386/amd_iommu.c