| Message ID | 1474614921-2221-1-git-send-email-david@gibson.dropbear.id.au |
|---|---|
| State | New |
| Headers | show |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1474614921-2221-1-git-send-email-david@gibson.dropbear.id.au
Subject: [Qemu-devel] [PULL 00/45] ppc-for-2.8 queue 20160923
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1474606948-14391-1-git-send-email-peterx@redhat.com -> patchew/1474606948-14391-1-git-send-email-peterx@redhat.com
Switched to a new branch 'test'
7279e61 spapr_pci: Add numa node id
e853a1f monitor: fix crash for platforms without a CPU 0
f863b08 linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP
67e2e36 ppc/kvm: Mark 64kB page size support as disabled if not available
e2cb625 ppc/xics: An ICS with offset 0 is assumed to be uninitialized
5200431 ppc/xics: account correct irq status
9de3193 Enable H_CLEAR_MOD and H_CLEAR_REF hypercalls on KVM/PPC64.
6de78a6 target-ppc: tlbie/tlbivax should have global effect
9ae5d1b target-ppc: add flag in check_tlb_flush()
a2fde7b target-ppc: add TLB_NEED_LOCAL_FLUSH flag
f79b2a1 spapr: Introduce sPAPRCPUCoreClass
733852c target-ppc: implement darn instruction
b8e43ff target-ppc: add stxsi[bh]x instruction
2b2cc76 target-ppc: add lxsi[bw]zx instruction
2bbb8a3 target-ppc: add xxspltib instruction
f65c694 target-ppc: consolidate store conditional
14f731c target-ppc: move out stqcx impementation
8aff65f target-ppc: consolidate load with reservation
643054f target-ppc: convert st[16, 32, 64]r to use new macro
5c23cd1 target-ppc: convert st64 to use new macro
42f50b9 target-ppc: consolidate store operations
a36c985 target-ppc: convert ld[16, 32, 64]ur to use new macro
a409b21 target-ppc: convert ld64 to use new macro
df67b40 target-ppc: consolidate load operations
e9d9046 spapr_vscsi: convert to trace framework instead of DPRINTF
c1935cc spapr_llan: convert to trace framework instead of DPRINTF
fcfe30e spapr_vio: convert to trace framework instead of DPRINTF
249b98f spapr_rtas: convert to trace framework instead of DPRINTF
120c0d1 spapr_drc: convert to trace framework instead of DPRINTF
da3fa21 adb.c: prevent NO_KEY value from going to guest
555fb37 adb.c: correct several key assignments
8e2a585 adb.c: add support for QKeyCode
d613636 adb-keys.h: initial commit
7e7343d MAINTAINERS: add sPAPR tests
aa37e42 tests: add RTAS command in the protocol
c385d02 libqos: define SPAPR libqos functions
14a3742 qtest: replace strtoXX() by qemu_strtoXX()
c988b08 ppc: Fix signal delivery in ppc-user and ppc64-user
fc29711 target-ppc: add vector permute right indexed instruction
979a74b target-ppc: add vector bit permute doubleword instruction
b570d14 target-ppc: add vector count trailing zeros instructions
38aca3c target-ppc: add vector extract instructions
66d9a36 target-ppc: add vector insert instructions
59467a3 ppc: restrict the use of the rfi instruction
0ae36d1 MAINTAINERS: Add some missing ppc-related files
=== OUTPUT BEGIN ===
Checking PATCH 1/45: MAINTAINERS: Add some missing ppc-related files...
Checking PATCH 2/45: ppc: restrict the use of the rfi instruction...
Checking PATCH 3/45: target-ppc: add vector insert instructions...
Checking PATCH 4/45: target-ppc: add vector extract instructions...
Checking PATCH 5/45: target-ppc: add vector count trailing zeros instructions...
Checking PATCH 6/45: target-ppc: add vector bit permute doubleword instruction...
Checking PATCH 7/45: target-ppc: add vector permute right indexed instruction...
Checking PATCH 8/45: ppc: Fix signal delivery in ppc-user and ppc64-user...
Checking PATCH 9/45: qtest: replace strtoXX() by qemu_strtoXX()...
Checking PATCH 10/45: libqos: define SPAPR libqos functions...
Checking PATCH 11/45: tests: add RTAS command in the protocol...
Checking PATCH 12/45: MAINTAINERS: add sPAPR tests...
Checking PATCH 13/45: adb-keys.h: initial commit...
ERROR: line over 90 characters
#31: FILE: include/hw/input/adb-keys.h:14:
+ * Additional information: http://www.archive.org/stream/apple-guide-macintosh-family-hardware/Apple_Guide_to_the_Macintosh_Family_Hardware_2e#page/n345/mode/2up
total: 1 errors, 0 warnings, 141 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/45: adb.c: add support for QKeyCode...
Checking PATCH 15/45: adb.c: correct several key assignments...
Checking PATCH 16/45: adb.c: prevent NO_KEY value from going to guest...
Checking PATCH 17/45: spapr_drc: convert to trace framework instead of DPRINTF...
Checking PATCH 18/45: spapr_rtas: convert to trace framework instead of DPRINTF...
Checking PATCH 19/45: spapr_vio: convert to trace framework instead of DPRINTF...
Checking PATCH 20/45: spapr_llan: convert to trace framework instead of DPRINTF...
Checking PATCH 21/45: spapr_vscsi: convert to trace framework instead of DPRINTF...
Checking PATCH 22/45: target-ppc: consolidate load operations...
Checking PATCH 23/45: target-ppc: convert ld64 to use new macro...
Checking PATCH 24/45: target-ppc: convert ld[16, 32, 64]ur to use new macro...
Checking PATCH 25/45: target-ppc: consolidate store operations...
Checking PATCH 26/45: target-ppc: convert st64 to use new macro...
Checking PATCH 27/45: target-ppc: convert st[16, 32, 64]r to use new macro...
Checking PATCH 28/45: target-ppc: consolidate load with reservation...
Checking PATCH 29/45: target-ppc: move out stqcx impementation...
Checking PATCH 30/45: target-ppc: consolidate store conditional...
Checking PATCH 31/45: target-ppc: add xxspltib instruction...
ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: target-ppc/translate/vsx-ops.inc.c:23:
+#define GEN_XX1FORM(name, opc2, opc3, fl2) \
+GEN_HANDLER2_E(name, #name, 0x3C, opc2 | 0, opc3, 0, PPC_NONE, fl2), \
+GEN_HANDLER2_E(name, #name, 0x3C, opc2 | 1, opc3, 0, PPC_NONE, fl2)
total: 1 errors, 0 warnings, 51 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 32/45: target-ppc: add lxsi[bw]zx instruction...
Checking PATCH 33/45: target-ppc: add stxsi[bh]x instruction...
Checking PATCH 34/45: target-ppc: implement darn instruction...
Checking PATCH 35/45: spapr: Introduce sPAPRCPUCoreClass...
Checking PATCH 36/45: target-ppc: add TLB_NEED_LOCAL_FLUSH flag...
Checking PATCH 37/45: target-ppc: add flag in check_tlb_flush()...
Checking PATCH 38/45: target-ppc: tlbie/tlbivax should have global effect...
Checking PATCH 39/45: Enable H_CLEAR_MOD and H_CLEAR_REF hypercalls on KVM/PPC64....
Checking PATCH 40/45: ppc/xics: account correct irq status...
Checking PATCH 41/45: ppc/xics: An ICS with offset 0 is assumed to be uninitialized...
Checking PATCH 42/45: ppc/kvm: Mark 64kB page size support as disabled if not available...
Checking PATCH 43/45: linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP...
Checking PATCH 44/45: monitor: fix crash for platforms without a CPU 0...
Checking PATCH 45/45: spapr_pci: Add numa node id...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 23 September 2016 at 08:14, David Gibson <david@gibson.dropbear.id.au> wrote: > The following changes since commit 430da7a81d356e368ccd88dcca60f38da9aa5b9a: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160915' into staging (2016-09-22 15:39:54 +0100) > > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160923 > > for you to fetch changes up to 4814401fa01271235df2ac60fafc831bd3d624f3: > > spapr_pci: Add numa node id (2016-09-23 12:39:07 +1000) > > ---------------------------------------------------------------- > ppc patch queue 2016-09-23 > > This pull request supersedes ppc-for-2.8-20160922. There was a clang > build error in that, and I've also added one extra patch in the new pull. > > Included in this set of ppc and spapr patches are: > * TCG implementations for more POWER9 instructions > * Some preliminary XICS fixes in preparataion for the pnv machine type > * A significant ADB (Macintosh kbd/mouse) cleanup > * Some conversions to use trace instead of debug macros > * Fixes to correctly handle global TLB flush synchronization in > TCG. This is already a bug, but it will have much more impact > when we get MTTCG > * Add more qtest testcases for Power > * Some MAINTAINERS updates > * Assorted bugfixes > * Add the basics of NUMA associativity to the spapr PCI host bridge > > This touches some test files and monitor.c which are technically > outside the ppc code, but coming through this tree because the changes > are primarily of interest to ppc. > > ---------------------------------------------------------------- Applied, thanks. -- PMM
The following changes since commit 430da7a81d356e368ccd88dcca60f38da9aa5b9a: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160915' into staging (2016-09-22 15:39:54 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160923 for you to fetch changes up to 4814401fa01271235df2ac60fafc831bd3d624f3: spapr_pci: Add numa node id (2016-09-23 12:39:07 +1000) ---------------------------------------------------------------- ppc patch queue 2016-09-23 This pull request supersedes ppc-for-2.8-20160922. There was a clang build error in that, and I've also added one extra patch in the new pull. Included in this set of ppc and spapr patches are: * TCG implementations for more POWER9 instructions * Some preliminary XICS fixes in preparataion for the pnv machine type * A significant ADB (Macintosh kbd/mouse) cleanup * Some conversions to use trace instead of debug macros * Fixes to correctly handle global TLB flush synchronization in TCG. This is already a bug, but it will have much more impact when we get MTTCG * Add more qtest testcases for Power * Some MAINTAINERS updates * Assorted bugfixes * Add the basics of NUMA associativity to the spapr PCI host bridge This touches some test files and monitor.c which are technically outside the ppc code, but coming through this tree because the changes are primarily of interest to ppc. ---------------------------------------------------------------- Alexey Kardashevskiy (1): spapr_pci: Add numa node id Benjamin Herrenschmidt (3): ppc: restrict the use of the rfi instruction ppc: Fix signal delivery in ppc-user and ppc64-user ppc/xics: An ICS with offset 0 is assumed to be uninitialized Bharata B Rao (1): spapr: Introduce sPAPRCPUCoreClass David Gibson (1): monitor: fix crash for platforms without a CPU 0 Greg Kurz (1): MAINTAINERS: add sPAPR tests John Arbuckle (4): adb-keys.h: initial commit adb.c: add support for QKeyCode adb.c: correct several key assignments adb.c: prevent NO_KEY value from going to guest Laurent Vivier (8): qtest: replace strtoXX() by qemu_strtoXX() libqos: define SPAPR libqos functions tests: add RTAS command in the protocol spapr_drc: convert to trace framework instead of DPRINTF spapr_rtas: convert to trace framework instead of DPRINTF spapr_vio: convert to trace framework instead of DPRINTF spapr_llan: convert to trace framework instead of DPRINTF spapr_vscsi: convert to trace framework instead of DPRINTF Michael Walle (1): linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP Nathan Whitehorn (1): Enable H_CLEAR_MOD and H_CLEAR_REF hypercalls on KVM/PPC64. Nikunj A Dadhania (16): target-ppc: consolidate load operations target-ppc: convert ld64 to use new macro target-ppc: convert ld[16,32,64]ur to use new macro target-ppc: consolidate store operations target-ppc: convert st64 to use new macro target-ppc: convert st[16,32,64]r to use new macro target-ppc: consolidate load with reservation target-ppc: move out stqcx impementation target-ppc: consolidate store conditional target-ppc: add xxspltib instruction target-ppc: add lxsi[bw]zx instruction target-ppc: add stxsi[bh]x instruction target-ppc: add TLB_NEED_LOCAL_FLUSH flag target-ppc: add flag in check_tlb_flush() target-ppc: tlbie/tlbivax should have global effect ppc/xics: account correct irq status Rajalakshmi Srinivasaraghavan (5): target-ppc: add vector insert instructions target-ppc: add vector extract instructions target-ppc: add vector count trailing zeros instructions target-ppc: add vector bit permute doubleword instruction target-ppc: add vector permute right indexed instruction Ravi Bangoria (1): target-ppc: implement darn instruction Thomas Huth (2): MAINTAINERS: Add some missing ppc-related files ppc/kvm: Mark 64kB page size support as disabled if not available MAINTAINERS | 15 ++ hw/input/adb.c | 229 ++++++++++++++++---- hw/intc/xics.c | 7 +- hw/net/spapr_llan.c | 61 +++--- hw/net/trace-events | 16 ++ hw/ppc/spapr.c | 9 +- hw/ppc/spapr_cpu_core.c | 104 ++++----- hw/ppc/spapr_drc.c | 54 ++--- hw/ppc/spapr_hcall.c | 6 +- hw/ppc/spapr_pci.c | 13 ++ hw/ppc/spapr_rtas.c | 49 +++-- hw/ppc/spapr_vio.c | 17 +- hw/ppc/trace-events | 33 +++ hw/scsi/spapr_vscsi.c | 88 +++----- hw/scsi/trace-events | 27 +++ include/hw/input/adb-keys.h | 141 ++++++++++++ include/hw/pci-host/spapr.h | 2 + include/hw/ppc/spapr_cpu_core.h | 11 +- include/hw/ppc/spapr_rtas.h | 10 + include/hw/ppc/xics.h | 2 +- linux-user/elfload.c | 8 +- linux-user/main.c | 2 +- linux-user/ppc/syscall_nr.h | 2 + linux-user/signal.c | 124 +++++++---- monitor.c | 2 +- qtest.c | 66 ++++-- target-ppc/cpu.h | 2 + target-ppc/excp_helper.c | 4 +- target-ppc/helper.h | 19 +- target-ppc/helper_regs.h | 25 ++- target-ppc/int_helper.c | 119 ++++++++++ target-ppc/kvm.c | 35 +-- target-ppc/kvm_ppc.h | 5 + target-ppc/mmu-hash64.c | 6 +- target-ppc/mmu_helper.c | 25 ++- target-ppc/translate.c | 421 ++++++++++++++++++------------------ target-ppc/translate/fp-impl.inc.c | 84 +++---- target-ppc/translate/fp-ops.inc.c | 2 +- target-ppc/translate/spe-impl.inc.c | 4 +- target-ppc/translate/vmx-impl.inc.c | 104 ++++++++- target-ppc/translate/vmx-ops.inc.c | 38 +++- target-ppc/translate/vsx-impl.inc.c | 39 +++- target-ppc/translate/vsx-ops.inc.c | 9 + tests/Makefile.include | 5 + tests/libqos/libqos-pc.c | 2 + tests/libqos/libqos-spapr.c | 30 +++ tests/libqos/libqos-spapr.h | 10 + tests/libqos/libqos.c | 1 - tests/libqos/malloc-spapr.c | 38 ++++ tests/libqos/malloc-spapr.h | 17 ++ tests/libqos/rtas.c | 71 ++++++ tests/libqos/rtas.h | 11 + tests/libqtest.c | 10 + tests/libqtest.h | 15 ++ tests/rtas-test.c | 41 ++++ 55 files changed, 1633 insertions(+), 657 deletions(-) create mode 100644 include/hw/input/adb-keys.h create mode 100644 include/hw/ppc/spapr_rtas.h create mode 100644 tests/libqos/libqos-spapr.c create mode 100644 tests/libqos/libqos-spapr.h create mode 100644 tests/libqos/malloc-spapr.c create mode 100644 tests/libqos/malloc-spapr.h create mode 100644 tests/libqos/rtas.c create mode 100644 tests/libqos/rtas.h create mode 100644 tests/rtas-test.c