| Message ID | 4CADA663.4070501@canonical.com |
|---|---|
| State | Accepted |
| Delegated to: | Leann Ogasawara |
| Headers | show |
>> If there are two separate patches upstream, then it is better to apply >> them individually. That is also better when asking upstream stable about >> including the patches (which we should do as well. did you?). > > I intend to do so, assuming all goes well here. Hi David, Insure you read the these documents before you send your patches upstream. They can be very picky about the way you present them. For instance, they need to be sent in-line rather than as attachments. Documentation/email-clients.txt Documentation/SubmitChecklist Documentation/SubmittingPatches Hope this helps. Kind regards, Lee
Applied to Lucid linux master. Thanks, Leann On Thu, 2010-10-07 at 12:52 +0200, David Henningsson wrote: > On 2010-10-07 11:01, Stefan Bader wrote: > > On 10/07/2010 09:37 AM, David Henningsson wrote: > >> BugLink: https://launchpad.net/bugs/655386 > >> BugLink: https://launchpad.net/bugs/546769 > >> BugLink: https://launchpad.net/bugs/648871 > >> BugLink: https://launchpad.net/bugs/642892 > >> BugLink: https://launchpad.net/bugs/637291 > >> BugLink: https://launchpad.net/bugs/637291 > >> BugLink: https://launchpad.net/bugs/598938 > >> > >> SRU Justification (and if that was needed for the Maverick one as well - > >> the same applies there): > >> > >> Impact: Playback and/or recording not working on several new Sony Vaios. > >> Some report very faint sound, others no sound at all. I guess we get at > >> least one bug a week for Lucid on these machines. > >> > >> Fix: Add fixup verbs to send to the codec. > >> > >> Testcase: We ask users to install the latest snapshot, they report back > >> and it has fixed their problem. > >> > >> Regression potential: very low as it only affects Sony Vaios with the > >> ALC269 chip. > >> > >> This Lucid version of the patch also piggybacks a fix for Dell Inspiron > >> M101z, which is already in Maverick. > >> > > > > From the contents it looks ok to me. My only concern would be not to piggy-bag > > patches. > > Okay, here's a revised version that does not include anything for M101z. > > > If there are two separate patches upstream, then it is better to apply > > them individually. That is also better when asking upstream stable about > > including the patches (which we should do as well. did you?). > > I intend to do so, assuming all goes well here. >
From e964a72e368afa20c601147ba67b49aeafa54bad Mon Sep 17 00:00:00 2001 From: David Henningsson <david.henningsson@canonical.com> Date: Thu, 7 Oct 2010 10:26:41 +0200 Subject: [PATCH] Backport ALC269 fixup verbs for sony vaio Signed-off-by: David Henningsson <david.henningsson@canonical.com> --- sound/pci/hda/patch_realtek.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 06c118c..c8df557 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -13565,6 +13565,25 @@ static struct alc_config_preset alc269_presets[] = { }, }; +enum { + ALC269_FIXUP_SONY_VAIO, +}; + +static const struct alc_fixup alc269_fixups[] = { + [ALC269_FIXUP_SONY_VAIO] = { + .verbs = (const struct hda_verb[]) { + {0x19, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREFGRD}, + {} + } + }, +}; + +static struct snd_pci_quirk alc269_fixup_tbl[] = { + SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO), + {} +}; + + static int patch_alc269(struct hda_codec *codec) { struct alc_spec *spec; @@ -13632,6 +13651,9 @@ static int patch_alc269(struct hda_codec *codec) set_capture_mixer(codec); set_beep_amp(spec, 0x0b, 0x04, HDA_INPUT); + if (board_config == ALC269_AUTO) + alc_pick_fixup(codec, alc269_fixup_tbl, alc269_fixups); + spec->vmaster_nid = 0x02; codec->patch_ops = alc_patch_ops; -- 1.7.1