| Message ID | 1473279684-5337-1-git-send-email-romain.naour@gmail.com |
|---|---|
| State | Accepted |
| Commit | 5609fe65aa7a3b85f1226f57439abd07a2869fae |
| Headers | show |
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes: > Don't use make install otherwise stress-ng will be rebuild without > required link libraries if any. Furthermore, using INSTALL allow to > set the file permission correcly on the target. > Fixes: > http://autobuild.buildroot.net/results/bba/bba4d0b635ab6849f969b8a0363ebe9f5fafd82e > Signed-off-by: Romain Naour <romain.naour@gmail.com> > --- > package/stress-ng/stress-ng.mk | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > diff --git a/package/stress-ng/stress-ng.mk b/package/stress-ng/stress-ng.mk > index 6015a1e..e12895a 100644 > --- a/package/stress-ng/stress-ng.mk > +++ b/package/stress-ng/stress-ng.mk > @@ -15,8 +15,11 @@ define STRESS_NG_BUILD_CMDS > $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) > endef > +# Don't use make install otherwise stress-ng will be rebuild without > +# required link libraries if any. Furthermore, using INSTALL allow to > +# set the file permission correcly on the target. > define STRESS_NG_INSTALL_TARGET_CMDS > - $(TARGET_CONFIGURE_OPTS) $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install > + $(INSTALL) -m 0755 -D $(@D)/stress-ng $(TARGET_DIR)/usr/bin/stress-ng > endef It is a bit funky that this happens, but I guess it is because of the touch stress-ng.c in the rule for stress-vecmath.o. I'm not sure why they do that. Committed, thanks.
diff --git a/package/stress-ng/stress-ng.mk b/package/stress-ng/stress-ng.mk index 6015a1e..e12895a 100644 --- a/package/stress-ng/stress-ng.mk +++ b/package/stress-ng/stress-ng.mk @@ -15,8 +15,11 @@ define STRESS_NG_BUILD_CMDS $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) endef +# Don't use make install otherwise stress-ng will be rebuild without +# required link libraries if any. Furthermore, using INSTALL allow to +# set the file permission correcly on the target. define STRESS_NG_INSTALL_TARGET_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) DESTDIR=$(TARGET_DIR) -C $(@D) install + $(INSTALL) -m 0755 -D $(@D)/stress-ng $(TARGET_DIR)/usr/bin/stress-ng endef $(eval $(generic-package))
Don't use make install otherwise stress-ng will be rebuild without required link libraries if any. Furthermore, using INSTALL allow to set the file permission correcly on the target. Fixes: http://autobuild.buildroot.net/results/bba/bba4d0b635ab6849f969b8a0363ebe9f5fafd82e Signed-off-by: Romain Naour <romain.naour@gmail.com> --- package/stress-ng/stress-ng.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)