diff mbox

package/neon: properly enable expat

Message ID 1472463566-10906-1-git-send-email-yann.morin.1998@free.fr
State Accepted
Commit 9962fea8893a6a6f12040cbd5c80ae8f2fbf08ab
Headers show

Commit Message

Yann E. MORIN Aug. 29, 2016, 9:39 a.m. UTC
Currently, we forcibly tell neon's configure where to look for libexpat.
This means that neon does not search for it, and consequently forgets to
add -lexpat as its Libs.Private in its .pc file. As thus, a static link
against neon forgets to pull in -lexpat (it works for a dynamic link
because libneon has a NEEDED on libexpat).

The reason for specifying the explicit path in this case is lost to
history; neon's configure can correctly find libexpat nowadays.

Fixes:
    http://autobuild.buildroot.org/results/884/884746351fc47f4ad19fb3fda7c5e0ee85fcff15/
    http://autobuild.buildroot.org/results/0c5/0c584522c26640e29980150a87a5b5d8c02e5f8b/

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/neon/neon.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Aug. 29, 2016, 11:28 a.m. UTC | #1
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Currently, we forcibly tell neon's configure where to look for libexpat.
 > This means that neon does not search for it, and consequently forgets to
 > add -lexpat as its Libs.Private in its .pc file. As thus, a static link
 > against neon forgets to pull in -lexpat (it works for a dynamic link
 > because libneon has a NEEDED on libexpat).

 > The reason for specifying the explicit path in this case is lost to
 > history; neon's configure can correctly find libexpat nowadays.

 > Fixes:
 >     http://autobuild.buildroot.org/results/884/884746351fc47f4ad19fb3fda7c5e0ee85fcff15/
 >     http://autobuild.buildroot.org/results/0c5/0c584522c26640e29980150a87a5b5d8c02e5f8b/

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Committed, thanks.
diff mbox

Patch

diff --git a/package/neon/neon.mk b/package/neon/neon.mk
index 0cff1a2..13d8084 100644
--- a/package/neon/neon.mk
+++ b/package/neon/neon.mk
@@ -28,7 +28,7 @@  NEON_CONF_OPTS += --without-ssl
 endif
 
 ifeq ($(BR2_PACKAGE_NEON_EXPAT),y)
-NEON_CONF_OPTS += --with-expat=$(STAGING_DIR)/usr/lib/libexpat.la
+NEON_CONF_OPTS += --with-expat=yes
 NEON_DEPENDENCIES += expat
 else
 NEON_CONF_OPTS += --with-expat=no