| Message ID | 20160827115355.26063-3-lokeshvutla@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
On Sat, Aug 27, 2016 at 05:23:55PM +0530, Lokesh Vutla wrote: > Enable CONFIG_DISPLAY_{CPU/BOARD}INFO on all TI platforms. > Also removing the duplicated configs. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > include/configs/ti_armv7_common.h | 4 ++++ > include/configs/ti_armv7_keystone2.h | 1 - > include/configs/ti_omap4_common.h | 2 -- > include/configs/ti_omap5_common.h | 3 --- > 4 files changed, 4 insertions(+), 6 deletions(-) This is the wrong direction. Please add an entry to common/Kconfig (a "hidden" one) and select it from board/ti/*/Kconfig. And this will need some cleaning up of some other boards/ Kconfig files that introduced it locally and instead should select this new option. Thanks!
On Monday 29 August 2016 01:46 AM, Tom Rini wrote: > On Sat, Aug 27, 2016 at 05:23:55PM +0530, Lokesh Vutla wrote: > >> Enable CONFIG_DISPLAY_{CPU/BOARD}INFO on all TI platforms. >> Also removing the duplicated configs. >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> --- >> include/configs/ti_armv7_common.h | 4 ++++ >> include/configs/ti_armv7_keystone2.h | 1 - >> include/configs/ti_omap4_common.h | 2 -- >> include/configs/ti_omap5_common.h | 3 --- >> 4 files changed, 4 insertions(+), 6 deletions(-) > > This is the wrong direction. Please add an entry to common/Kconfig (a > "hidden" one) and select it from board/ti/*/Kconfig. And this will need Sure, will update the patch to add a common Kconfig entry. But I am not sure about the statement "select it from board/ti/*/Kconfig". You meant it should be selected by every config TARGET_XXX_EVM or something else? > some cleaning up of some other boards/ Kconfig files that introduced it > locally and instead should select this new option. Thanks! okay, will do it. Thanks and regards, Lokesh
diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h index 9f947ee..b11ddb2 100644 --- a/include/configs/ti_armv7_common.h +++ b/include/configs/ti_armv7_common.h @@ -284,6 +284,10 @@ #endif #endif /* !CONFIG_NOR_BOOT */ +/* Display CPU and Board info */ +#define CONFIG_DISPLAY_CPUINFO +#define CONFIG_DISPLAY_BOARDINFO + /* Generic Environment Variables */ #ifdef CONFIG_CMD_NET diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h index 4aa262e..9241323 100644 --- a/include/configs/ti_armv7_keystone2.h +++ b/include/configs/ti_armv7_keystone2.h @@ -15,7 +15,6 @@ /* U-Boot Build Configuration */ #define CONFIG_SKIP_LOWLEVEL_INIT /* U-Boot is a 2nd stage loader */ #define CONFIG_BOARD_EARLY_INIT_F -#define CONFIG_DISPLAY_CPUINFO /* SoC Configuration */ #define CONFIG_ARCH_CPU_INIT diff --git a/include/configs/ti_omap4_common.h b/include/configs/ti_omap4_common.h index 5fad3c1..24d4c83 100644 --- a/include/configs/ti_omap4_common.h +++ b/include/configs/ti_omap4_common.h @@ -17,8 +17,6 @@ */ #define CONFIG_OMAP4430 1 /* which is in a 4430 */ #define CONFIG_MISC_INIT_R -#define CONFIG_DISPLAY_CPUINFO 1 -#define CONFIG_DISPLAY_BOARDINFO 1 #define CONFIG_SYS_THUMB_BUILD diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h index 3589cdc..2d859e1 100644 --- a/include/configs/ti_omap5_common.h +++ b/include/configs/ti_omap5_common.h @@ -17,9 +17,6 @@ #ifndef __CONFIG_TI_OMAP5_COMMON_H #define __CONFIG_TI_OMAP5_COMMON_H -#define CONFIG_DISPLAY_CPUINFO -#define CONFIG_DISPLAY_BOARDINFO - /* Common ARM Erratas */ #define CONFIG_ARM_ERRATA_798870
Enable CONFIG_DISPLAY_{CPU/BOARD}INFO on all TI platforms. Also removing the duplicated configs. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- include/configs/ti_armv7_common.h | 4 ++++ include/configs/ti_armv7_keystone2.h | 1 - include/configs/ti_omap4_common.h | 2 -- include/configs/ti_omap5_common.h | 3 --- 4 files changed, 4 insertions(+), 6 deletions(-)