diff mbox

[U-Boot,5/8] armv8: fsl-layerscape: add define CONFIG_STANDALONE_LOAD_ADDR for standalone app

Message ID 1472210916-36539-6-git-send-email-Qianyu.Gong@nxp.com
State Accepted
Commit a8c9d66c644dbfef6b953ab530565da3f61c6665
Delegated to: York Sun
Headers show

Commit Message

Gong Qianyu Aug. 26, 2016, 11:28 a.m. UTC 
From: Shaohui Xie <Shaohui.Xie@nxp.com>

The CONFIG_STANDALONE_LOAD_ADDR is set to 0x80300000 by default.

Signed-off-by: Shaohui Xie <Shaohui.Xie@nxp.com>
Signed-off-by: Gong Qianyu <Qianyu.Gong@nxp.com>
---
 arch/arm/include/asm/arch-fsl-layerscape/config.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

York Sun Aug. 26, 2016, 4:05 p.m. UTC | #1 
On 08/26/2016 04:40 AM, Gong Qianyu wrote:
> From: Shaohui Xie <Shaohui.Xie@nxp.com>
>
> The CONFIG_STANDALONE_LOAD_ADDR is set to 0x80300000 by default.
>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@nxp.com>
> Signed-off-by: Gong Qianyu <Qianyu.Gong@nxp.com>
> ---
>  arch/arm/include/asm/arch-fsl-layerscape/config.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> index b0ad4b4..c7e374c 100644
> --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> @@ -9,6 +9,8 @@
>
>  #include <fsl_ddrc_version.h>
>
> +#define CONFIG_STANDALONE_LOAD_ADDR	0x80300000
> +

Do you really need this? It is default to 0x80300000 in arch/arm/config.mk.

York
shaohui xie Aug. 29, 2016, 4:58 a.m. UTC | #2 
> On 08/26/2016 04:40 AM, Gong Qianyu wrote:
> > From: Shaohui Xie <Shaohui.Xie@nxp.com>
> >
> > The CONFIG_STANDALONE_LOAD_ADDR is set to 0x80300000 by default.
> >
> > Signed-off-by: Shaohui Xie <Shaohui.Xie@nxp.com>
> > Signed-off-by: Gong Qianyu <Qianyu.Gong@nxp.com>
> > ---
> >  arch/arm/include/asm/arch-fsl-layerscape/config.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h
> b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> > index b0ad4b4..c7e374c 100644
> > --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
> > +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> > @@ -9,6 +9,8 @@
> >
> >  #include <fsl_ddrc_version.h>
> >
> > +#define CONFIG_STANDALONE_LOAD_ADDR	0x80300000
> > +
> 
> Do you really need this? It is default to 0x80300000 in arch/arm/config.mk.
[S.H] It's needed, in the arch/arm/config.mk, it's defined as:

ifndef CONFIG_STANDALONE_LOAD_ADDR
ifneq ($(CONFIG_OMAP_COMMON),)
CONFIG_STANDALONE_LOAD_ADDR = 0x80300000
else
CONFIG_STANDALONE_LOAD_ADDR = 0xc100000
endif
endif

we need the CONFIG_STANDALONE_LOAD_ADDR defined as a valid address for ARM.
The proposed patch is to clearly define the CONFIG_STANDALONE_LOAD_ADDR for our SOCs.

Thanks,
Shaohui
York Sun Aug. 29, 2016, 3:32 p.m. UTC | #3 
On 08/28/2016 09:58 PM, Shaohui Xie wrote:
>> On 08/26/2016 04:40 AM, Gong Qianyu wrote:
>>> From: Shaohui Xie <Shaohui.Xie@nxp.com>
>>>
>>> The CONFIG_STANDALONE_LOAD_ADDR is set to 0x80300000 by default.
>>>
>>> Signed-off-by: Shaohui Xie <Shaohui.Xie@nxp.com>
>>> Signed-off-by: Gong Qianyu <Qianyu.Gong@nxp.com>
>>> ---
>>>  arch/arm/include/asm/arch-fsl-layerscape/config.h | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h
>> b/arch/arm/include/asm/arch-fsl-layerscape/config.h
>>> index b0ad4b4..c7e374c 100644
>>> --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
>>> +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
>>> @@ -9,6 +9,8 @@
>>>
>>>  #include <fsl_ddrc_version.h>
>>>
>>> +#define CONFIG_STANDALONE_LOAD_ADDR	0x80300000
>>> +
>>
>> Do you really need this? It is default to 0x80300000 in arch/arm/config.mk.
> [S.H] It's needed, in the arch/arm/config.mk, it's defined as:
>
> ifndef CONFIG_STANDALONE_LOAD_ADDR
> ifneq ($(CONFIG_OMAP_COMMON),)
> CONFIG_STANDALONE_LOAD_ADDR = 0x80300000
> else
> CONFIG_STANDALONE_LOAD_ADDR = 0xc100000
> endif
> endif
>
> we need the CONFIG_STANDALONE_LOAD_ADDR defined as a valid address for ARM.
> The proposed patch is to clearly define the CONFIG_STANDALONE_LOAD_ADDR for our SOCs.
>

All right. Somehow I remember using 0x80300000 before, without this 
change. I must have it set somewhere else.

York
diff mbox

Patch

diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h
index b0ad4b4..c7e374c 100644
--- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
+++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
@@ -9,6 +9,8 @@ 
 
 #include <fsl_ddrc_version.h>
 
+#define CONFIG_STANDALONE_LOAD_ADDR	0x80300000
+
 #ifdef CONFIG_SYS_FSL_DDR4
 #define CONFIG_SYS_FSL_DDRC_GEN4
 #else