diff mbox

Do not generate an unused and invalid Request Authenticator when constructing Accounting-Request packets.

Message ID CAGnO3drVR80XG2vhDF_ROvkuf1WTQqo54EX8n1LDgwjWj56w-Q@mail.gmail.com
State Accepted
Headers show

Commit Message

Nick Lowe Aug. 14, 2016, 2:46 p.m. UTC
Do not generate an unused and invalid Request Authenticator
 when constructing Accounting-Request packets. The correct Request
 Authenticator is calculated subsequently.

Signed-off-by: Nick Lowe <nick.lowe@lugatech.com>
---
 src/ap/accounting.c | 5 -----
 1 file changed, 5 deletions(-)

  wpa_printf(MSG_INFO, "Could not add Acct-Status-Type");

Comments

Jouni Malinen Sept. 21, 2016, 10:30 p.m. UTC | #1
On Sun, Aug 14, 2016 at 03:46:57PM +0100, Nick Lowe wrote:
>  Do not generate an unused and invalid Request Authenticator
>  when constructing Accounting-Request packets. The correct Request
>  Authenticator is calculated subsequently.

Thanks, applied.
diff mbox

Patch

diff --git a/src/ap/accounting.c b/src/ap/accounting.c
index 854174e..0aacc3c 100644
--- a/src/ap/accounting.c
+++ b/src/ap/accounting.c
@@ -50,11 +50,6 @@  static struct radius_msg * accounting_msg(struct
hostapd_data *hapd,
  return NULL;
  }

- if (radius_msg_make_authenticator(msg) < 0) {
- wpa_printf(MSG_INFO, "Could not make Request Authenticator");
- goto fail;
- }
-
  if (!radius_msg_add_attr_int32(msg, RADIUS_ATTR_ACCT_STATUS_TYPE,
        status_type)) {