From patchwork Sun Aug 14 14:46:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Lowe X-Patchwork-Id: 659039 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sC1gh0shRz9s2G for ; Mon, 15 Aug 2016 00:47:43 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=lugatech-com.20150623.gappssmtp.com header.i=@lugatech-com.20150623.gappssmtp.com header.b=R93k1/mU; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bYwh9-00007J-Q6; Sun, 14 Aug 2016 14:47:23 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bYwh7-0008WB-6S for hostap@lists.infradead.org; Sun, 14 Aug 2016 14:47:22 +0000 Received: by mail-wm0-x242.google.com with SMTP id o80so6703253wme.0 for ; Sun, 14 Aug 2016 07:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lugatech-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=o+7pgIKEnYg5Ew8iDZk8lM7Y4hEM2ByszToz/Af30kE=; b=R93k1/mUPESV3U1zz5gKK9IJVnXAhzutz2W+Zd+7eswg3VBThQXulk7fO1fBleTl6R PGAsghA1hPab1wYdfKoirxQScrC/t+9nME+VqPOI9HkNWQ9M5PTsKkBHdBXgC3VFC6NE L1QDgT3xmoVECp7w404fRdj2XMEv3fscR3WWlw81FwAiOfWGXc8h81SzPxBo+I9gVDtJ yG7/XQs0losNVYlKxlvslUHaKfZpqJvWnI5qLVfQHAvEaxqdy/9SjJt44KfLBPFyS/RB FA+eDzIgbfjdPJnipBPHcPduijhtdvoepAzH3cW2jDJm5CbXxq+FyXsCF/Q2A0qzf6C6 LNrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=o+7pgIKEnYg5Ew8iDZk8lM7Y4hEM2ByszToz/Af30kE=; b=NreVG3lbxXpFVAg9+3UbayYrkZiEeXxYeXvL8uNSSUdc2q34HuYDP8f/JDSWmyiPPb wRW2R56hIxUirmsPXqkTa5Y6R4nCze77vonyijzW56gKxjAakzQJy9zKH5f74l4KbzIs pBXX3nJhW/bZ/8Wm0Jtr7nt+KLmcxmMgVItWb/VAsPg76IjJDj+eR+ryvX0RdRiRKwGy D+mhP1lioXccO3TvyglklzL41AhsSt8CqJBeq5MuUUg8I9RT9DPxM4kB+aCYnXpMXVPp VmLY0fme7sdgoCYtM5ApmIO/ZvHVQX1GGg8BoUad7MiBVC/HiDN497Rx/yiGl2rvBfig yasA== X-Gm-Message-State: AEkoous+xzkKD7N+DpQ14qYd7VQ/KZTFPI3W/rSWCAT4Z/qoAdRtQZAWtlHMazU4Eqsp5CXu2uPtAbxZewm5og== X-Received: by 10.194.106.36 with SMTP id gr4mr2560405wjb.107.1471186018104; Sun, 14 Aug 2016 07:46:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.71.5 with HTTP; Sun, 14 Aug 2016 07:46:57 -0700 (PDT) X-Originating-IP: [81.133.41.11] From: Nick Lowe Date: Sun, 14 Aug 2016 15:46:57 +0100 Message-ID: Subject: [PATCH] Do not generate an unused and invalid Request Authenticator when constructing Accounting-Request packets. To: hostap@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160814_074721_437061_852B490A X-CRM114-Status: UNSURE ( 8.09 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:242 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Do not generate an unused and invalid Request Authenticator when constructing Accounting-Request packets. The correct Request Authenticator is calculated subsequently. Signed-off-by: Nick Lowe --- src/ap/accounting.c | 5 ----- 1 file changed, 5 deletions(-) wpa_printf(MSG_INFO, "Could not add Acct-Status-Type"); diff --git a/src/ap/accounting.c b/src/ap/accounting.c index 854174e..0aacc3c 100644 --- a/src/ap/accounting.c +++ b/src/ap/accounting.c @@ -50,11 +50,6 @@ static struct radius_msg * accounting_msg(struct hostapd_data *hapd, return NULL; } - if (radius_msg_make_authenticator(msg) < 0) { - wpa_printf(MSG_INFO, "Could not make Request Authenticator"); - goto fail; - } - if (!radius_msg_add_attr_int32(msg, RADIUS_ATTR_ACCT_STATUS_TYPE, status_type)) {