| Message ID | 1469973369-5445-1-git-send-email-bgolaszewski@baylibre.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Sun, 31 Jul 2016 15:56:09 +0200, Bartosz Golaszewski wrote: > As of version 1.25.0 busybox by default includes a nearly complete > implementation of i2c-tools. Hide the upstream version unless the > BR2_PACKAGE_BUSYBOX_SHOW_OTHERS option is selected. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski at baylibre.com> > --- > package/i2c-tools/Config.in | 1 + > 1 file changed, 1 insertion(+) Applied to master, thanks. However, I noticed that the Busybox symlinks are installed in usr/sbin, while the full-blown i2c-tools binaries are installed in usr/bin. Perhaps we should install the i2c-tools binaries in usr/sbin, to follow what Busybox does, and have i2c-tools add busybox to its DEPENDENCIES when busybox is enabled, so that it overwrites the Busybox symlinks? Peter? Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes: > Hello, > On Sun, 31 Jul 2016 15:56:09 +0200, Bartosz Golaszewski wrote: >> As of version 1.25.0 busybox by default includes a nearly complete >> implementation of i2c-tools. Hide the upstream version unless the >> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS option is selected. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski at baylibre.com> >> --- >> package/i2c-tools/Config.in | 1 + >> 1 file changed, 1 insertion(+) > Applied to master, thanks. However, I noticed that the Busybox symlinks > are installed in usr/sbin, while the full-blown i2c-tools binaries are > installed in usr/bin. Perhaps we should install the i2c-tools binaries > in usr/sbin, to follow what Busybox does, and have i2c-tools add > busybox to its DEPENDENCIES when busybox is enabled, so that it > overwrites the Busybox symlinks? > Peter? Yes, I think that would be a good idea. E.G. Debian also install them into usr/sbin: https://packages.debian.org/stretch/amd64/i2c-tools/filelist
2016-08-01 23:24 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > Hello, > > On Sun, 31 Jul 2016 15:56:09 +0200, Bartosz Golaszewski wrote: >> As of version 1.25.0 busybox by default includes a nearly complete >> implementation of i2c-tools. Hide the upstream version unless the >> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS option is selected. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> --- >> package/i2c-tools/Config.in | 1 + >> 1 file changed, 1 insertion(+) > > Applied to master, thanks. However, I noticed that the Busybox symlinks > are installed in usr/sbin, while the full-blown i2c-tools binaries are > installed in usr/bin. Perhaps we should install the i2c-tools binaries > in usr/sbin, to follow what Busybox does, and have i2c-tools add > busybox to its DEPENDENCIES when busybox is enabled, so that it > overwrites the Busybox symlinks? Hi Thomas, thanks for the suggestion. I sent two follow-up patches. Best regards, Bartosz Golaszewski
diff --git a/package/i2c-tools/Config.in b/package/i2c-tools/Config.in index e83dbd6..b82c7dc 100644 --- a/package/i2c-tools/Config.in +++ b/package/i2c-tools/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_I2C_TOOLS bool "i2c-tools" + depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS help Heterogeneous set of I2C tools for Linux
As of version 1.25.0 busybox by default includes a nearly complete implementation of i2c-tools. Hide the upstream version unless the BR2_PACKAGE_BUSYBOX_SHOW_OTHERS option is selected. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- package/i2c-tools/Config.in | 1 + 1 file changed, 1 insertion(+)