[ovs-dev,2/4] system-common-macros.at: Add a iface-id to interfaces.
diff mbox

Message ID 1468305329-28456-2-git-send-email-guru@ovn.org
State Superseded
Headers show

Commit Message

Guru Shetty July 12, 2016, 6:35 a.m. UTC
IntegrationGuide.md explains the meaning of the key 'iface-id'. Adding
it as part of ADD_VETH is useful for OVN related tests. For non-OVN
tests, it should have no effect. Upcoming commits take advantage of this.

Signed-off-by: Gurucharan Shetty <guru@ovn.org>
---
 tests/system-common-macros.at | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Joe Stringer July 13, 2016, 12:15 a.m. UTC | #1
On 11 July 2016 at 23:35, Gurucharan Shetty <guru@ovn.org> wrote:
> IntegrationGuide.md explains the meaning of the key 'iface-id'. Adding
> it as part of ADD_VETH is useful for OVN related tests. For non-OVN
> tests, it should have no effect. Upcoming commits take advantage of this.
>
> Signed-off-by: Gurucharan Shetty <guru@ovn.org>

Acked-by: Joe Stringer <joe@ovn.org>

Patch
diff mbox

diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 27fceed..4ffc382 100644
--- a/tests/system-common-macros.at
+++ b/tests/system-common-macros.at
@@ -74,7 +74,8 @@  m4_define([ADD_VETH],
       CONFIGURE_VETH_OFFLOADS([$1])
       AT_CHECK([ip link set $1 netns $2])
       AT_CHECK([ip link set dev ovs-$1 up])
-      AT_CHECK([ovs-vsctl add-port $3 ovs-$1])
+      AT_CHECK([ovs-vsctl add-port $3 ovs-$1 -- \
+                set interface ovs-$1 external-ids:iface-id="$1"])
       NS_CHECK_EXEC([$2], [ip addr add $4 dev $1])
       NS_CHECK_EXEC([$2], [ip link set dev $1 up])
       if test -n "$5"; then