From patchwork Tue Jul 12 06:35:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gurucharan Shetty X-Patchwork-Id: 647505 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rpnc26Rmqz9s5Q for ; Wed, 13 Jul 2016 02:34:26 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 73286108B2; Tue, 12 Jul 2016 09:34:23 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id DDA3510868 for ; Tue, 12 Jul 2016 09:34:20 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 6E5D3162645 for ; Tue, 12 Jul 2016 10:34:20 -0600 (MDT) X-ASG-Debug-ID: 1468341260-0b3237070119ff0001-byXFYA Received: from mx3-pf1.cudamail.com ([192.168.14.2]) by bar6.cudamail.com with ESMTP id uDo3RNTK0B2O8bEn (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 12 Jul 2016 10:34:20 -0600 (MDT) X-Barracuda-Envelope-From: guru.ovn@gmail.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.2 Received: from unknown (HELO mail-pa0-f67.google.com) (209.85.220.67) by mx3-pf1.cudamail.com with ESMTPS (AES128-SHA encrypted); 12 Jul 2016 16:34:19 -0000 Received-SPF: pass (mx3-pf1.cudamail.com: SPF record at _netblocks.google.com designates 209.85.220.67 as permitted sender) X-Barracuda-Apparent-Source-IP: 209.85.220.67 X-Barracuda-RBL-IP: 209.85.220.67 Received: by mail-pa0-f67.google.com with SMTP id dx3so1334275pab.2 for ; Tue, 12 Jul 2016 09:34:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=h08NpCe+6UvG6YoIKzVOCC+s1QpcvTtIUcBXw+eO1YE=; b=H1W5vUtI2j09pW6UIJvQTaKpbYhDpesdAalDfXXPZZvFIva/UTuWMWg5hlsqU8QA68 5oWk6df3AZ5L+qLtQ2LqEWIeEUE+36PcQyRoDKsxGYIQGl83ZFGDybCcu3e8dnrbfwj1 wn+nCGdM5GJKzIYiDgtbLgmRqodXkK9DwT/MnC+wD9kjDEMmG+/dHz2ZilVrtiRlG5x3 hgYM4Mt1UyRwiomdbuCQIy1fffJwFlWvBsijvSCSOfZK81IhYmJHGEQTkD465+wl7Hy0 uCmM01JU3GJT1zFO/8K07CgGxLPvyRWHEaBHB5r55KsGzLEefmu5raIgdb0JQNO5m9+e TBBA== X-Gm-Message-State: ALyK8tI6efzCLVaMqxl5P64bAlhniIZj6lf0TScQUW4obrU+dMDC7SOdFu91mV3hSRqiYg== X-Received: by 10.66.144.229 with SMTP id sp5mr5380256pab.97.1468341259242; Tue, 12 Jul 2016 09:34:19 -0700 (PDT) Received: from ovn1.eng.vmware.com ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id s3sm5728593pfb.87.2016.07.12.09.34.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jul 2016 09:34:18 -0700 (PDT) X-CudaMail-Envelope-Sender: guru.ovn@gmail.com From: Gurucharan Shetty To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V1-711028736 X-CudaMail-DTE: 071216 X-CudaMail-Originating-IP: 209.85.220.67 Date: Mon, 11 Jul 2016 23:35:27 -0700 X-ASG-Orig-Subj: [##CM-V1-711028736##][PATCH 2/4] system-common-macros.at: Add a iface-id to interfaces. Message-Id: <1468305329-28456-2-git-send-email-guru@ovn.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1468305329-28456-1-git-send-email-guru@ovn.org> References: <1468305329-28456-1-git-send-email-guru@ovn.org> X-Barracuda-Connect: UNKNOWN[192.168.14.2] X-Barracuda-Start-Time: 1468341260 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Subject: [ovs-dev] [PATCH 2/4] system-common-macros.at: Add a iface-id to interfaces. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" IntegrationGuide.md explains the meaning of the key 'iface-id'. Adding it as part of ADD_VETH is useful for OVN related tests. For non-OVN tests, it should have no effect. Upcoming commits take advantage of this. Signed-off-by: Gurucharan Shetty Acked-by: Joe Stringer --- tests/system-common-macros.at | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 27fceed..4ffc382 100644 --- a/tests/system-common-macros.at +++ b/tests/system-common-macros.at @@ -74,7 +74,8 @@ m4_define([ADD_VETH], CONFIGURE_VETH_OFFLOADS([$1]) AT_CHECK([ip link set $1 netns $2]) AT_CHECK([ip link set dev ovs-$1 up]) - AT_CHECK([ovs-vsctl add-port $3 ovs-$1]) + AT_CHECK([ovs-vsctl add-port $3 ovs-$1 -- \ + set interface ovs-$1 external-ids:iface-id="$1"]) NS_CHECK_EXEC([$2], [ip addr add $4 dev $1]) NS_CHECK_EXEC([$2], [ip link set dev $1 up]) if test -n "$5"; then