Message ID | 1468323011-1513-1-git-send-email-weiyj_lk@163.com (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
On 12/07/16 21:30, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Use for_each_compatible_node() macro instead of open coding it. > > Generated by Coccinelle. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
On Tue, 2016-12-07 at 11:30:11 UTC, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Use for_each_compatible_node() macro instead of open coding it. > > Generated by Coccinelle. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/fc9f75ef2fdf46fc859b991dbf cheers
diff --git a/drivers/misc/cxl/base.c b/drivers/misc/cxl/base.c index e6f49ac..2330980 100644 --- a/drivers/misc/cxl/base.c +++ b/drivers/misc/cxl/base.c @@ -95,7 +95,7 @@ EXPORT_SYMBOL_GPL(cxl_update_properties); static int __init cxl_base_init(void) { - struct device_node *np = NULL; + struct device_node *np; struct platform_device *dev; int count = 0; @@ -105,8 +105,7 @@ static int __init cxl_base_init(void) if (cpu_has_feature(CPU_FTR_HVMODE)) return 0; - while ((np = of_find_compatible_node(np, NULL, - "ibm,coherent-platform-facility"))) { + for_each_compatible_node(np, NULL, "ibm,coherent-platform-facility") { dev = of_platform_device_create(np, NULL, NULL); if (dev) count++;