[U-Boot,RESEND,v5,01/12] dm: core: implement dev_map_phsymem()

This API helps to map physical register addresss pace of device to
virtual address space easily. Its just a wrapper around map_physmem()
with MAP_NOCACHE flag.

Signed-off-by: Vignesh R <vigneshr@ti.com>
Suggested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jagan Teki <jteki@openedev.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 drivers/core/device.c | 11 +++++++++++
 include/dm/device.h   | 13 +++++++++++++
 2 files changed, 24 insertions(+)

Hi,

On 5 July 2016 at 22:28, Vignesh R <vigneshr@ti.com> wrote:
> This API helps to map physical register addresss pace of device to
> virtual address space easily. Its just a wrapper around map_physmem()
> with MAP_NOCACHE flag.
>

nit: dev_map_physmem() in the subject

> Signed-off-by: Vignesh R <vigneshr@ti.com>
> Suggested-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Jagan Teki <jteki@openedev.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>  drivers/core/device.c | 11 +++++++++++
>  include/dm/device.h   | 13 +++++++++++++
>  2 files changed, 24 insertions(+)
>
> diff --git a/drivers/core/device.c b/drivers/core/device.c
> index eb75b1734f9b..f7fb0cc0fa7c 100644
> --- a/drivers/core/device.c
> +++ b/drivers/core/device.c
> @@ -10,6 +10,7 @@
>   */
>
>  #include <common.h>
> +#include <asm/io.h>
>  #include <fdtdec.h>
>  #include <fdt_support.h>
>  #include <malloc.h>
> @@ -697,6 +698,16 @@ void *dev_get_addr_ptr(struct udevice *dev)
>         return (void *)(uintptr_t)dev_get_addr_index(dev, 0);
>  }
>
> +void *dev_map_physmem(struct udevice *dev, unsigned long size)
> +{
> +       fdt_addr_t addr = dev_get_addr(dev);
> +
> +       if (addr == FDT_ADDR_T_NONE)
> +               return NULL;
> +
> +       return map_physmem(addr, size, MAP_NOCACHE);
> +}
> +
>  bool device_has_children(struct udevice *dev)
>  {
>         return !list_empty(&dev->child_head);
> diff --git a/include/dm/device.h b/include/dm/device.h
> index f03bcd3b49ee..1bfcf3bcbc01 100644
> --- a/include/dm/device.h
> +++ b/include/dm/device.h
> @@ -467,6 +467,19 @@ fdt_addr_t dev_get_addr(struct udevice *dev);
>  void *dev_get_addr_ptr(struct udevice *dev);
>
>  /**
> + * dev_map_physmem() - Read device address from reg property of the
> + *                     device node and map the address into CPU address
> + *                     space.
> + *
> + * @dev: Pointer to device
> + * @size: size of the memory to map
> + *
> + * @return  mapped address, or NULL if the device does not have reg
> + *          property.
> + */
> +void *dev_map_physmem(struct udevice *dev, unsigned long size);
> +
> +/**
>   * dev_get_addr_index() - Get the indexed reg property of a device
>   *
>   * @dev: Pointer to a device
> --
> 2.9.0
>

On 7 July 2016 at 04:49, Simon Glass <sjg@chromium.org> wrote:
> Hi,
>
> On 5 July 2016 at 22:28, Vignesh R <vigneshr@ti.com> wrote:
>> This API helps to map physical register addresss pace of device to
>> virtual address space easily. Its just a wrapper around map_physmem()
>> with MAP_NOCACHE flag.
>>
>
> nit: dev_map_physmem() in the subject

Thanks for the nit Simon, updated the same!

On Saturday 09 July 2016 08:20 PM, Jagan Teki wrote:
> On 7 July 2016 at 04:49, Simon Glass <sjg@chromium.org> wrote:
>> Hi,
>>
>> On 5 July 2016 at 22:28, Vignesh R <vigneshr@ti.com> wrote:
>>> This API helps to map physical register addresss pace of device to
>>> virtual address space easily. Its just a wrapper around map_physmem()
>>> with MAP_NOCACHE flag.
>>>
>>
>> nit: dev_map_physmem() in the subject
> 
> Thanks for the nit Simon, updated the same!
> 

Thanks for fixing this!