| Message ID | 1466167331-17063-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 17/06/2016 14:42, Peter Maydell wrote: > The trace format string in nbd_send_request uses PRIu16 for > request->type, but request->type is a uint32_t. This provokes > compiler warnings on the OSX clang. Use PRIu32 instead. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > I didn't catch this when I ran the merge build test for the > pull request, because I don't have warnings-as-errors enabled > on the OSX test machine yet. Thanks, please apply directly if you wish. Paolo
On 17 June 2016 at 14:24, Paolo Bonzini <pbonzini@redhat.com> wrote: > > > On 17/06/2016 14:42, Peter Maydell wrote: >> The trace format string in nbd_send_request uses PRIu16 for >> request->type, but request->type is a uint32_t. This provokes >> compiler warnings on the OSX clang. Use PRIu32 instead. >> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> >> --- >> I didn't catch this when I ran the merge build test for the >> pull request, because I don't have warnings-as-errors enabled >> on the OSX test machine yet. > > Thanks, please apply directly if you wish. thanks, applied to master -- PMM
diff --git a/nbd/client.c b/nbd/client.c index 287487c..78a7195 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -711,7 +711,7 @@ ssize_t nbd_send_request(QIOChannel *ioc, struct nbd_request *request) TRACE("Sending request to server: " "{ .from = %" PRIu64", .len = %" PRIu32 ", .handle = %" PRIu64 - ", .type=%" PRIu16 " }", + ", .type=%" PRIu32 " }", request->from, request->len, request->handle, request->type); stl_be_p(buf, NBD_REQUEST_MAGIC);
The trace format string in nbd_send_request uses PRIu16 for request->type, but request->type is a uint32_t. This provokes compiler warnings on the OSX clang. Use PRIu32 instead. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- I didn't catch this when I ran the merge build test for the pull request, because I don't have warnings-as-errors enabled on the OSX test machine yet. nbd/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)