diff mbox

[U-Boot,v2] ARM: board: cm-fx6: fix mmc for old revisions of utilite

Message ID ce5e4909a1cc439f8e717fee3ef95fc7@rwthex-s1-b.rwth-ad.de
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Christopher Spinrath June 16, 2016, 12:02 p.m. UTC 
Old revisions of Utilite (based on cm-fx6) do not have a dedicated
card detect pin. But the card is removable by the user and card
detection can be realized with polling (e.g. supported by Linux).

Add the broken-cd property to the mmc device tree instead of the
non-removable property to make card detection possible if polling
is supported.

Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
---

Notes:
    Changes since v1:
     - remove Fixes: tag
     - add Nikita's Acked-By

 board/compulab/cm_fx6/cm_fx6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic June 18, 2016, 8:46 a.m. UTC | #1 
On 16/06/2016 14:02, Christopher Spinrath wrote:
> Old revisions of Utilite (based on cm-fx6) do not have a dedicated
> card detect pin. But the card is removable by the user and card
> detection can be realized with polling (e.g. supported by Linux).
> 
> Add the broken-cd property to the mmc device tree instead of the
> non-removable property to make card detection possible if polling
> is supported.
> 
> Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
> ---

Applied to master (bug fix), thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/compulab/cm_fx6/cm_fx6.c b/board/compulab/cm_fx6/cm_fx6.c
index a21e7b0..712057a 100644
--- a/board/compulab/cm_fx6/cm_fx6.c
+++ b/board/compulab/cm_fx6/cm_fx6.c
@@ -610,7 +610,7 @@  int ft_board_setup(void *blob, bd_t *bd)
 		fdt_shrink_to_minimum(blob); /* Make room for new properties */
 		nodeoffset = fdt_path_offset(blob, USDHC3_PATH);
 		fdt_delprop(blob, nodeoffset, "cd-gpios");
-		fdt_find_and_setprop(blob, USDHC3_PATH, "non-removable",
+		fdt_find_and_setprop(blob, USDHC3_PATH, "broken-cd",
 				     NULL, 0, 1);
 		fdt_find_and_setprop(blob, USDHC3_PATH, "keep-power-in-suspend",
 				     NULL, 0, 1);