| Message ID | 1466034578-17914-1-git-send-email-ukrishn@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 6/15/2016 6:49 PM, Uma Krishnan wrote: > Device dependent flags are needed to support functions that are > specific to a particular device. > Acked-by: Manoj N. Kumar <manoj@linux.vnet.ibm.com>
> On Jun 15, 2016, at 6:49 PM, Uma Krishnan <ukrishn@linux.vnet.ibm.com> wrote: > > Device dependent flags are needed to support functions that are > specific to a particular device. > > One such case is - some CXL Flash cards need to be notified of > device shutdown. For other CXL devices, this feature does not prove > to be useful yet. Such distinct features need to be identified in > the driver to bypass or invoke specific functionality. > > In this patch, a member 'flags' has been added to device dependent > values. These flags will be used and expanded in the future to > support various device specific functions. > > Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index f1f977f..e027fa0 100644 --- a/drivers/scsi/cxlflash/main.c +++ b/drivers/scsi/cxlflash/main.c @@ -2333,8 +2333,10 @@ static struct scsi_host_template driver_template = { /* * Device dependent values */ -static struct dev_dependent_vals dev_corsa_vals = { CXLFLASH_MAX_SECTORS }; -static struct dev_dependent_vals dev_flash_gt_vals = { CXLFLASH_MAX_SECTORS }; +static struct dev_dependent_vals dev_corsa_vals = { CXLFLASH_MAX_SECTORS, + 0ULL }; +static struct dev_dependent_vals dev_flash_gt_vals = { CXLFLASH_MAX_SECTORS, + 0ULL }; /* * PCI device binding table diff --git a/drivers/scsi/cxlflash/main.h b/drivers/scsi/cxlflash/main.h index eb9d8f7..029f517 100644 --- a/drivers/scsi/cxlflash/main.h +++ b/drivers/scsi/cxlflash/main.h @@ -88,6 +88,7 @@ enum undo_level { struct dev_dependent_vals { u64 max_sectors; + u64 flags; }; struct asyc_intr_info {
Device dependent flags are needed to support functions that are specific to a particular device. One such case is - some CXL Flash cards need to be notified of device shutdown. For other CXL devices, this feature does not prove to be useful yet. Such distinct features need to be identified in the driver to bypass or invoke specific functionality. In this patch, a member 'flags' has been added to device dependent values. These flags will be used and expanded in the future to support various device specific functions. Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 6 ++++-- drivers/scsi/cxlflash/main.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-)