| Message ID | 1465971519-22344-2-git-send-email-peng.fan@nxp.com |
|---|---|
| State | Accepted |
| Commit | 85801579e10208b7466f4a7f8329b4f5d2056fff |
| Delegated to: | Stefano Babic |
| Headers | show |
On Wed, Jun 15, 2016 at 3:18 AM, Peng Fan <van.freenix@gmail.com> wrote: > Fix 74LV OE gpio index. gpio index is wrong, > so gpio output will not have effect, since we > use wrong GPIO5_IO18, but not correct GPIO5_IO8. > > And at the end of the initialization of 74lv init, should > keep OE voltage level at LOW to make 74lv output the correct > voltage. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c index 88d3fbd..b861122 100644 --- a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +++ b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c @@ -66,7 +66,7 @@ DECLARE_GLOBAL_DATA_PTR; #define IOX_SDI IMX_GPIO_NR(5, 10) #define IOX_STCP IMX_GPIO_NR(5, 7) #define IOX_SHCP IMX_GPIO_NR(5, 11) -#define IOX_OE IMX_GPIO_NR(5, 18) +#define IOX_OE IMX_GPIO_NR(5, 8) static iomux_v3_cfg_t const iox_pads[] = { /* IOX_SDI */ @@ -154,8 +154,6 @@ static void iox74lv_init(void) * shift register will be output to pins */ gpio_direction_output(IOX_STCP, 1); - - gpio_direction_output(IOX_OE, 1); }; #ifdef CONFIG_SYS_I2C_MXC
Fix 74LV OE gpio index. gpio index is wrong, so gpio output will not have effect, since we use wrong GPIO5_IO18, but not correct GPIO5_IO8. And at the end of the initialization of 74lv init, should keep OE voltage level at LOW to make 74lv output the correct voltage. Signed-off-by: Peng Fan <peng.fan@nxp.com> Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> --- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)