diff mbox

[02/12] reproducibility: override locale and timezone

Message ID 1465918277-30675-2-git-send-email-gilles.chanteperdrix@xenomai.org
State Accepted
Commit a5f3513b220015bceed2de231e90fe6e4b4431b5
Headers show

Commit Message

Gilles Chanteperdrix June 14, 2016, 3:31 p.m. UTC 
Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
---
 Makefile | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Yann E. MORIN July 2, 2016, 9:01 a.m. UTC | #1 
Gilles, All,

On 2016-06-14 17:31 +0200, Gilles Chanteperdrix spake thusly:
> Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  Makefile | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 3f5c3d3..0217ff0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -208,6 +208,13 @@ ifeq ($(filter $(noconfig_targets),$(MAKECMDGOALS)),)
>  -include $(BR2_CONFIG)
>  endif
>  
> +export BR2_REPRODUCIBLE
> +ifeq ($(BR2_REPRODUCIBLE),y)
> +export TZ=UTC
> +export LANG=C
> +export LC_ALL=C
> +endif
> +
>  # To put more focus on warnings, be less verbose as default
>  # Use 'make V=1' to see the full commands
>  ifeq ("$(origin V)", "command line")
> -- 
> 2.8.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard July 2, 2016, 9:58 a.m. UTC | #2 
>>>>> "Gilles" == Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> writes:

 > Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
 > ---
 >  Makefile | 7 +++++++
 >  1 file changed, 7 insertions(+)

 > diff --git a/Makefile b/Makefile
 > index 3f5c3d3..0217ff0 100644
 > --- a/Makefile
 > +++ b/Makefile
 > @@ -208,6 +208,13 @@ ifeq ($(filter $(noconfig_targets),$(MAKECMDGOALS)),)
 >  -include $(BR2_CONFIG)
 >  endif
 
 > +export BR2_REPRODUCIBLE

I moved this down with the other exports we do for post-build /
post-image scripts.

 > +ifeq ($(BR2_REPRODUCIBLE),y)

And added a comment why we do this.

Committed with that fixed, thanks.

 > +export TZ=UTC
 > +export LANG=C
 > +export LC_ALL=C
 > +endif
 > +
 >  # To put more focus on warnings, be less verbose as default
 >  # Use 'make V=1' to see the full commands
 >  ifeq ("$(origin V)", "command line")
 > -- 
 > 2.8.2

 > _______________________________________________
 > buildroot mailing list
 > buildroot@busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 3f5c3d3..0217ff0 100644
--- a/Makefile
+++ b/Makefile
@@ -208,6 +208,13 @@  ifeq ($(filter $(noconfig_targets),$(MAKECMDGOALS)),)
 -include $(BR2_CONFIG)
 endif
 
+export BR2_REPRODUCIBLE
+ifeq ($(BR2_REPRODUCIBLE),y)
+export TZ=UTC
+export LANG=C
+export LC_ALL=C
+endif
+
 # To put more focus on warnings, be less verbose as default
 # Use 'make V=1' to see the full commands
 ifeq ("$(origin V)", "command line")