diff mbox

[U-Boot] dm: scsi: if_typename should be scsi

Message ID 1464786684-4685-1-git-send-email-Ed.Swarthout@nxp.com
State Accepted
Commit 69c125fe7b7dd057ed3e9013e6786b9f374cf8cd
Delegated to: Tom Rini
Headers show

Commit Message

Ed Swarthout June 1, 2016, 1:11 p.m. UTC 
Fixes:

=> ext2ls scsi 0:1
** Bad device scsi 0:1 **

for boards which use the scsi legacy driver (such as ls1043ardb).

Signed-off-by: Ed Swarthout <Ed.Swarthout@nxp.com>
---
This looks like a typeo from 11f610edf01abc96ca10e82e1752648ee911705b

 common/scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

George McCollister June 2, 2016, 8:41 p.m. UTC | #1 
I was having this problem on the Minnowboard Max with the defconfig
and this fixes it.

Tested-by: George McCollister <george.mccollister@gmail.com>

Thanks,
George

On Wed, Jun 1, 2016 at 8:11 AM, Ed Swarthout <Ed.Swarthout@nxp.com> wrote:
> Fixes:
>
> => ext2ls scsi 0:1
> ** Bad device scsi 0:1 **
>
> for boards which use the scsi legacy driver (such as ls1043ardb).
>
> Signed-off-by: Ed Swarthout <Ed.Swarthout@nxp.com>
> ---
> This looks like a typeo from 11f610edf01abc96ca10e82e1752648ee911705b
>
>  common/scsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/scsi.c b/common/scsi.c
> index 8ac28dd..dbbf404 100644
> --- a/common/scsi.c
> +++ b/common/scsi.c
> @@ -584,7 +584,7 @@ U_BOOT_DRIVER(scsi_blk) = {
>  };
>  #else
>  U_BOOT_LEGACY_BLK(scsi) = {
> -       .if_typename    = "sata",
> +       .if_typename    = "scsi",
>         .if_type        = IF_TYPE_SCSI,
>         .max_devs       = CONFIG_SYS_SCSI_MAX_DEVICE,
>         .desc           = scsi_dev_desc,
> --
> 2.5.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Simon Glass June 2, 2016, 9:06 p.m. UTC | #2 
On 2 June 2016 at 01:11, Ed Swarthout <Ed.Swarthout@nxp.com> wrote:
> Fixes:
>
> => ext2ls scsi 0:1
> ** Bad device scsi 0:1 **
>
> for boards which use the scsi legacy driver (such as ls1043ardb).
>
> Signed-off-by: Ed Swarthout <Ed.Swarthout@nxp.com>
> ---
> This looks like a typeo from 11f610edf01abc96ca10e82e1752648ee911705b
>
>  common/scsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thank you!

Acked-by: Simon Glass <sjg@chromium.org>
Tom Rini June 6, 2016, 9:28 p.m. UTC | #3 
On Wed, Jun 01, 2016 at 08:11:24AM -0500, Ed Swarthout wrote:

> Fixes:
> 
> => ext2ls scsi 0:1
> ** Bad device scsi 0:1 **
> 
> for boards which use the scsi legacy driver (such as ls1043ardb).
> 
> Signed-off-by: Ed Swarthout <Ed.Swarthout@nxp.com>
> Tested-by: George McCollister <george.mccollister@gmail.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/scsi.c b/common/scsi.c
index 8ac28dd..dbbf404 100644
--- a/common/scsi.c
+++ b/common/scsi.c
@@ -584,7 +584,7 @@  U_BOOT_DRIVER(scsi_blk) = {
 };
 #else
 U_BOOT_LEGACY_BLK(scsi) = {
-	.if_typename	= "sata",
+	.if_typename	= "scsi",
 	.if_type	= IF_TYPE_SCSI,
 	.max_devs	= CONFIG_SYS_SCSI_MAX_DEVICE,
 	.desc		= scsi_dev_desc,