diff mbox

[U-Boot,v2,5/8] board: ge: bx50v3: make network support optional and disabled by default

Message ID 2d55c43646ff4a655d1bbd8668d6ef9988ebbe07.1464608199.git.andrew.shadura@collabora.co.uk
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Andrej Shadura May 30, 2016, 11:37 a.m. UTC
The network support is only useful for development and shouldn't be enabled
in production, so it has to be disabled in U-boot by default.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
---
 configs/ge_b450v3_defconfig | 4 +---
 configs/ge_b650v3_defconfig | 4 +---
 configs/ge_b850v3_defconfig | 4 +---
 include/configs/ge_bx50v3.h | 2 ++
 4 files changed, 5 insertions(+), 9 deletions(-)

Comments

Martin Donnelly May 30, 2016, 12:11 p.m. UTC | #1
On Mon, May 30, 2016 at 01:37:05PM +0200, Andrew Shadura wrote:
> The network support is only useful for development and shouldn't be enabled
> in production, so it has to be disabled in U-boot by default.
> 
> Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>

Acked-by: Martin Donnelly <martin.donnelly@ge.com>

> ---
>  configs/ge_b450v3_defconfig | 4 +---
>  configs/ge_b650v3_defconfig | 4 +---
>  configs/ge_b850v3_defconfig | 4 +---
>  include/configs/ge_bx50v3.h | 2 ++
>  4 files changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/configs/ge_b450v3_defconfig b/configs/ge_b450v3_defconfig
> index 98bf52e..a8628d2 100644
> --- a/configs/ge_b450v3_defconfig
> +++ b/configs/ge_b450v3_defconfig
> @@ -9,9 +9,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_I2C=y
>  CONFIG_CMD_GPIO=y
> -CONFIG_CMD_DHCP=y
> -CONFIG_CMD_MII=y
> -CONFIG_CMD_PING=y
> +CONFIG_CMD_NET=n
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_EXT2=y
>  CONFIG_CMD_EXT4=y
> diff --git a/configs/ge_b650v3_defconfig b/configs/ge_b650v3_defconfig
> index b66c98b..ce39521 100644
> --- a/configs/ge_b650v3_defconfig
> +++ b/configs/ge_b650v3_defconfig
> @@ -9,9 +9,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_I2C=y
>  CONFIG_CMD_GPIO=y
> -CONFIG_CMD_DHCP=y
> -CONFIG_CMD_MII=y
> -CONFIG_CMD_PING=y
> +CONFIG_CMD_NET=n
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_EXT2=y
>  CONFIG_CMD_EXT4=y
> diff --git a/configs/ge_b850v3_defconfig b/configs/ge_b850v3_defconfig
> index 1cd126a..d2f6f86 100644
> --- a/configs/ge_b850v3_defconfig
> +++ b/configs/ge_b850v3_defconfig
> @@ -9,9 +9,7 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_SF=y
>  CONFIG_CMD_I2C=y
>  CONFIG_CMD_GPIO=y
> -CONFIG_CMD_DHCP=y
> -CONFIG_CMD_MII=y
> -CONFIG_CMD_PING=y
> +CONFIG_CMD_NET=n
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_EXT2=y
>  CONFIG_CMD_EXT4=y
> diff --git a/include/configs/ge_bx50v3.h b/include/configs/ge_bx50v3.h
> index 602763f..ccaa2b4 100644
> --- a/include/configs/ge_bx50v3.h
> +++ b/include/configs/ge_bx50v3.h
> @@ -103,6 +103,7 @@
>  #endif
>  
>  /* Networking Configs */
> +#ifdef CONFIG_NET
>  #define CONFIG_FEC_MXC
>  #define CONFIG_MII
>  #define IMX_FEC_BASE			ENET_BASE_ADDR
> @@ -111,6 +112,7 @@
>  #define CONFIG_FEC_MXC_PHYADDR		4
>  #define CONFIG_PHYLIB
>  #define CONFIG_PHY_ATHEROS
> +#endif
>  
>  /* Serial Flash */
>  #ifdef CONFIG_CMD_SF
> -- 
> 2.7.4
>
diff mbox

Patch

diff --git a/configs/ge_b450v3_defconfig b/configs/ge_b450v3_defconfig
index 98bf52e..a8628d2 100644
--- a/configs/ge_b450v3_defconfig
+++ b/configs/ge_b450v3_defconfig
@@ -9,9 +9,7 @@  CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_GPIO=y
-CONFIG_CMD_DHCP=y
-CONFIG_CMD_MII=y
-CONFIG_CMD_PING=y
+CONFIG_CMD_NET=n
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
diff --git a/configs/ge_b650v3_defconfig b/configs/ge_b650v3_defconfig
index b66c98b..ce39521 100644
--- a/configs/ge_b650v3_defconfig
+++ b/configs/ge_b650v3_defconfig
@@ -9,9 +9,7 @@  CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_GPIO=y
-CONFIG_CMD_DHCP=y
-CONFIG_CMD_MII=y
-CONFIG_CMD_PING=y
+CONFIG_CMD_NET=n
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
diff --git a/configs/ge_b850v3_defconfig b/configs/ge_b850v3_defconfig
index 1cd126a..d2f6f86 100644
--- a/configs/ge_b850v3_defconfig
+++ b/configs/ge_b850v3_defconfig
@@ -9,9 +9,7 @@  CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_GPIO=y
-CONFIG_CMD_DHCP=y
-CONFIG_CMD_MII=y
-CONFIG_CMD_PING=y
+CONFIG_CMD_NET=n
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
diff --git a/include/configs/ge_bx50v3.h b/include/configs/ge_bx50v3.h
index 602763f..ccaa2b4 100644
--- a/include/configs/ge_bx50v3.h
+++ b/include/configs/ge_bx50v3.h
@@ -103,6 +103,7 @@ 
 #endif
 
 /* Networking Configs */
+#ifdef CONFIG_NET
 #define CONFIG_FEC_MXC
 #define CONFIG_MII
 #define IMX_FEC_BASE			ENET_BASE_ADDR
@@ -111,6 +112,7 @@ 
 #define CONFIG_FEC_MXC_PHYADDR		4
 #define CONFIG_PHYLIB
 #define CONFIG_PHY_ATHEROS
+#endif
 
 /* Serial Flash */
 #ifdef CONFIG_CMD_SF