| Message ID | 1464279868-17764-1-git-send-email-andrea.merello@gmail.com |
|---|---|
| State | Accepted |
| Commit | 2ec4d10 |
| Delegated to: | Joe Hershberger |
| Headers | show |
On 05/26/2016 06:24 PM, Andrea Merello wrote: > This adds support for internal delay on RX and TX on RGMII interface for the > AR8035 phy. > > This is basically the same Linux driver do. Tested on a Zynq Zturn board (for > which u-boot support in is my tree; first patch waiting ML approval) > > Signed-off-by: Andrea Merello <andrea.merello@gmail.com> Reviewed-by: Marek Vasut <marex@denx.de> Acked-by: Marek Vasut <marex@denx.de> Can we get this applied ? Thanks > > diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c > index e57c412..694a338 100644 > --- a/drivers/net/phy/atheros.c > +++ b/drivers/net/phy/atheros.c > @@ -31,6 +31,22 @@ static int ar8035_config(struct phy_device *phydev) > regval = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e); > phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, (regval|0x0100)); > > + if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) || > + (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)) { > + /* select debug reg 5 */ > + phy_write(phydev, MDIO_DEVAD_NONE, 0x1D, 0x5); > + /* enable tx delay */ > + phy_write(phydev, MDIO_DEVAD_NONE, 0x1E, 0x0100); > + } > + > + if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) || > + (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)) { > + /* select debug reg 0 */ > + phy_write(phydev, MDIO_DEVAD_NONE, 0x1D, 0x0); > + /* enable rx delay */ > + phy_write(phydev, MDIO_DEVAD_NONE, 0x1E, 0x8000); > + } > + > phydev->supported = phydev->drv->features; > > genphy_config_aneg(phydev); > -- > 2.1.4 > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
On Thu, May 26, 2016 at 11:24 AM, Andrea Merello <andrea.merello@gmail.com> wrote: > This adds support for internal delay on RX and TX on RGMII interface for the > AR8035 phy. > > This is basically the same Linux driver do. Tested on a Zynq Zturn board (for > which u-boot support in is my tree; first patch waiting ML approval) > > Signed-off-by: Andrea Merello <andrea.merello@gmail.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
On Tue, Sep 27, 2016 at 7:59 AM, Marek Vasut <marex@denx.de> wrote: > On 05/26/2016 06:24 PM, Andrea Merello wrote: >> This adds support for internal delay on RX and TX on RGMII interface for the >> AR8035 phy. >> >> This is basically the same Linux driver do. Tested on a Zynq Zturn board (for >> which u-boot support in is my tree; first patch waiting ML approval) >> >> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> > > Reviewed-by: Marek Vasut <marex@denx.de> > Acked-by: Marek Vasut <marex@denx.de> > > Can we get this applied ? Thanks This is assigned to Michal in patchwork, so at least someone thinks that's the correct path. I'm good either way. -Joe
On 09/28/2016 08:55 PM, Joe Hershberger wrote: > On Tue, Sep 27, 2016 at 7:59 AM, Marek Vasut <marex@denx.de> wrote: >> On 05/26/2016 06:24 PM, Andrea Merello wrote: >>> This adds support for internal delay on RX and TX on RGMII interface for the >>> AR8035 phy. >>> >>> This is basically the same Linux driver do. Tested on a Zynq Zturn board (for >>> which u-boot support in is my tree; first patch waiting ML approval) >>> >>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> >> >> Reviewed-by: Marek Vasut <marex@denx.de> >> Acked-by: Marek Vasut <marex@denx.de> >> >> Can we get this applied ? Thanks > > This is assigned to Michal in patchwork, so at least someone thinks > that's the correct path. I'm good either way. Well that doesn't make any sense, so please pick it.
On Wed, Sep 28, 2016 at 2:01 PM, Marek Vasut <marex@denx.de> wrote: > On 09/28/2016 08:55 PM, Joe Hershberger wrote: >> On Tue, Sep 27, 2016 at 7:59 AM, Marek Vasut <marex@denx.de> wrote: >>> On 05/26/2016 06:24 PM, Andrea Merello wrote: >>>> This adds support for internal delay on RX and TX on RGMII interface for the >>>> AR8035 phy. >>>> >>>> This is basically the same Linux driver do. Tested on a Zynq Zturn board (for >>>> which u-boot support in is my tree; first patch waiting ML approval) >>>> >>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> >>> >>> Reviewed-by: Marek Vasut <marex@denx.de> >>> Acked-by: Marek Vasut <marex@denx.de> >>> >>> Can we get this applied ? Thanks >> >> This is assigned to Michal in patchwork, so at least someone thinks >> that's the correct path. I'm good either way. > > Well that doesn't make any sense, so please pick it. Probably was done because it mentions it's for a Zynq board. Sure would be nice if patchwork listed a history of who changed what fields. -Joe
On 09/28/2016 09:04 PM, Joe Hershberger wrote: > On Wed, Sep 28, 2016 at 2:01 PM, Marek Vasut <marex@denx.de> wrote: >> On 09/28/2016 08:55 PM, Joe Hershberger wrote: >>> On Tue, Sep 27, 2016 at 7:59 AM, Marek Vasut <marex@denx.de> wrote: >>>> On 05/26/2016 06:24 PM, Andrea Merello wrote: >>>>> This adds support for internal delay on RX and TX on RGMII interface for the >>>>> AR8035 phy. >>>>> >>>>> This is basically the same Linux driver do. Tested on a Zynq Zturn board (for >>>>> which u-boot support in is my tree; first patch waiting ML approval) >>>>> >>>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> >>>> >>>> Reviewed-by: Marek Vasut <marex@denx.de> >>>> Acked-by: Marek Vasut <marex@denx.de> >>>> >>>> Can we get this applied ? Thanks >>> >>> This is assigned to Michal in patchwork, so at least someone thinks >>> that's the correct path. I'm good either way. >> >> Well that doesn't make any sense, so please pick it. > > Probably was done because it mentions it's for a Zynq board. Sure > would be nice if patchwork listed a history of who changed what > fields. I would rather avoid fingerpointing, but probably Tom, he's the one doing the hard work of reassigning patches and is alone at it I think. Thus, accidents can happen.
On Wed, Sep 28, 2016 at 2:10 PM, Marek Vasut <marex@denx.de> wrote: > On 09/28/2016 09:04 PM, Joe Hershberger wrote: >> On Wed, Sep 28, 2016 at 2:01 PM, Marek Vasut <marex@denx.de> wrote: >>> On 09/28/2016 08:55 PM, Joe Hershberger wrote: >>>> On Tue, Sep 27, 2016 at 7:59 AM, Marek Vasut <marex@denx.de> wrote: >>>>> On 05/26/2016 06:24 PM, Andrea Merello wrote: >>>>>> This adds support for internal delay on RX and TX on RGMII interface for the >>>>>> AR8035 phy. >>>>>> >>>>>> This is basically the same Linux driver do. Tested on a Zynq Zturn board (for >>>>>> which u-boot support in is my tree; first patch waiting ML approval) >>>>>> >>>>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> >>>>> >>>>> Reviewed-by: Marek Vasut <marex@denx.de> >>>>> Acked-by: Marek Vasut <marex@denx.de> >>>>> >>>>> Can we get this applied ? Thanks >>>> >>>> This is assigned to Michal in patchwork, so at least someone thinks >>>> that's the correct path. I'm good either way. >>> >>> Well that doesn't make any sense, so please pick it. >> >> Probably was done because it mentions it's for a Zynq board. Sure >> would be nice if patchwork listed a history of who changed what >> fields. > > I would rather avoid fingerpointing, but probably Tom, he's the one > doing the hard work of reassigning patches and is alone at it I think. > Thus, accidents can happen. I also assign some, mostly unassigned and pertaining to me. I certainly try to not take patches assigned to others when there's any doubt in case they are in progress. I'm not interested in finger-pointing so much as knowing who to ask about the assignment. -Joe
On 28.9.2016 12:13, Joe Hershberger wrote: > On Wed, Sep 28, 2016 at 2:10 PM, Marek Vasut <marex@denx.de> wrote: >> On 09/28/2016 09:04 PM, Joe Hershberger wrote: >>> On Wed, Sep 28, 2016 at 2:01 PM, Marek Vasut <marex@denx.de> wrote: >>>> On 09/28/2016 08:55 PM, Joe Hershberger wrote: >>>>> On Tue, Sep 27, 2016 at 7:59 AM, Marek Vasut <marex@denx.de> wrote: >>>>>> On 05/26/2016 06:24 PM, Andrea Merello wrote: >>>>>>> This adds support for internal delay on RX and TX on RGMII interface for the >>>>>>> AR8035 phy. >>>>>>> >>>>>>> This is basically the same Linux driver do. Tested on a Zynq Zturn board (for >>>>>>> which u-boot support in is my tree; first patch waiting ML approval) >>>>>>> >>>>>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com> >>>>>> >>>>>> Reviewed-by: Marek Vasut <marex@denx.de> >>>>>> Acked-by: Marek Vasut <marex@denx.de> >>>>>> >>>>>> Can we get this applied ? Thanks >>>>> >>>>> This is assigned to Michal in patchwork, so at least someone thinks >>>>> that's the correct path. I'm good either way. >>>> >>>> Well that doesn't make any sense, so please pick it. >>> >>> Probably was done because it mentions it's for a Zynq board. Sure >>> would be nice if patchwork listed a history of who changed what >>> fields. >> >> I would rather avoid fingerpointing, but probably Tom, he's the one >> doing the hard work of reassigning patches and is alone at it I think. >> Thus, accidents can happen. > > I also assign some, mostly unassigned and pertaining to me. I > certainly try to not take patches assigned to others when there's any > doubt in case they are in progress. I'm not interested in > finger-pointing so much as knowing who to ask about the assignment. Joe: :-) Definitely take it via your tree. Thanks, Michal
Hi Andrea, https://patchwork.ozlabs.org/patch/626776/ was applied to u-boot-net.git. Thanks! -Joe
diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index e57c412..694a338 100644 --- a/drivers/net/phy/atheros.c +++ b/drivers/net/phy/atheros.c @@ -31,6 +31,22 @@ static int ar8035_config(struct phy_device *phydev) regval = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e); phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, (regval|0x0100)); + if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) || + (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)) { + /* select debug reg 5 */ + phy_write(phydev, MDIO_DEVAD_NONE, 0x1D, 0x5); + /* enable tx delay */ + phy_write(phydev, MDIO_DEVAD_NONE, 0x1E, 0x0100); + } + + if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) || + (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)) { + /* select debug reg 0 */ + phy_write(phydev, MDIO_DEVAD_NONE, 0x1D, 0x0); + /* enable rx delay */ + phy_write(phydev, MDIO_DEVAD_NONE, 0x1E, 0x8000); + } + phydev->supported = phydev->drv->features; genphy_config_aneg(phydev);
This adds support for internal delay on RX and TX on RGMII interface for the AR8035 phy. This is basically the same Linux driver do. Tested on a Zynq Zturn board (for which u-boot support in is my tree; first patch waiting ML approval) Signed-off-by: Andrea Merello <andrea.merello@gmail.com> -- 2.1.4