diff mbox

[U-Boot,v2,4/7] ARM: dts: am335x: fix cd-gpios definition as per hardware design and dt binding docs

Message ID 1463378070-2900-5-git-send-email-lokeshvutla@ti.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Lokesh Vutla May 16, 2016, 5:54 a.m. UTC 
From: Mugunthan V N <mugunthanvnm@ti.com>

As per mmc device tree binding documentation card detect gpio has
to be active low signal. When a hardware is designed with active
high card detect, gpio polarity has to be changed with
cd-inverted dt property.

In AM335x the card detect gpio is designed as active low gpio.
So correcting the dt card detect gpio definition.

Reviewed-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
---
Changes since v1:
- None

 arch/arm/dts/am335x-bone-common.dtsi | 3 +--
 arch/arm/dts/am335x-evm.dts          | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Tom Rini May 30, 2016, 6:04 p.m. UTC | #1 
On Mon, May 16, 2016 at 11:24:27AM +0530, Lokesh Vutla wrote:

> From: Mugunthan V N <mugunthanvnm@ti.com>
> 
> As per mmc device tree binding documentation card detect gpio has
> to be active low signal. When a hardware is designed with active
> high card detect, gpio polarity has to be changed with
> cd-inverted dt property.
> 
> In AM335x the card detect gpio is designed as active low gpio.
> So correcting the dt card detect gpio definition.
> 
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/arch/arm/dts/am335x-bone-common.dtsi b/arch/arm/dts/am335x-bone-common.dtsi
index a00c0cd..40a3c35 100644
--- a/arch/arm/dts/am335x-bone-common.dtsi
+++ b/arch/arm/dts/am335x-bone-common.dtsi
@@ -388,8 +388,7 @@ 
 	bus-width = <0x4>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc1_pins>;
-	cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
-	cd-inverted;
+	cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
 };
 
 &aes {
diff --git a/arch/arm/dts/am335x-evm.dts b/arch/arm/dts/am335x-evm.dts
index c0bc2af..a6f20af 100644
--- a/arch/arm/dts/am335x-evm.dts
+++ b/arch/arm/dts/am335x-evm.dts
@@ -717,7 +717,7 @@ 
 	bus-width = <4>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc1_pins>;
-	cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
+	cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
 };
 
 &mmc3 {