diff mbox

[U-Boot,3/4] ARM: tegra: convert CONFIG_TEGRA_GPIO to Kconfig

Message ID 1463076462-10616-3-git-send-email-swarren@wwwdotorg.org
State Accepted
Commit 601800be22a37cc518e023adc8e32ad15f00a2c6
Delegated to: Tom Warren
Headers show

Commit Message

Stephen Warren May 12, 2016, 6:07 p.m. UTC
From: Stephen Warren <swarren@nvidia.com>

Future chips will contain different GPIO HW. This change will enable
future SoC support to select the appropriate GPIO driver for their HW,
in a future-looking fashion, using Kconfig.

TEGRA_GPIO is not simply selected by TEGRA_COMMON (even though all
current Tegra chips used this GPIO HW) to simplify the later addition
of support for Tegra SoCs that use different GPIO HW.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
v2: New patch.
---
 arch/arm/mach-tegra/Kconfig    | 2 ++
 drivers/gpio/Kconfig           | 7 +++++++
 include/configs/tegra-common.h | 1 -
 3 files changed, 9 insertions(+), 1 deletion(-)

Comments

Simon Glass May 19, 2016, 4:02 a.m. UTC | #1
On 12 May 2016 at 12:07, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Future chips will contain different GPIO HW. This change will enable
> future SoC support to select the appropriate GPIO driver for their HW,
> in a future-looking fashion, using Kconfig.
>
> TEGRA_GPIO is not simply selected by TEGRA_COMMON (even though all
> current Tegra chips used this GPIO HW) to simplify the later addition
> of support for Tegra SoCs that use different GPIO HW.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> v2: New patch.
> ---
>  arch/arm/mach-tegra/Kconfig    | 2 ++
>  drivers/gpio/Kconfig           | 7 +++++++
>  include/configs/tegra-common.h | 1 -
>  3 files changed, 9 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index ba6983f3dfd3..616a1c3cf345 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -22,6 +22,7 @@  config TEGRA_ARMV7_COMMON
 	select SPL
 	select SUPPORT_SPL
 	select TEGRA_COMMON
+	select TEGRA_GPIO
 
 config TEGRA_ARMV8_COMMON
 	bool "Tegra 64-bit common options"
@@ -50,6 +51,7 @@  config TEGRA124
 
 config TEGRA210
 	bool "Tegra210 family"
+	select TEGRA_GPIO
 	select TEGRA_ARMV8_COMMON
 
 endchoice
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 2b4624d7f807..b3e086fa3584 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -109,6 +109,13 @@  config SANDBOX_GPIO_COUNT
 	  of 'anonymous' GPIOs that do not belong to any device or bank.
 	  Select a suitable value depending on your needs.
 
+config TEGRA_GPIO
+	bool "Tegra20..210 GPIO driver"
+	depends on DM_GPIO
+	help
+	  Support for the GPIO controller contained in NVIDIA Tegra20 through
+	  Tegra210.
+
 config GPIO_UNIPHIER
 	bool "UniPhier GPIO"
 	depends on ARCH_UNIPHIER
diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h
index 92d4dd8e5196..7b0940a7f20c 100644
--- a/include/configs/tegra-common.h
+++ b/include/configs/tegra-common.h
@@ -111,7 +111,6 @@ 
 						CONFIG_SYS_INIT_RAM_SIZE - \
 						GENERATED_GBL_DATA_SIZE)
 
-#define CONFIG_TEGRA_GPIO
 #define CONFIG_CMD_ENTERRCM
 
 /* Defines for SPL */