diff mbox

[U-Boot,RFC] spl: Setup default value for OF_LIST

Message ID 2b567642e4895ae14ac256aa2329725395ee5c90.1462367649.git.michal.simek@xilinx.com
State Accepted
Commit c409bd015c295ba088af75b117d1dd6ebd8080ba
Delegated to: Tom Rini
Headers show

Commit Message

Michal Simek May 4, 2016, 1:14 p.m. UTC
OF_LIST can't remain empty that's why setup it up to default DTB.

If it is empty u-boot.img is created without FDT partition:
For example:
  ./tools/mkimage -f auto -A arm -T firmware -C none -O u-boot -a
0x8000000 -e 0 -n "U-Boot 2016.05-rc3 ..." -E -b  -d u-boot-nodtb.bin u-boot.img
Can't set 'timestamp' property for '' node (FDT_ERR_NOSPACE)
FIT description: Firmware image with one or more FDT blobs
Created:         Wed May  4 15:02:52 2016
 Image 0 (firmware@1)
  Description:  U-Boot 2016.05-rc3-00080-gff2e12ae22a8-dirty for zynqmp
board
  Created:      Wed May  4 15:02:52 2016
  Type:         Firmware
  Compression:  uncompressed
  Data Size:    unavailable
  Architecture: ARM
  Load Address: 0x08000000
 Default Configuration: 'conf@1'
 Configuration 0 (conf@1)
  Description:  unavailable
  Kernel:       unavailable

And then image like this doesn't contain description and link to FDT and
can't boot.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 dts/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini May 6, 2016, 5:48 p.m. UTC | #1
On Wed, May 04, 2016 at 03:14:11PM +0200, Michal Simek wrote:

> OF_LIST can't remain empty that's why setup it up to default DTB.
> 
> If it is empty u-boot.img is created without FDT partition:
> For example:
>   ./tools/mkimage -f auto -A arm -T firmware -C none -O u-boot -a
> 0x8000000 -e 0 -n "U-Boot 2016.05-rc3 ..." -E -b  -d u-boot-nodtb.bin u-boot.img
> Can't set 'timestamp' property for '' node (FDT_ERR_NOSPACE)
> FIT description: Firmware image with one or more FDT blobs
> Created:         Wed May  4 15:02:52 2016
>  Image 0 (firmware@1)
>   Description:  U-Boot 2016.05-rc3-00080-gff2e12ae22a8-dirty for zynqmp
> board
>   Created:      Wed May  4 15:02:52 2016
>   Type:         Firmware
>   Compression:  uncompressed
>   Data Size:    unavailable
>   Architecture: ARM
>   Load Address: 0x08000000
>  Default Configuration: 'conf@1'
>  Configuration 0 (conf@1)
>   Description:  unavailable
>   Kernel:       unavailable
> 
> And then image like this doesn't contain description and link to FDT and
> can't boot.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini May 23, 2016, 10:14 p.m. UTC | #2
On Wed, May 04, 2016 at 03:14:11PM +0200, Michal Simek wrote:

> OF_LIST can't remain empty that's why setup it up to default DTB.
> 
> If it is empty u-boot.img is created without FDT partition:
> For example:
>   ./tools/mkimage -f auto -A arm -T firmware -C none -O u-boot -a
> 0x8000000 -e 0 -n "U-Boot 2016.05-rc3 ..." -E -b  -d u-boot-nodtb.bin u-boot.img
> Can't set 'timestamp' property for '' node (FDT_ERR_NOSPACE)
> FIT description: Firmware image with one or more FDT blobs
> Created:         Wed May  4 15:02:52 2016
>  Image 0 (firmware@1)
>   Description:  U-Boot 2016.05-rc3-00080-gff2e12ae22a8-dirty for zynqmp
> board
>   Created:      Wed May  4 15:02:52 2016
>   Type:         Firmware
>   Compression:  uncompressed
>   Data Size:    unavailable
>   Architecture: ARM
>   Load Address: 0x08000000
>  Default Configuration: 'conf@1'
>  Configuration 0 (conf@1)
>   Description:  unavailable
>   Kernel:       unavailable
> 
> And then image like this doesn't contain description and link to FDT and
> can't boot.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/dts/Kconfig b/dts/Kconfig
index d5850093539d..c56c1299c09f 100644
--- a/dts/Kconfig
+++ b/dts/Kconfig
@@ -62,6 +62,7 @@  config DEFAULT_DEVICE_TREE
 config OF_LIST
 	string "List of device tree files to include for DT control"
 	depends on SPL_LOAD_FIT
+	default DEFAULT_DEVICE_TREE
 	help
 	  This option specifies a list of device tree files to use for DT
 	  control. These will be packaged into a FIT. At run-time, SPL will