| Message ID | 1462124192-8748-6-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 709e98b7b2461c2535d4ac2bb0311c3b3f53dbbb |
| Delegated to: | Simon Glass |
| Headers | show |
On 1 May 2016 at 11:35, Simon Glass <sjg@chromium.org> wrote: > If an address is used with readb() and writeb() which is smaller than the > expected size (e.g. 32-bit value on a machine with 64-bit addresses), a > warning results. Fix this by adding a cast. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: > - Tweak the cast > > include/iotrace.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Applied to u-boot-dm.
diff --git a/include/iotrace.h b/include/iotrace.h index 9bd1f16..e4ceb61 100644 --- a/include/iotrace.h +++ b/include/iotrace.h @@ -31,10 +31,11 @@ #define writew(val, addr) iotrace_writew(val, (const void *)(addr)) #undef readb -#define readb(addr) iotrace_readb((const void *)(addr)) +#define readb(addr) iotrace_readb((const void *)(uintptr_t)addr) #undef writeb -#define writeb(val, addr) iotrace_writeb(val, (const void *)(addr)) +#define writeb(val, addr) \ + iotrace_writeb(val, (const void *)(uintptr_t)addr) #endif
If an address is used with readb() and writeb() which is smaller than the expected size (e.g. 32-bit value on a machine with 64-bit addresses), a warning results. Fix this by adding a cast. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: - Tweak the cast include/iotrace.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)