| Message ID | 1461242884-5282-1-git-send-email-hs@denx.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
On 04/21/2016 02:48 PM, Heiko Schocher wrote: > suppress a lot of > "reg or ranges property, but no unit name" warnings, > through the dtc compiler flag "-Wno-unit_address_vs_reg". > > If all DTS are fixed, we can remove this flag again. > > Signed-off-by: Heiko Schocher <hs@denx.de> > --- > There is also a solution to suppress warnings from > the dtc compiler by the "-q" flag, but that would > suppress all warnings. Not realy what I want. Yep > With this patch and patch: > http://patchwork.ozlabs.org/patch/609150/ > > travis build passes, see: > https://travis-ci.org/hsdenx/u-boot/builds/124723016 > > > arch/arc/dts/Makefile | 2 ++ > arch/arm/dts/Makefile | 3 ++- > arch/microblaze/dts/Makefile | 2 ++ > arch/mips/dts/Makefile | 3 ++- > arch/nios2/dts/Makefile | 2 ++ > arch/powerpc/dts/Makefile | 2 ++ > arch/sandbox/dts/Makefile | 2 ++ > arch/x86/dts/Makefile | 2 ++ > 8 files changed, 16 insertions(+), 2 deletions(-) Isn't there some common place in scripts/ or so where we can disable this warning using an one-liner ? > diff --git a/arch/arc/dts/Makefile b/arch/arc/dts/Makefile > index d4772ec..de8a1e1 100644 > --- a/arch/arc/dts/Makefile > +++ b/arch/arc/dts/Makefile > @@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_TB100) += abilis_tb100.dtb > targets += $(dtb-y) > > DTC_FLAGS += -R 4 -p 0x1000 > +# Disable noisy checks by default > +DTC_FLAGS += -Wno-unit_address_vs_reg > > PHONY += dtbs > dtbs: $(addprefix $(obj)/, $(dtb-y)) > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index aa31fd9..e2da4c6 100644 > --- a/arch/arm/dts/Makefile > +++ b/arch/arm/dts/Makefile > @@ -234,7 +234,8 @@ dtb-$(CONFIG_SOC_KEYSTONE) += k2hk-evm.dtb \ > targets += $(dtb-y) > > # Add any required device tree compiler flags here > -DTC_FLAGS += > +# Disable noisy checks by default > +DTC_FLAGS += -Wno-unit_address_vs_reg > > PHONY += dtbs > dtbs: $(addprefix $(obj)/, $(dtb-y)) > diff --git a/arch/microblaze/dts/Makefile b/arch/microblaze/dts/Makefile > index 5e70d9e..0ccd3ee 100644 > --- a/arch/microblaze/dts/Makefile > +++ b/arch/microblaze/dts/Makefile > @@ -7,6 +7,8 @@ dtb-y += microblaze-generic.dtb > targets += $(dtb-y) > > DTC_FLAGS += -R 4 -p 0x1000 > +# Disable noisy checks by default > +DTC_FLAGS += -Wno-unit_address_vs_reg > > PHONY += dtbs > dtbs: $(addprefix $(obj)/, $(dtb-y)) > diff --git a/arch/mips/dts/Makefile b/arch/mips/dts/Makefile > index b513918..c254942 100644 > --- a/arch/mips/dts/Makefile > +++ b/arch/mips/dts/Makefile > @@ -7,7 +7,8 @@ dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb > targets += $(dtb-y) > > # Add any required device tree compiler flags here > -DTC_FLAGS += > +# Disable noisy checks by default > +DTC_FLAGS += -Wno-unit_address_vs_reg > > PHONY += dtbs > dtbs: $(addprefix $(obj)/, $(dtb-y)) > diff --git a/arch/nios2/dts/Makefile b/arch/nios2/dts/Makefile > index f22fabf..7af6e39 100644 > --- a/arch/nios2/dts/Makefile > +++ b/arch/nios2/dts/Makefile > @@ -7,6 +7,8 @@ dtb-y += $(CONFIG_DEFAULT_DEVICE_TREE:"%"=%).dtb > targets += $(dtb-y) > > DTC_FLAGS += -R 4 -p 0x1000 > +# Disable noisy checks by default > +DTC_FLAGS += -Wno-unit_address_vs_reg > > PHONY += dtbs > dtbs: $(addprefix $(obj)/, $(dtb-y)) > diff --git a/arch/powerpc/dts/Makefile b/arch/powerpc/dts/Makefile > index 80b4c0c..908155e 100644 > --- a/arch/powerpc/dts/Makefile > +++ b/arch/powerpc/dts/Makefile > @@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb > targets += $(dtb-y) > > DTC_FLAGS += -R 4 -p 0x1000 > +# Disable noisy checks by default > +DTC_FLAGS += -Wno-unit_address_vs_reg > > PHONY += dtbs > dtbs: $(addprefix $(obj)/, $(dtb-y)) > diff --git a/arch/sandbox/dts/Makefile b/arch/sandbox/dts/Makefile > index 0197569..ba94157 100644 > --- a/arch/sandbox/dts/Makefile > +++ b/arch/sandbox/dts/Makefile > @@ -8,6 +8,8 @@ dtb-$(CONFIG_UT_DM) += test.dtb > targets += $(dtb-y) > > DTC_FLAGS += -R 4 -p 0x1000 > +# Disable noisy checks by default > +DTC_FLAGS += -Wno-unit_address_vs_reg > > PHONY += dtbs > dtbs: $(addprefix $(obj)/, $(dtb-y)) > diff --git a/arch/x86/dts/Makefile b/arch/x86/dts/Makefile > index 23156bb..562b21a 100644 > --- a/arch/x86/dts/Makefile > +++ b/arch/x86/dts/Makefile > @@ -19,6 +19,8 @@ dtb-y += bayleybay.dtb \ > targets += $(dtb-y) > > DTC_FLAGS += -R 4 -p 0x1000 > +# Disable noisy checks by default > +DTC_FLAGS += -Wno-unit_address_vs_reg > > PHONY += dtbs > dtbs: $(addprefix $(obj)/, $(dtb-y)) >
Hello Marek, Am 21.04.2016 um 14:51 schrieb Marek Vasut: > On 04/21/2016 02:48 PM, Heiko Schocher wrote: >> suppress a lot of >> "reg or ranges property, but no unit name" warnings, >> through the dtc compiler flag "-Wno-unit_address_vs_reg". >> >> If all DTS are fixed, we can remove this flag again. >> >> Signed-off-by: Heiko Schocher <hs@denx.de> >> --- >> There is also a solution to suppress warnings from >> the dtc compiler by the "-q" flag, but that would >> suppress all warnings. Not realy what I want. > > Yep > >> With this patch and patch: >> http://patchwork.ozlabs.org/patch/609150/ >> >> travis build passes, see: >> https://travis-ci.org/hsdenx/u-boot/builds/124723016 >> >> >> arch/arc/dts/Makefile | 2 ++ >> arch/arm/dts/Makefile | 3 ++- >> arch/microblaze/dts/Makefile | 2 ++ >> arch/mips/dts/Makefile | 3 ++- >> arch/nios2/dts/Makefile | 2 ++ >> arch/powerpc/dts/Makefile | 2 ++ >> arch/sandbox/dts/Makefile | 2 ++ >> arch/x86/dts/Makefile | 2 ++ >> 8 files changed, 16 insertions(+), 2 deletions(-) > > Isn't there some common place in scripts/ or so where we can disable > this warning using an one-liner ? I don;t know ... but I prefer to disable this per arch .. so we can enable the check back if one arch is fixed ... bye, Heiko > >> diff --git a/arch/arc/dts/Makefile b/arch/arc/dts/Makefile >> index d4772ec..de8a1e1 100644 >> --- a/arch/arc/dts/Makefile >> +++ b/arch/arc/dts/Makefile >> @@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_TB100) += abilis_tb100.dtb >> targets += $(dtb-y) >> >> DTC_FLAGS += -R 4 -p 0x1000 >> +# Disable noisy checks by default >> +DTC_FLAGS += -Wno-unit_address_vs_reg >> >> PHONY += dtbs >> dtbs: $(addprefix $(obj)/, $(dtb-y)) >> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile >> index aa31fd9..e2da4c6 100644 >> --- a/arch/arm/dts/Makefile >> +++ b/arch/arm/dts/Makefile >> @@ -234,7 +234,8 @@ dtb-$(CONFIG_SOC_KEYSTONE) += k2hk-evm.dtb \ >> targets += $(dtb-y) >> >> # Add any required device tree compiler flags here >> -DTC_FLAGS += >> +# Disable noisy checks by default >> +DTC_FLAGS += -Wno-unit_address_vs_reg >> >> PHONY += dtbs >> dtbs: $(addprefix $(obj)/, $(dtb-y)) >> diff --git a/arch/microblaze/dts/Makefile b/arch/microblaze/dts/Makefile >> index 5e70d9e..0ccd3ee 100644 >> --- a/arch/microblaze/dts/Makefile >> +++ b/arch/microblaze/dts/Makefile >> @@ -7,6 +7,8 @@ dtb-y += microblaze-generic.dtb >> targets += $(dtb-y) >> >> DTC_FLAGS += -R 4 -p 0x1000 >> +# Disable noisy checks by default >> +DTC_FLAGS += -Wno-unit_address_vs_reg >> >> PHONY += dtbs >> dtbs: $(addprefix $(obj)/, $(dtb-y)) >> diff --git a/arch/mips/dts/Makefile b/arch/mips/dts/Makefile >> index b513918..c254942 100644 >> --- a/arch/mips/dts/Makefile >> +++ b/arch/mips/dts/Makefile >> @@ -7,7 +7,8 @@ dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb >> targets += $(dtb-y) >> >> # Add any required device tree compiler flags here >> -DTC_FLAGS += >> +# Disable noisy checks by default >> +DTC_FLAGS += -Wno-unit_address_vs_reg >> >> PHONY += dtbs >> dtbs: $(addprefix $(obj)/, $(dtb-y)) >> diff --git a/arch/nios2/dts/Makefile b/arch/nios2/dts/Makefile >> index f22fabf..7af6e39 100644 >> --- a/arch/nios2/dts/Makefile >> +++ b/arch/nios2/dts/Makefile >> @@ -7,6 +7,8 @@ dtb-y += $(CONFIG_DEFAULT_DEVICE_TREE:"%"=%).dtb >> targets += $(dtb-y) >> >> DTC_FLAGS += -R 4 -p 0x1000 >> +# Disable noisy checks by default >> +DTC_FLAGS += -Wno-unit_address_vs_reg >> >> PHONY += dtbs >> dtbs: $(addprefix $(obj)/, $(dtb-y)) >> diff --git a/arch/powerpc/dts/Makefile b/arch/powerpc/dts/Makefile >> index 80b4c0c..908155e 100644 >> --- a/arch/powerpc/dts/Makefile >> +++ b/arch/powerpc/dts/Makefile >> @@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb >> targets += $(dtb-y) >> >> DTC_FLAGS += -R 4 -p 0x1000 >> +# Disable noisy checks by default >> +DTC_FLAGS += -Wno-unit_address_vs_reg >> >> PHONY += dtbs >> dtbs: $(addprefix $(obj)/, $(dtb-y)) >> diff --git a/arch/sandbox/dts/Makefile b/arch/sandbox/dts/Makefile >> index 0197569..ba94157 100644 >> --- a/arch/sandbox/dts/Makefile >> +++ b/arch/sandbox/dts/Makefile >> @@ -8,6 +8,8 @@ dtb-$(CONFIG_UT_DM) += test.dtb >> targets += $(dtb-y) >> >> DTC_FLAGS += -R 4 -p 0x1000 >> +# Disable noisy checks by default >> +DTC_FLAGS += -Wno-unit_address_vs_reg >> >> PHONY += dtbs >> dtbs: $(addprefix $(obj)/, $(dtb-y)) >> diff --git a/arch/x86/dts/Makefile b/arch/x86/dts/Makefile >> index 23156bb..562b21a 100644 >> --- a/arch/x86/dts/Makefile >> +++ b/arch/x86/dts/Makefile >> @@ -19,6 +19,8 @@ dtb-y += bayleybay.dtb \ >> targets += $(dtb-y) >> >> DTC_FLAGS += -R 4 -p 0x1000 >> +# Disable noisy checks by default >> +DTC_FLAGS += -Wno-unit_address_vs_reg >> >> PHONY += dtbs >> dtbs: $(addprefix $(obj)/, $(dtb-y)) >> > >
On 04/21/2016 03:17 PM, Heiko Schocher wrote: > Hello Marek, > > Am 21.04.2016 um 14:51 schrieb Marek Vasut: >> On 04/21/2016 02:48 PM, Heiko Schocher wrote: >>> suppress a lot of >>> "reg or ranges property, but no unit name" warnings, >>> through the dtc compiler flag "-Wno-unit_address_vs_reg". >>> >>> If all DTS are fixed, we can remove this flag again. >>> >>> Signed-off-by: Heiko Schocher <hs@denx.de> >>> --- >>> There is also a solution to suppress warnings from >>> the dtc compiler by the "-q" flag, but that would >>> suppress all warnings. Not realy what I want. >> >> Yep >> >>> With this patch and patch: >>> http://patchwork.ozlabs.org/patch/609150/ >>> >>> travis build passes, see: >>> https://travis-ci.org/hsdenx/u-boot/builds/124723016 >>> >>> >>> arch/arc/dts/Makefile | 2 ++ >>> arch/arm/dts/Makefile | 3 ++- >>> arch/microblaze/dts/Makefile | 2 ++ >>> arch/mips/dts/Makefile | 3 ++- >>> arch/nios2/dts/Makefile | 2 ++ >>> arch/powerpc/dts/Makefile | 2 ++ >>> arch/sandbox/dts/Makefile | 2 ++ >>> arch/x86/dts/Makefile | 2 ++ >>> 8 files changed, 16 insertions(+), 2 deletions(-) >> >> Isn't there some common place in scripts/ or so where we can disable >> this warning using an one-liner ? > > I don;t know ... but I prefer to disable this per arch .. so we can > enable the check back if one arch is fixed ... In my opinion, we should stick to the same behavior Linux does. Ccing a few more people.
On Thu, Apr 21, 2016 at 03:25:20PM +0200, Marek Vasut wrote: > On 04/21/2016 03:17 PM, Heiko Schocher wrote: > > Hello Marek, > > > > Am 21.04.2016 um 14:51 schrieb Marek Vasut: > >> On 04/21/2016 02:48 PM, Heiko Schocher wrote: > >>> suppress a lot of > >>> "reg or ranges property, but no unit name" warnings, > >>> through the dtc compiler flag "-Wno-unit_address_vs_reg". > >>> > >>> If all DTS are fixed, we can remove this flag again. > >>> > >>> Signed-off-by: Heiko Schocher <hs@denx.de> > >>> --- > >>> There is also a solution to suppress warnings from > >>> the dtc compiler by the "-q" flag, but that would > >>> suppress all warnings. Not realy what I want. > >> > >> Yep > >> > >>> With this patch and patch: > >>> http://patchwork.ozlabs.org/patch/609150/ > >>> > >>> travis build passes, see: > >>> https://travis-ci.org/hsdenx/u-boot/builds/124723016 > >>> > >>> > >>> arch/arc/dts/Makefile | 2 ++ > >>> arch/arm/dts/Makefile | 3 ++- > >>> arch/microblaze/dts/Makefile | 2 ++ > >>> arch/mips/dts/Makefile | 3 ++- > >>> arch/nios2/dts/Makefile | 2 ++ > >>> arch/powerpc/dts/Makefile | 2 ++ > >>> arch/sandbox/dts/Makefile | 2 ++ > >>> arch/x86/dts/Makefile | 2 ++ > >>> 8 files changed, 16 insertions(+), 2 deletions(-) > >> > >> Isn't there some common place in scripts/ or so where we can disable > >> this warning using an one-liner ? > > > > I don;t know ... but I prefer to disable this per arch .. so we can > > enable the check back if one arch is fixed ... > > In my opinion, we should stick to the same behavior Linux does. > Ccing a few more people. Agreed.
Hi, On 21 April 2016 at 07:25, Marek Vasut <marex@denx.de> wrote: > On 04/21/2016 03:17 PM, Heiko Schocher wrote: >> Hello Marek, >> >> Am 21.04.2016 um 14:51 schrieb Marek Vasut: >>> On 04/21/2016 02:48 PM, Heiko Schocher wrote: >>>> suppress a lot of >>>> "reg or ranges property, but no unit name" warnings, >>>> through the dtc compiler flag "-Wno-unit_address_vs_reg". >>>> >>>> If all DTS are fixed, we can remove this flag again. >>>> >>>> Signed-off-by: Heiko Schocher <hs@denx.de> >>>> --- >>>> There is also a solution to suppress warnings from >>>> the dtc compiler by the "-q" flag, but that would >>>> suppress all warnings. Not realy what I want. >>> >>> Yep >>> >>>> With this patch and patch: >>>> http://patchwork.ozlabs.org/patch/609150/ >>>> >>>> travis build passes, see: >>>> https://travis-ci.org/hsdenx/u-boot/builds/124723016 >>>> >>>> >>>> arch/arc/dts/Makefile | 2 ++ >>>> arch/arm/dts/Makefile | 3 ++- >>>> arch/microblaze/dts/Makefile | 2 ++ >>>> arch/mips/dts/Makefile | 3 ++- >>>> arch/nios2/dts/Makefile | 2 ++ >>>> arch/powerpc/dts/Makefile | 2 ++ >>>> arch/sandbox/dts/Makefile | 2 ++ >>>> arch/x86/dts/Makefile | 2 ++ >>>> 8 files changed, 16 insertions(+), 2 deletions(-) >>> >>> Isn't there some common place in scripts/ or so where we can disable >>> this warning using an one-liner ? >> >> I don;t know ... but I prefer to disable this per arch .. so we can >> enable the check back if one arch is fixed ... > > In my opinion, we should stick to the same behavior Linux does. > Ccing a few more people. Wouldn't it be better to fix the problems? Regards, Simon
On 04/21/2016 03:35 PM, Simon Glass wrote: > Hi, > > On 21 April 2016 at 07:25, Marek Vasut <marex@denx.de> wrote: >> On 04/21/2016 03:17 PM, Heiko Schocher wrote: >>> Hello Marek, >>> >>> Am 21.04.2016 um 14:51 schrieb Marek Vasut: >>>> On 04/21/2016 02:48 PM, Heiko Schocher wrote: >>>>> suppress a lot of >>>>> "reg or ranges property, but no unit name" warnings, >>>>> through the dtc compiler flag "-Wno-unit_address_vs_reg". >>>>> >>>>> If all DTS are fixed, we can remove this flag again. >>>>> >>>>> Signed-off-by: Heiko Schocher <hs@denx.de> >>>>> --- >>>>> There is also a solution to suppress warnings from >>>>> the dtc compiler by the "-q" flag, but that would >>>>> suppress all warnings. Not realy what I want. >>>> >>>> Yep >>>> >>>>> With this patch and patch: >>>>> http://patchwork.ozlabs.org/patch/609150/ >>>>> >>>>> travis build passes, see: >>>>> https://travis-ci.org/hsdenx/u-boot/builds/124723016 >>>>> >>>>> >>>>> arch/arc/dts/Makefile | 2 ++ >>>>> arch/arm/dts/Makefile | 3 ++- >>>>> arch/microblaze/dts/Makefile | 2 ++ >>>>> arch/mips/dts/Makefile | 3 ++- >>>>> arch/nios2/dts/Makefile | 2 ++ >>>>> arch/powerpc/dts/Makefile | 2 ++ >>>>> arch/sandbox/dts/Makefile | 2 ++ >>>>> arch/x86/dts/Makefile | 2 ++ >>>>> 8 files changed, 16 insertions(+), 2 deletions(-) >>>> >>>> Isn't there some common place in scripts/ or so where we can disable >>>> this warning using an one-liner ? >>> >>> I don;t know ... but I prefer to disable this per arch .. so we can >>> enable the check back if one arch is fixed ... >> >> In my opinion, we should stick to the same behavior Linux does. >> Ccing a few more people. > > Wouldn't it be better to fix the problems? My impression was that these warnings are just the result of over-eagerness of DTC, that's why Linux prints them only if you increase the W= (warning) verbosity. I might be wrong tho.
On Thu, Apr 21, 2016 at 03:50:28PM +0200, Marek Vasut wrote: > On 04/21/2016 03:35 PM, Simon Glass wrote: > > Hi, > > > > On 21 April 2016 at 07:25, Marek Vasut <marex@denx.de> wrote: > >> On 04/21/2016 03:17 PM, Heiko Schocher wrote: > >>> Hello Marek, > >>> > >>> Am 21.04.2016 um 14:51 schrieb Marek Vasut: > >>>> On 04/21/2016 02:48 PM, Heiko Schocher wrote: > >>>>> suppress a lot of > >>>>> "reg or ranges property, but no unit name" warnings, > >>>>> through the dtc compiler flag "-Wno-unit_address_vs_reg". > >>>>> > >>>>> If all DTS are fixed, we can remove this flag again. > >>>>> > >>>>> Signed-off-by: Heiko Schocher <hs@denx.de> > >>>>> --- > >>>>> There is also a solution to suppress warnings from > >>>>> the dtc compiler by the "-q" flag, but that would > >>>>> suppress all warnings. Not realy what I want. > >>>> > >>>> Yep > >>>> > >>>>> With this patch and patch: > >>>>> http://patchwork.ozlabs.org/patch/609150/ > >>>>> > >>>>> travis build passes, see: > >>>>> https://travis-ci.org/hsdenx/u-boot/builds/124723016 > >>>>> > >>>>> > >>>>> arch/arc/dts/Makefile | 2 ++ > >>>>> arch/arm/dts/Makefile | 3 ++- > >>>>> arch/microblaze/dts/Makefile | 2 ++ > >>>>> arch/mips/dts/Makefile | 3 ++- > >>>>> arch/nios2/dts/Makefile | 2 ++ > >>>>> arch/powerpc/dts/Makefile | 2 ++ > >>>>> arch/sandbox/dts/Makefile | 2 ++ > >>>>> arch/x86/dts/Makefile | 2 ++ > >>>>> 8 files changed, 16 insertions(+), 2 deletions(-) > >>>> > >>>> Isn't there some common place in scripts/ or so where we can disable > >>>> this warning using an one-liner ? > >>> > >>> I don;t know ... but I prefer to disable this per arch .. so we can > >>> enable the check back if one arch is fixed ... > >> > >> In my opinion, we should stick to the same behavior Linux does. > >> Ccing a few more people. > > > > Wouldn't it be better to fix the problems? > > My impression was that these warnings are just the result of > over-eagerness of DTC, that's why Linux prints them only if you > increase the W= (warning) verbosity. I might be wrong tho. They are minor problems. For the vast majority of the dts files we have, the fixes will come in via re-syncs with the kernel and in at least some cases it's not just a simple regex but also "oh, lets give things better names". With respect to dts files that we really do own (ie x86) yes, we should fix them.
Hello Tom, Am 21.04.2016 um 15:53 schrieb Tom Rini: > On Thu, Apr 21, 2016 at 03:50:28PM +0200, Marek Vasut wrote: >> On 04/21/2016 03:35 PM, Simon Glass wrote: >>> Hi, >>> >>> On 21 April 2016 at 07:25, Marek Vasut <marex@denx.de> wrote: >>>> On 04/21/2016 03:17 PM, Heiko Schocher wrote: >>>>> Hello Marek, >>>>> >>>>> Am 21.04.2016 um 14:51 schrieb Marek Vasut: >>>>>> On 04/21/2016 02:48 PM, Heiko Schocher wrote: >>>>>>> suppress a lot of >>>>>>> "reg or ranges property, but no unit name" warnings, >>>>>>> through the dtc compiler flag "-Wno-unit_address_vs_reg". >>>>>>> >>>>>>> If all DTS are fixed, we can remove this flag again. >>>>>>> >>>>>>> Signed-off-by: Heiko Schocher <hs@denx.de> >>>>>>> --- >>>>>>> There is also a solution to suppress warnings from >>>>>>> the dtc compiler by the "-q" flag, but that would >>>>>>> suppress all warnings. Not realy what I want. >>>>>> >>>>>> Yep >>>>>> >>>>>>> With this patch and patch: >>>>>>> http://patchwork.ozlabs.org/patch/609150/ >>>>>>> >>>>>>> travis build passes, see: >>>>>>> https://travis-ci.org/hsdenx/u-boot/builds/124723016 >>>>>>> >>>>>>> >>>>>>> arch/arc/dts/Makefile | 2 ++ >>>>>>> arch/arm/dts/Makefile | 3 ++- >>>>>>> arch/microblaze/dts/Makefile | 2 ++ >>>>>>> arch/mips/dts/Makefile | 3 ++- >>>>>>> arch/nios2/dts/Makefile | 2 ++ >>>>>>> arch/powerpc/dts/Makefile | 2 ++ >>>>>>> arch/sandbox/dts/Makefile | 2 ++ >>>>>>> arch/x86/dts/Makefile | 2 ++ >>>>>>> 8 files changed, 16 insertions(+), 2 deletions(-) >>>>>> >>>>>> Isn't there some common place in scripts/ or so where we can disable >>>>>> this warning using an one-liner ? >>>>> >>>>> I don;t know ... but I prefer to disable this per arch .. so we can >>>>> enable the check back if one arch is fixed ... >>>> >>>> In my opinion, we should stick to the same behavior Linux does. >>>> Ccing a few more people. >>> >>> Wouldn't it be better to fix the problems? >> >> My impression was that these warnings are just the result of >> over-eagerness of DTC, that's why Linux prints them only if you >> increase the W= (warning) verbosity. I might be wrong tho. > > They are minor problems. For the vast majority of the dts files we > have, the fixes will come in via re-syncs with the kernel and in at > least some cases it's not just a simple regex but also "oh, lets give > things better names". With respect to dts files that we really do own > (ie x86) yes, we should fix them. So, this patch from me could be still an option? http://patchwork.ozlabs.org/patch/610866/ (at least for the sandbox fixes?) (I have a v2 where I worked in the comments from Bin ...) bye, Heiko
On Thu, Apr 21, 2016 at 04:11:25PM +0200, Heiko Schocher wrote: > Hello Tom, > > Am 21.04.2016 um 15:53 schrieb Tom Rini: > >On Thu, Apr 21, 2016 at 03:50:28PM +0200, Marek Vasut wrote: > >>On 04/21/2016 03:35 PM, Simon Glass wrote: > >>>Hi, > >>> > >>>On 21 April 2016 at 07:25, Marek Vasut <marex@denx.de> wrote: > >>>>On 04/21/2016 03:17 PM, Heiko Schocher wrote: > >>>>>Hello Marek, > >>>>> > >>>>>Am 21.04.2016 um 14:51 schrieb Marek Vasut: > >>>>>>On 04/21/2016 02:48 PM, Heiko Schocher wrote: > >>>>>>>suppress a lot of > >>>>>>>"reg or ranges property, but no unit name" warnings, > >>>>>>>through the dtc compiler flag "-Wno-unit_address_vs_reg". > >>>>>>> > >>>>>>>If all DTS are fixed, we can remove this flag again. > >>>>>>> > >>>>>>>Signed-off-by: Heiko Schocher <hs@denx.de> > >>>>>>>--- > >>>>>>>There is also a solution to suppress warnings from > >>>>>>>the dtc compiler by the "-q" flag, but that would > >>>>>>>suppress all warnings. Not realy what I want. > >>>>>> > >>>>>>Yep > >>>>>> > >>>>>>>With this patch and patch: > >>>>>>>http://patchwork.ozlabs.org/patch/609150/ > >>>>>>> > >>>>>>>travis build passes, see: > >>>>>>>https://travis-ci.org/hsdenx/u-boot/builds/124723016 > >>>>>>> > >>>>>>> > >>>>>>> arch/arc/dts/Makefile | 2 ++ > >>>>>>> arch/arm/dts/Makefile | 3 ++- > >>>>>>> arch/microblaze/dts/Makefile | 2 ++ > >>>>>>> arch/mips/dts/Makefile | 3 ++- > >>>>>>> arch/nios2/dts/Makefile | 2 ++ > >>>>>>> arch/powerpc/dts/Makefile | 2 ++ > >>>>>>> arch/sandbox/dts/Makefile | 2 ++ > >>>>>>> arch/x86/dts/Makefile | 2 ++ > >>>>>>> 8 files changed, 16 insertions(+), 2 deletions(-) > >>>>>> > >>>>>>Isn't there some common place in scripts/ or so where we can disable > >>>>>>this warning using an one-liner ? > >>>>> > >>>>>I don;t know ... but I prefer to disable this per arch .. so we can > >>>>>enable the check back if one arch is fixed ... > >>>> > >>>>In my opinion, we should stick to the same behavior Linux does. > >>>>Ccing a few more people. > >>> > >>>Wouldn't it be better to fix the problems? > >> > >>My impression was that these warnings are just the result of > >>over-eagerness of DTC, that's why Linux prints them only if you > >>increase the W= (warning) verbosity. I might be wrong tho. > > > >They are minor problems. For the vast majority of the dts files we > >have, the fixes will come in via re-syncs with the kernel and in at > >least some cases it's not just a simple regex but also "oh, lets give > >things better names". With respect to dts files that we really do own > >(ie x86) yes, we should fix them. > > So, this patch from me could be still an option? > > http://patchwork.ozlabs.org/patch/610866/ > > (at least for the sandbox fixes?) > (I have a v2 where I worked in the comments from Bin ...) Yes, but I want to make sure we think about the renames and aren't trying to silence the warning. I'm sorry but the MIPS "fixes" have me leery of other blind changes.
diff --git a/arch/arc/dts/Makefile b/arch/arc/dts/Makefile index d4772ec..de8a1e1 100644 --- a/arch/arc/dts/Makefile +++ b/arch/arc/dts/Makefile @@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_TB100) += abilis_tb100.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y)) diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index aa31fd9..e2da4c6 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -234,7 +234,8 @@ dtb-$(CONFIG_SOC_KEYSTONE) += k2hk-evm.dtb \ targets += $(dtb-y) # Add any required device tree compiler flags here -DTC_FLAGS += +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y)) diff --git a/arch/microblaze/dts/Makefile b/arch/microblaze/dts/Makefile index 5e70d9e..0ccd3ee 100644 --- a/arch/microblaze/dts/Makefile +++ b/arch/microblaze/dts/Makefile @@ -7,6 +7,8 @@ dtb-y += microblaze-generic.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y)) diff --git a/arch/mips/dts/Makefile b/arch/mips/dts/Makefile index b513918..c254942 100644 --- a/arch/mips/dts/Makefile +++ b/arch/mips/dts/Makefile @@ -7,7 +7,8 @@ dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb targets += $(dtb-y) # Add any required device tree compiler flags here -DTC_FLAGS += +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y)) diff --git a/arch/nios2/dts/Makefile b/arch/nios2/dts/Makefile index f22fabf..7af6e39 100644 --- a/arch/nios2/dts/Makefile +++ b/arch/nios2/dts/Makefile @@ -7,6 +7,8 @@ dtb-y += $(CONFIG_DEFAULT_DEVICE_TREE:"%"=%).dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y)) diff --git a/arch/powerpc/dts/Makefile b/arch/powerpc/dts/Makefile index 80b4c0c..908155e 100644 --- a/arch/powerpc/dts/Makefile +++ b/arch/powerpc/dts/Makefile @@ -9,6 +9,8 @@ dtb-$(CONFIG_TARGET_XILINX_PPC405_GENERIC) += xilinx-ppc405-generic.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y)) diff --git a/arch/sandbox/dts/Makefile b/arch/sandbox/dts/Makefile index 0197569..ba94157 100644 --- a/arch/sandbox/dts/Makefile +++ b/arch/sandbox/dts/Makefile @@ -8,6 +8,8 @@ dtb-$(CONFIG_UT_DM) += test.dtb targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y)) diff --git a/arch/x86/dts/Makefile b/arch/x86/dts/Makefile index 23156bb..562b21a 100644 --- a/arch/x86/dts/Makefile +++ b/arch/x86/dts/Makefile @@ -19,6 +19,8 @@ dtb-y += bayleybay.dtb \ targets += $(dtb-y) DTC_FLAGS += -R 4 -p 0x1000 +# Disable noisy checks by default +DTC_FLAGS += -Wno-unit_address_vs_reg PHONY += dtbs dtbs: $(addprefix $(obj)/, $(dtb-y))
suppress a lot of "reg or ranges property, but no unit name" warnings, through the dtc compiler flag "-Wno-unit_address_vs_reg". If all DTS are fixed, we can remove this flag again. Signed-off-by: Heiko Schocher <hs@denx.de> --- There is also a solution to suppress warnings from the dtc compiler by the "-q" flag, but that would suppress all warnings. Not realy what I want. With this patch and patch: http://patchwork.ozlabs.org/patch/609150/ travis build passes, see: https://travis-ci.org/hsdenx/u-boot/builds/124723016 arch/arc/dts/Makefile | 2 ++ arch/arm/dts/Makefile | 3 ++- arch/microblaze/dts/Makefile | 2 ++ arch/mips/dts/Makefile | 3 ++- arch/nios2/dts/Makefile | 2 ++ arch/powerpc/dts/Makefile | 2 ++ arch/sandbox/dts/Makefile | 2 ++ arch/x86/dts/Makefile | 2 ++ 8 files changed, 16 insertions(+), 2 deletions(-)