| Message ID | 1460645912-8568-1-git-send-email-nicolas.dichtel@6wind.com |
|---|---|
| State | Accepted |
| Headers | show |
On 04/14/16 16:58, Nicolas Dichtel wrote: > The goal is to fix the compilation of perf (from linux) when LD or AR > variables are inherited from the environment. > After the linux upstream commits 5ef7bbb09f7b ("perf tools: Allow to > specify custom linker command") and 3c71ba3f80bb ("perf tools: Really allow > to specify custom CC, AR or LD") CC, AR, and LD variables are not overridden > if they are inherited. > > In case of a cross compilation, it results in an inconsistent state: CC is > overridden but not LD and AR. > > Linux-patch: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5ef7bbb09f7b > Linux-patch: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3c71ba3f80bb > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index ea8b1e4e51c8..55735ea735ae 100644 > --- a/Makefile > +++ b/Makefile > @@ -343,6 +343,8 @@ ifeq ($(BR2_HAVE_DOT_CONFIG),y) > unexport CROSS_COMPILE > unexport ARCH > unexport CC > +unexport LD > +unexport AR > unexport CXX > unexport CPP > unexport RANLIB >
diff --git a/Makefile b/Makefile index ea8b1e4e51c8..55735ea735ae 100644 --- a/Makefile +++ b/Makefile @@ -343,6 +343,8 @@ ifeq ($(BR2_HAVE_DOT_CONFIG),y) unexport CROSS_COMPILE unexport ARCH unexport CC +unexport LD +unexport AR unexport CXX unexport CPP unexport RANLIB
The goal is to fix the compilation of perf (from linux) when LD or AR variables are inherited from the environment. After the linux upstream commits 5ef7bbb09f7b ("perf tools: Allow to specify custom linker command") and 3c71ba3f80bb ("perf tools: Really allow to specify custom CC, AR or LD") CC, AR, and LD variables are not overridden if they are inherited. In case of a cross compilation, it results in an inconsistent state: CC is overridden but not LD and AR. Linux-patch: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5ef7bbb09f7b Linux-patch: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3c71ba3f80bb Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> --- Makefile | 2 ++ 1 file changed, 2 insertions(+)