diff mbox

[U-Boot,1/2] scsi: add PCIe to sata converter Marvell chip 88SE9170

Message ID 1460545185-30767-1-git-send-email-po.liu@nxp.com
State Superseded
Delegated to: York Sun
Headers show

Commit Message

Po Liu April 13, 2016, 10:59 a.m. UTC 
Add to the command scsi device list.

Signed-off-by: Po Liu <po.liu@nxp.com>
---
 cmd/scsi.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

York Sun May 16, 2016, 4:02 p.m. UTC | #1 
On 04/13/2016 04:09 AM, Po Liu wrote:
> Add to the command scsi device list.
> 
> Signed-off-by: Po Liu <po.liu@nxp.com>
> ---
>  cmd/scsi.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/cmd/scsi.c b/cmd/scsi.c
> index 8991125..c85fefc 100644
> --- a/cmd/scsi.c
> +++ b/cmd/scsi.c
> @@ -31,6 +31,11 @@
>  #define SCSI_VEND_ID 0x10b9
>  #define SCSI_DEV_ID  0x5288
>  
> +#elif defined CONFIG_SATA_88SE9170
> +
> +#define SCSI_VEND_ID 0x1b4b
> +#define SCSI_DEV_ID  0x9170
> +
>  #elif !defined(CONFIG_SCSI_AHCI_PLAT)
>  #error no scsi device defined
>  #endif
> 

Po,

Would it be a better idea to define CONFIG_SCSI_DEV_LIST in your board header
file? You can merge your two patches into one.

York
Po Liu May 17, 2016, 1:02 a.m. UTC | #2 
>  -----Original Message-----
>  From: York Sun [mailto:york.sun@nxp.com]
>  Sent: Tuesday, May 17, 2016 12:03 AM
>  To: Po Liu
>  Cc: u-boot@lists.denx.de; Simon Glass; Bin Meng; osp@andrep.de;
>  mark.langsdorf@gmail.com
>  Subject: Re: [PATCH 1/2] scsi: add PCIe to sata converter Marvell chip
>  88SE9170
>  
>  On 04/13/2016 04:09 AM, Po Liu wrote:
>  > Add to the command scsi device list.
>  >
>  > Signed-off-by: Po Liu <po.liu@nxp.com>
>  > ---
>  >  cmd/scsi.c | 5 +++++
>  >  1 file changed, 5 insertions(+)
>  >
>  > diff --git a/cmd/scsi.c b/cmd/scsi.c
>  > index 8991125..c85fefc 100644
>  > --- a/cmd/scsi.c
>  > +++ b/cmd/scsi.c
>  > @@ -31,6 +31,11 @@
>  >  #define SCSI_VEND_ID 0x10b9
>  >  #define SCSI_DEV_ID  0x5288
>  >
>  > +#elif defined CONFIG_SATA_88SE9170
>  > +
>  > +#define SCSI_VEND_ID 0x1b4b
>  > +#define SCSI_DEV_ID  0x9170
>  > +
>  >  #elif !defined(CONFIG_SCSI_AHCI_PLAT)  #error no scsi device defined
>  > #endif
>  >
>  
>  Po,
>  
>  Would it be a better idea to define CONFIG_SCSI_DEV_LIST in your board
>  header
>  file? You can merge your two patches into one.
Ok, Understand.
>  
>  York
>
diff mbox

Patch

diff --git a/cmd/scsi.c b/cmd/scsi.c
index 8991125..c85fefc 100644
--- a/cmd/scsi.c
+++ b/cmd/scsi.c
@@ -31,6 +31,11 @@ 
 #define SCSI_VEND_ID 0x10b9
 #define SCSI_DEV_ID  0x5288
 
+#elif defined CONFIG_SATA_88SE9170
+
+#define SCSI_VEND_ID 0x1b4b
+#define SCSI_DEV_ID  0x9170
+
 #elif !defined(CONFIG_SCSI_AHCI_PLAT)
 #error no scsi device defined
 #endif