| Message ID | 1460395823-1399-1-git-send-email-bobby.prani@gmail.com |
|---|---|
| State | New |
| Headers | show |
Hi On Mon, Apr 11, 2016 at 7:30 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: > Add a missing end brace and update doc to point to the latest access > macro. ACCESS_ONE() is deprecated. ONE/ONCE > > Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> > --- > docs/atomics.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/atomics.txt b/docs/atomics.txt > index ef285e3..bba771e 100644 > --- a/docs/atomics.txt > +++ b/docs/atomics.txt > @@ -62,7 +62,7 @@ operations: > typeof(*ptr) atomic_fetch_sub(ptr, val) > typeof(*ptr) atomic_fetch_and(ptr, val) > typeof(*ptr) atomic_fetch_or(ptr, val) > - typeof(*ptr) atomic_xchg(ptr, val > + typeof(*ptr) atomic_xchg(ptr, val) I was going to send the same fix ;) > typeof(*ptr) atomic_cmpxchg(ptr, old, new) > > all of which return the old value of *ptr. These operations are > @@ -328,7 +328,7 @@ and memory barriers, and the equivalents in QEMU: > > - atomic_read and atomic_set in Linux give no guarantee at all; > atomic_read and atomic_set in QEMU include a compiler barrier > - (similar to the ACCESS_ONCE macro in Linux). > + (similar to the READ_ONCE/WRITE_ONCE macros in Linux). > That looks accurate to me, but I am not very familiar with these > - most atomic read-modify-write operations in Linux return void; why removing that line? > in QEMU, all of them return the old value of the variable. > -- > 2.8.1 > >
On 12 April 2016 at 12:42, Marc-André Lureau <marcandre.lureau@gmail.com> wrote: > Hi > > On Mon, Apr 11, 2016 at 7:30 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: >> - atomic_read and atomic_set in Linux give no guarantee at all; >> atomic_read and atomic_set in QEMU include a compiler barrier >> - (similar to the ACCESS_ONCE macro in Linux). >> + (similar to the READ_ONCE/WRITE_ONCE macros in Linux). >> > > That looks accurate to me, but I am not very familiar with these > >> - most atomic read-modify-write operations in Linux return void; > > why removing that line? Count the spaces :-) It's a line of context which happens to start with a "-" character, not a line being removed. thanks -- PMM
On Tue, Apr 12, 2016 at 7:42 AM, Marc-André Lureau <marcandre.lureau@gmail.com> wrote: > Hi > > On Mon, Apr 11, 2016 at 7:30 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: >> Add a missing end brace and update doc to point to the latest access >> macro. ACCESS_ONE() is deprecated. > > ONE/ONCE Right, I missed this one. Should I fix and send a new patch? Thanks,
On 12/04/2016 18:08, Pranith Kumar wrote: > On Tue, Apr 12, 2016 at 7:42 AM, Marc-André Lureau > <marcandre.lureau@gmail.com> wrote: >> Hi >> >> On Mon, Apr 11, 2016 at 7:30 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: >>> Add a missing end brace and update doc to point to the latest access >>> macro. ACCESS_ONE() is deprecated. >> >> ONE/ONCE > > Right, I missed this one. Should I fix and send a new patch? FWIW I'll be mostly offline this week and on vacation starting from the next, so it's probably best if you send the patch at the beginning of May. It will be fixed _and_ act as a reminder. :) Paolo
On Tue, Apr 12, 2016 at 5:20 PM, Paolo Bonzini <pbonzini@redhat.com> wrote: > FWIW I'll be mostly offline this week and on vacation starting from the > next, so it's probably best if you send the patch at the beginning of > May. It will be fixed _and_ act as a reminder. :) Sure, I will do so in May.
diff --git a/docs/atomics.txt b/docs/atomics.txt index ef285e3..bba771e 100644 --- a/docs/atomics.txt +++ b/docs/atomics.txt @@ -62,7 +62,7 @@ operations: typeof(*ptr) atomic_fetch_sub(ptr, val) typeof(*ptr) atomic_fetch_and(ptr, val) typeof(*ptr) atomic_fetch_or(ptr, val) - typeof(*ptr) atomic_xchg(ptr, val + typeof(*ptr) atomic_xchg(ptr, val) typeof(*ptr) atomic_cmpxchg(ptr, old, new) all of which return the old value of *ptr. These operations are @@ -328,7 +328,7 @@ and memory barriers, and the equivalents in QEMU: - atomic_read and atomic_set in Linux give no guarantee at all; atomic_read and atomic_set in QEMU include a compiler barrier - (similar to the ACCESS_ONCE macro in Linux). + (similar to the READ_ONCE/WRITE_ONCE macros in Linux). - most atomic read-modify-write operations in Linux return void; in QEMU, all of them return the old value of the variable.
Add a missing end brace and update doc to point to the latest access macro. ACCESS_ONE() is deprecated. Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> --- docs/atomics.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)