| Message ID | 1460370583-29038-1-git-send-email-kraxel@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 11 April 2016 at 11:29, Gerd Hoffmann <kraxel@redhat.com> wrote: > Hi, > > Here comes a virtio-input update, with a bugfix collection from Ladi > Prosek and live migration support. > > please pull, > Gerd > > The following changes since commit 9628af036fade986dcc94f4484bc75c6b1a06d84: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160408' into staging (2016-04-08 13:45:52 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-input-20160411-1 > > for you to fetch changes up to e2392a72e88104272f3986f0846e4f2f45453b26: > > virtio-input: fix emulated tablet axis ranges (2016-04-11 11:45:11 +0200) > > ---------------------------------------------------------------- > virtio-input; live migration support, various bugfixes. Hi. I'm afraid this doesn't compile on ppc64be: /home/pm215/qemu/hw/input/virtio-input-hid.c:487:9: error: suggest parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses] .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1), ^ /home/pm215/qemu/hw/input/virtio-input-hid.c:492:9: error: suggest parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses] .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1), ^ It looks like the const_le32() and const_le16() macros in include/hw/virtio/virtio-input.h are missing brackets around the macro argument -- can you send a patch which adds the missing brackets, please? (Side question, why is an apparently generic endianness support macro implemented in virtio-input.h ?) thanks -- PMM
> Hi. I'm afraid this doesn't compile on ppc64be: > > /home/pm215/qemu/hw/input/virtio-input-hid.c:487:9: error: suggest > parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses] > .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1), > ^ > /home/pm215/qemu/hw/input/virtio-input-hid.c:492:9: error: suggest > parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses] > .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1), > ^ > > It looks like the const_le32() and const_le16() macros in > include/hw/virtio/virtio-input.h are missing brackets around the macro > argument Indeed. /me needs a be machine. > -- can you send a patch which adds the missing brackets, please? Sure. > (Side question, why is an apparently generic endianness support > macro implemented in virtio-input.h ?) Suggestions for a better place? Looks like there isn't something like byteorder.h ... cheers, Gerd
On 11 April 2016 at 16:12, Gerd Hoffmann <kraxel@redhat.com> wrote: >> Hi. I'm afraid this doesn't compile on ppc64be: >> >> /home/pm215/qemu/hw/input/virtio-input-hid.c:487:9: error: suggest >> parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses] >> .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1), >> ^ >> /home/pm215/qemu/hw/input/virtio-input-hid.c:492:9: error: suggest >> parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses] >> .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1), >> ^ >> >> It looks like the const_le32() and const_le16() macros in >> include/hw/virtio/virtio-input.h are missing brackets around the macro >> argument > > Indeed. /me needs a be machine. If you have access to the gcc compile farm, there's a ppc64be box in it. > Suggestions for a better place? Looks like there isn't something like > byteorder.h ... include/qemu/bswap.h. thanks -- PMM
Hi, Here comes a virtio-input update, with a bugfix collection from Ladi Prosek and live migration support. please pull, Gerd The following changes since commit 9628af036fade986dcc94f4484bc75c6b1a06d84: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160408' into staging (2016-04-08 13:45:52 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-input-20160411-1 for you to fetch changes up to e2392a72e88104272f3986f0846e4f2f45453b26: virtio-input: fix emulated tablet axis ranges (2016-04-11 11:45:11 +0200) ---------------------------------------------------------------- virtio-input; live migration support, various bugfixes. ---------------------------------------------------------------- Gerd Hoffmann (1): virtio-input: add live migration support Ladi Prosek (4): virtio-input: add missing key mappings virtio-input: retrieve EV_LED host config bits virtio-input: implement pass-through evdev writes virtio-input: fix emulated tablet axis ranges hw/input/virtio-input-hid.c | 6 ++++-- hw/input/virtio-input-host.c | 24 ++++++++++++++++++++++++ hw/input/virtio-input.c | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+), 2 deletions(-)