mbox

[PULL,0/4] slirp: deliver received TCP RSTs to the guest

Message ID 1460018068-7909-1-git-send-email-samuel.thibault@ens-lyon.org
State New
Headers show

Pull-request

http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

Message

Samuel Thibault April 7, 2016, 8:34 a.m. UTC 
The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346:

  Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100)

are available in the git repository at:

  http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

for you to fetch changes up to b9b314378ce0fdb4996a0316cb34246f746ac8cf:

  slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets (2016-04-07 10:28:53 +0200)

----------------------------------------------------------------
slirp updates

----------------------------------------------------------------
Edgar E. Iglesias (1):
      slirp: Propagate host TCP RST to the guest.

Steven Luo (3):
      slirp: don't crash when tcp_sockclosed() is called with a NULL tp
      slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error
      slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

 slirp/slirp.c     | 12 +++++++++++-
 slirp/socket.c    | 34 +++++++++++++++++++++++++++-------
 slirp/socket.h    |  2 +-
 slirp/tcp_input.c |  6 ++++++
 slirp/tcp_subr.c  |  7 +++++--
 5 files changed, 50 insertions(+), 11 deletions(-)

Comments

Peter Maydell April 7, 2016, 10:13 a.m. UTC | #1 
On 7 April 2016 at 09:34, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346:
>
>   Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100)
>
> are available in the git repository at:
>
>   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to b9b314378ce0fdb4996a0316cb34246f746ac8cf:
>
>   slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets (2016-04-07 10:28:53 +0200)
>
> ----------------------------------------------------------------
> slirp updates
>
> ----------------------------------------------------------------
> Edgar E. Iglesias (1):
>       slirp: Propagate host TCP RST to the guest.
>
> Steven Luo (3):
>       slirp: don't crash when tcp_sockclosed() is called with a NULL tp
>       slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error
>       slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

The patch from Edgar appears to be missing Edgar's signed-off-by ?

thanks
-- PMM
Edgar E. Iglesias April 7, 2016, 10:27 a.m. UTC | #2 
On Thu, Apr 07, 2016 at 11:13:37AM +0100, Peter Maydell wrote:
> On 7 April 2016 at 09:34, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> > The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346:
> >
> >   Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100)
> >
> > are available in the git repository at:
> >
> >   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
> >
> > for you to fetch changes up to b9b314378ce0fdb4996a0316cb34246f746ac8cf:
> >
> >   slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets (2016-04-07 10:28:53 +0200)
> >
> > ----------------------------------------------------------------
> > slirp updates
> >
> > ----------------------------------------------------------------
> > Edgar E. Iglesias (1):
> >       slirp: Propagate host TCP RST to the guest.
> >
> > Steven Luo (3):
> >       slirp: don't crash when tcp_sockclosed() is called with a NULL tp
> >       slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error
> >       slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets
> 
> The patch from Edgar appears to be missing Edgar's signed-off-by ?

Yes, this patch is ancient from times when SoBs were not commonly used but feel free to add one:

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Thanks,
Edgar


> 
> thanks
> -- PMM
Peter Maydell April 7, 2016, 10:37 a.m. UTC | #3 
On 7 April 2016 at 11:27, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> On Thu, Apr 07, 2016 at 11:13:37AM +0100, Peter Maydell wrote:
>> On 7 April 2016 at 09:34, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
>> > The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346:
>> >
>> >   Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>> >
>> > for you to fetch changes up to b9b314378ce0fdb4996a0316cb34246f746ac8cf:
>> >
>> >   slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets (2016-04-07 10:28:53 +0200)
>> >
>> > ----------------------------------------------------------------
>> > slirp updates
>> >
>> > ----------------------------------------------------------------
>> > Edgar E. Iglesias (1):
>> >       slirp: Propagate host TCP RST to the guest.
>> >
>> > Steven Luo (3):
>> >       slirp: don't crash when tcp_sockclosed() is called with a NULL tp
>> >       slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error
>> >       slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets
>>
>> The patch from Edgar appears to be missing Edgar's signed-off-by ?
>
> Yes, this patch is ancient from times when SoBs were not commonly used but feel free to add one:
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Thanks; Samuel, can I ask you to respin with that line added?

-- PMM
Samuel Thibault April 7, 2016, 11:04 a.m. UTC | #4 
Peter Maydell, on Thu 07 Apr 2016 11:37:45 +0100, wrote:
> Thanks; Samuel, can I ask you to respin with that line added?

Done so.

Samuel