| Message ID | 58c09f315d8199fb8df78705cab270663227ed4f.1459967279.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Michal, On 6 April 2016 at 12:28, Michal Simek <michal.simek@xilinx.com> wrote: > Create CMD_FDT Kconfig entry to have an option to disable fdt command > which is not required for small configuration which requires libfdt > only. > Enable it by default for all targets which enables OF_LIBFDT. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Changes in v2: None > > cmd/Kconfig | 7 +++++++ > cmd/Makefile | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index fe8b4f0510da..8703cdb4a9be 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -173,6 +173,13 @@ config CMD_ELF > help > Boot an ELF/vxWorks image from the memory. > > +config CMD_FDT > + bool "Flattened Device Tree utility commands" > + default y > + depends on OF_LIBFDT > + help > + Do FDT related setup before booting into the Operating System. > + > config CMD_GO > bool "go" > default y > diff --git a/cmd/Makefile b/cmd/Makefile > index ba041973079c..f95759e67044 100644 > --- a/cmd/Makefile > +++ b/cmd/Makefile > @@ -54,7 +54,7 @@ obj-$(CONFIG_CMD_EXT4) += ext4.o > obj-$(CONFIG_CMD_EXT2) += ext2.o > obj-$(CONFIG_CMD_FAT) += fat.o > obj-$(CONFIG_CMD_FDC) += fdc.o > -obj-$(CONFIG_OF_LIBFDT) += fdt.o > +obj-$(CONFIG_CMD_FDT) += fdt.o Won't this disable the command for lots of boards? > obj-$(CONFIG_CMD_FITUPD) += fitupd.o > obj-$(CONFIG_CMD_FLASH) += flash.o > ifdef CONFIG_FPGA > -- > 1.9.1 > Regards, Simon
On 9.4.2016 20:36, Simon Glass wrote: > Hi Michal, > > On 6 April 2016 at 12:28, Michal Simek <michal.simek@xilinx.com> wrote: >> Create CMD_FDT Kconfig entry to have an option to disable fdt command >> which is not required for small configuration which requires libfdt >> only. >> Enable it by default for all targets which enables OF_LIBFDT. >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> Changes in v2: None >> >> cmd/Kconfig | 7 +++++++ >> cmd/Makefile | 2 +- >> 2 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/cmd/Kconfig b/cmd/Kconfig >> index fe8b4f0510da..8703cdb4a9be 100644 >> --- a/cmd/Kconfig >> +++ b/cmd/Kconfig >> @@ -173,6 +173,13 @@ config CMD_ELF >> help >> Boot an ELF/vxWorks image from the memory. >> >> +config CMD_FDT >> + bool "Flattened Device Tree utility commands" >> + default y >> + depends on OF_LIBFDT >> + help >> + Do FDT related setup before booting into the Operating System. >> + >> config CMD_GO >> bool "go" >> default y >> diff --git a/cmd/Makefile b/cmd/Makefile >> index ba041973079c..f95759e67044 100644 >> --- a/cmd/Makefile >> +++ b/cmd/Makefile >> @@ -54,7 +54,7 @@ obj-$(CONFIG_CMD_EXT4) += ext4.o >> obj-$(CONFIG_CMD_EXT2) += ext2.o >> obj-$(CONFIG_CMD_FAT) += fat.o >> obj-$(CONFIG_CMD_FDC) += fdc.o >> -obj-$(CONFIG_OF_LIBFDT) += fdt.o >> +obj-$(CONFIG_CMD_FDT) += fdt.o > > Won't this disable the command for lots of boards? Also based on Masahiro response boards shouldn't be affected. Only that 6 boards needs to be fixed which is what I have done in 1/2. http://lists.denx.de/pipermail/u-boot/2016-April/250628.html Thanks, Michal
Hi Tom, On 11.4.2016 07:33, Michal Simek wrote: > On 9.4.2016 20:36, Simon Glass wrote: >> Hi Michal, >> >> On 6 April 2016 at 12:28, Michal Simek <michal.simek@xilinx.com> wrote: >>> Create CMD_FDT Kconfig entry to have an option to disable fdt command >>> which is not required for small configuration which requires libfdt >>> only. >>> Enable it by default for all targets which enables OF_LIBFDT. >>> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>> --- >>> >>> Changes in v2: None >>> >>> cmd/Kconfig | 7 +++++++ >>> cmd/Makefile | 2 +- >>> 2 files changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/cmd/Kconfig b/cmd/Kconfig >>> index fe8b4f0510da..8703cdb4a9be 100644 >>> --- a/cmd/Kconfig >>> +++ b/cmd/Kconfig >>> @@ -173,6 +173,13 @@ config CMD_ELF >>> help >>> Boot an ELF/vxWorks image from the memory. >>> >>> +config CMD_FDT >>> + bool "Flattened Device Tree utility commands" >>> + default y >>> + depends on OF_LIBFDT >>> + help >>> + Do FDT related setup before booting into the Operating System. >>> + >>> config CMD_GO >>> bool "go" >>> default y >>> diff --git a/cmd/Makefile b/cmd/Makefile >>> index ba041973079c..f95759e67044 100644 >>> --- a/cmd/Makefile >>> +++ b/cmd/Makefile >>> @@ -54,7 +54,7 @@ obj-$(CONFIG_CMD_EXT4) += ext4.o >>> obj-$(CONFIG_CMD_EXT2) += ext2.o >>> obj-$(CONFIG_CMD_FAT) += fat.o >>> obj-$(CONFIG_CMD_FDC) += fdc.o >>> -obj-$(CONFIG_OF_LIBFDT) += fdt.o >>> +obj-$(CONFIG_CMD_FDT) += fdt.o >> >> Won't this disable the command for lots of boards? > > Also based on Masahiro response boards shouldn't be affected. > Only that 6 boards needs to be fixed which is what I have done in 1/2. > http://lists.denx.de/pipermail/u-boot/2016-April/250628.html Do you see any problem with these 2 patches? When this is resolved I can push mini configuration for zynqmp. Thanks, Michal
On Wed, Apr 06, 2016 at 08:28:04PM +0200, Michal Simek wrote: > Create CMD_FDT Kconfig entry to have an option to disable fdt command > which is not required for small configuration which requires libfdt > only. > Enable it by default for all targets which enables OF_LIBFDT. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Applied to u-boot/master, thanks!
diff --git a/cmd/Kconfig b/cmd/Kconfig index fe8b4f0510da..8703cdb4a9be 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -173,6 +173,13 @@ config CMD_ELF help Boot an ELF/vxWorks image from the memory. +config CMD_FDT + bool "Flattened Device Tree utility commands" + default y + depends on OF_LIBFDT + help + Do FDT related setup before booting into the Operating System. + config CMD_GO bool "go" default y diff --git a/cmd/Makefile b/cmd/Makefile index ba041973079c..f95759e67044 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -54,7 +54,7 @@ obj-$(CONFIG_CMD_EXT4) += ext4.o obj-$(CONFIG_CMD_EXT2) += ext2.o obj-$(CONFIG_CMD_FAT) += fat.o obj-$(CONFIG_CMD_FDC) += fdc.o -obj-$(CONFIG_OF_LIBFDT) += fdt.o +obj-$(CONFIG_CMD_FDT) += fdt.o obj-$(CONFIG_CMD_FITUPD) += fitupd.o obj-$(CONFIG_CMD_FLASH) += flash.o ifdef CONFIG_FPGA
Create CMD_FDT Kconfig entry to have an option to disable fdt command which is not required for small configuration which requires libfdt only. Enable it by default for all targets which enables OF_LIBFDT. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- Changes in v2: None cmd/Kconfig | 7 +++++++ cmd/Makefile | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-)