| Message ID | 1459157187-4805-1-git-send-email-van.freenix@gmail.com |
|---|---|
| State | Accepted |
| Commit | 9a5d993e657d73820eb3aa0543cee4c3531f5ba1 |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, Mar 28, 2016 at 05:26:27PM +0800, Peng Fan wrote: > Add exclamation mark to the errmsg, when error and set_default_env. This is awkwardly worded. We aren't adding a literal ! to the errmsg itself, we're adding that as a flag. I'll try and re-word this when applying to be clearer. > > Signed-off-by: Peng Fan <van.freenix@gmail.com> > Cc: Mario Schuknecht <mario.schuknecht@dresearch-fe.de> > Cc: Vignesh R <vigneshr@ti.com> > Cc: Jagan Teki <jteki@openedev.com> > Cc: Ravi Babu <ravibabu@ti.com> > Cc: York Sun <york.sun@nxp.com> > Cc: Tom Rini <trini@konsulko.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Mon, Mar 28, 2016 at 05:26:27PM +0800, Peng Fan wrote: > Add exclamation mark to the errmsg, when error and set_default_env. > > Signed-off-by: Peng Fan <van.freenix@gmail.com> > Cc: Mario Schuknecht <mario.schuknecht@dresearch-fe.de> > Cc: Vignesh R <vigneshr@ti.com> > Cc: Jagan Teki <jteki@openedev.com> > Cc: Ravi Babu <ravibabu@ti.com> > Cc: York Sun <york.sun@nxp.com> > Cc: Tom Rini <trini@konsulko.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/common/env_sf.c b/common/env_sf.c index 892e6cb..273098c 100644 --- a/common/env_sf.c +++ b/common/env_sf.c @@ -225,7 +225,7 @@ void env_relocate_spec(void) ret = env_import((char *)ep, 0); if (!ret) { error("Cannot import environment: errno = %d\n", errno); - set_default_env("env_import failed"); + set_default_env("!env_import failed"); } err_read:
Add exclamation mark to the errmsg, when error and set_default_env. Signed-off-by: Peng Fan <van.freenix@gmail.com> Cc: Mario Schuknecht <mario.schuknecht@dresearch-fe.de> Cc: Vignesh R <vigneshr@ti.com> Cc: Jagan Teki <jteki@openedev.com> Cc: Ravi Babu <ravibabu@ti.com> Cc: York Sun <york.sun@nxp.com> Cc: Tom Rini <trini@konsulko.com> --- common/env_sf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)