mbox

[PULL,00/10] tricore-patches

Message ID 1458654386-1001-1-git-send-email-kbastian@mail.uni-paderborn.de
State New
Headers show

Pull-request

https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore-20160322

Message

Bastian Koppelmann March 22, 2016, 1:46 p.m. UTC 
The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' into staging (2016-03-18 17:18:41 +0000)

are available in the git repository at:

  https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore-20160322

for you to fetch changes up to d66718ccf37b71eff686c3d6116223889736188f:

  target-tricore: Add ftoi and itof instructions (2016-03-21 18:04:16 +0100)

----------------------------------------------------------------
TriCore FPU + bugfixes

----------------------------------------------------------------
Bastian Koppelmann (10):
      target-tricore: add missing break in insn decode switch stmt
      target-tricore: Fix helper_msub64_q_ssov not reseting OVF bit
      target-tricore: Fix psw_read() clearing too many bits
      target-tricore: Add FPU infrastructure
      target-tricore: Move general CHECK_REG_PAIR of decode_rrr_divide
      target-tricore: add add.f/sub.f instructions
      target-tricore: Add mul.f instruction
      target-tricore: Add div.f instruction
      target-tricore: Add cmp.f instruction
      target-tricore: Add ftoi and itof instructions

 fpu/softfloat-specialize.h       |   2 +-
 target-tricore/Makefile.objs     |   2 +-
 target-tricore/cpu.h             |   6 +-
 target-tricore/fpu_helper.c      | 227 +++++++++++++++++++++++++++++++++++++++
 target-tricore/helper.c          |  12 ++-
 target-tricore/helper.h          |   7 ++
 target-tricore/op_helper.c       |   2 +
 target-tricore/translate.c       |  34 +++++-
 target-tricore/tricore-opcodes.h |  18 ++++
 9 files changed, 303 insertions(+), 7 deletions(-)
 create mode 100644 target-tricore/fpu_helper.c

Comments

Peter Maydell March 22, 2016, 8:15 p.m. UTC | #1 
On 22 March 2016 at 13:46, Bastian Koppelmann
<kbastian@mail.uni-paderborn.de> wrote:
> The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' into staging (2016-03-18 17:18:41 +0000)
>
> are available in the git repository at:
>
>   https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore-20160322
>
> for you to fetch changes up to d66718ccf37b71eff686c3d6116223889736188f:
>
>   target-tricore: Add ftoi and itof instructions (2016-03-21 18:04:16 +0100)

Hi; I'm afraid this doesn't build with clang:

/home/petmay01/linaro/qemu-for-merges/target-tricore/fpu_helper.c:45:20:
error: unused function 'f_is_pos_inf' [-Werror,-Wunused-function]
static inline bool f_is_pos_inf(float32 arg)
                   ^
/home/petmay01/linaro/qemu-for-merges/target-tricore/fpu_helper.c:50:20:
error: unused function 'f_is_neg_inf' [-Werror,-Wunused-function]
static inline bool f_is_neg_inf(float32 arg)
                   ^

(clang is stricter than gcc about unused static functions in
.c files.)

thanks
-- PMM
Bastian Koppelmann March 23, 2016, 8:17 a.m. UTC | #2 
On 03/22/2016 09:15 PM, Peter Maydell wrote:
> On 22 March 2016 at 13:46, Bastian Koppelmann
> <kbastian@mail.uni-paderborn.de> wrote:
>> The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:
>>
>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' into staging (2016-03-18 17:18:41 +0000)
>>
>> are available in the git repository at:
>>
>>   https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore-20160322
>>
>> for you to fetch changes up to d66718ccf37b71eff686c3d6116223889736188f:
>>
>>   target-tricore: Add ftoi and itof instructions (2016-03-21 18:04:16 +0100)
> 
> Hi; I'm afraid this doesn't build with clang:
> 
> /home/petmay01/linaro/qemu-for-merges/target-tricore/fpu_helper.c:45:20:
> error: unused function 'f_is_pos_inf' [-Werror,-Wunused-function]
> static inline bool f_is_pos_inf(float32 arg)
>                    ^
> /home/petmay01/linaro/qemu-for-merges/target-tricore/fpu_helper.c:50:20:
> error: unused function 'f_is_neg_inf' [-Werror,-Wunused-function]
> static inline bool f_is_neg_inf(float32 arg)
>    
                ^
Whoops, these functions are not supposed to be there. I'll remove them
and re-spin.

Cheers,
Bastian