diff mbox

[U-Boot,07/11] pxa: start.S: enable SRAM clock

Message ID 1458524230-10827-7-git-send-email-anarsoul@gmail.com
State Accepted
Commit 9ddde3e6ce8abd97d397e3915204a6981d287e42
Delegated to: Tom Rini
Headers show

Commit Message

Vasily Khoruzhick March 21, 2016, 1:37 a.m. UTC
SRAM is used for early stack, but kernel disables its clock on suspend.
Re-enable SRAM clock on startup, otherwise u-boot crashes on resume from suspend.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm/cpu/pxa/start.S | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Marek Vasut March 21, 2016, 1:50 a.m. UTC | #1
On 03/21/2016 02:37 AM, Vasily Khoruzhick wrote:
> SRAM is used for early stack, but kernel disables its clock on suspend.
> Re-enable SRAM clock on startup, otherwise u-boot crashes on resume from suspend.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
>  arch/arm/cpu/pxa/start.S | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/pxa/start.S b/arch/arm/cpu/pxa/start.S
> index 24b6ad1..ce1181a 100644
> --- a/arch/arm/cpu/pxa/start.S
> +++ b/arch/arm/cpu/pxa/start.S
> @@ -53,7 +53,15 @@ reset:
>  #ifdef	CONFIG_CPU_PXA25X
>  	bl	lock_cache_for_stack
>  #endif
> -
> +#ifdef	CONFIG_CPU_PXA27X
> +	/*
> +	 * enable clock for SRAM
> +	 */
> +	ldr	r0,=CKEN
> +	ldr	r1,[r0]
> +	orr	r1,r1,#(1 << 20)

Don't we have a macro for this 1 << 20 already ?

> +	str	r1,[r0]
> +#endif
>  	bl	_main
>  
>  /*------------------------------------------------------------------------------*/
>
Tom Rini March 27, 2016, 10:29 p.m. UTC | #2
On Sun, Mar 20, 2016 at 06:37:06PM -0700, Vasily Khoruzhick wrote:

> SRAM is used for early stack, but kernel disables its clock on suspend.
> Re-enable SRAM clock on startup, otherwise u-boot crashes on resume from suspend.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/arch/arm/cpu/pxa/start.S b/arch/arm/cpu/pxa/start.S
index 24b6ad1..ce1181a 100644
--- a/arch/arm/cpu/pxa/start.S
+++ b/arch/arm/cpu/pxa/start.S
@@ -53,7 +53,15 @@  reset:
 #ifdef	CONFIG_CPU_PXA25X
 	bl	lock_cache_for_stack
 #endif
-
+#ifdef	CONFIG_CPU_PXA27X
+	/*
+	 * enable clock for SRAM
+	 */
+	ldr	r0,=CKEN
+	ldr	r1,[r0]
+	orr	r1,r1,#(1 << 20)
+	str	r1,[r0]
+#endif
 	bl	_main
 
 /*------------------------------------------------------------------------------*/