| Message ID | 1458524230-10827-3-git-send-email-anarsoul@gmail.com |
|---|---|
| State | Accepted |
| Commit | 3bc8ffd9cb774feceefc7bdebe9353fcea071343 |
| Delegated to: | Tom Rini |
| Headers | show |
On 03/21/2016 02:37 AM, Vasily Khoruzhick wrote: > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> What happens if you display picture ? Will the colors be complete mess ? > --- > drivers/video/pxa_lcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/pxa_lcd.c b/drivers/video/pxa_lcd.c > index 1809fc6..ba4f897 100644 > --- a/drivers/video/pxa_lcd.c > +++ b/drivers/video/pxa_lcd.c > @@ -166,7 +166,7 @@ vidinfo_t panel_info = { > #ifdef CONFIG_LMS283GF05 > > # define LCD_BPP LCD_COLOR8 > -/*# define LCD_INVERT_COLORS*/ > +# define LCD_INVERT_COLORS > > /* you have to set lccr0 and lccr3 (including pcd) */ > # define REG_LCCR0 0x043008f8 >
On Sun, Mar 20, 2016 at 6:48 PM, Marek Vasut <marex@denx.de> wrote: > On 03/21/2016 02:37 AM, Vasily Khoruzhick wrote: >> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > > What happens if you display picture ? Will the colors be complete mess ? Yes, inverted. Can be fixed by inverting colors in BMP. I didn't find another way to get white on black console in u-boot. >> --- >> drivers/video/pxa_lcd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/video/pxa_lcd.c b/drivers/video/pxa_lcd.c >> index 1809fc6..ba4f897 100644 >> --- a/drivers/video/pxa_lcd.c >> +++ b/drivers/video/pxa_lcd.c >> @@ -166,7 +166,7 @@ vidinfo_t panel_info = { >> #ifdef CONFIG_LMS283GF05 >> >> # define LCD_BPP LCD_COLOR8 >> -/*# define LCD_INVERT_COLORS*/ >> +# define LCD_INVERT_COLORS >> >> /* you have to set lccr0 and lccr3 (including pcd) */ >> # define REG_LCCR0 0x043008f8 >> > > > -- > Best regards, > Marek Vasut
On 03/21/2016 03:10 AM, Vasily Khoruzhick wrote: > On Sun, Mar 20, 2016 at 6:48 PM, Marek Vasut <marex@denx.de> wrote: >> On 03/21/2016 02:37 AM, Vasily Khoruzhick wrote: >>> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> >> >> What happens if you display picture ? Will the colors be complete mess ? > > Yes, inverted. Can be fixed by inverting colors in BMP. I didn't find > another way to get white on black > console in u-boot. CONFIG_SYS_WHITE_ON_BLACK might help. >>> --- >>> drivers/video/pxa_lcd.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/pxa_lcd.c b/drivers/video/pxa_lcd.c >>> index 1809fc6..ba4f897 100644 >>> --- a/drivers/video/pxa_lcd.c >>> +++ b/drivers/video/pxa_lcd.c >>> @@ -166,7 +166,7 @@ vidinfo_t panel_info = { >>> #ifdef CONFIG_LMS283GF05 >>> >>> # define LCD_BPP LCD_COLOR8 >>> -/*# define LCD_INVERT_COLORS*/ >>> +# define LCD_INVERT_COLORS >>> >>> /* you have to set lccr0 and lccr3 (including pcd) */ >>> # define REG_LCCR0 0x043008f8 >>> >> >> >> -- >> Best regards, >> Marek Vasut
On Sun, Mar 20, 2016 at 06:37:02PM -0700, Vasily Khoruzhick wrote:
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Applied to u-boot/master, thanks!
On 03/28/2016 12:29 AM, Tom Rini wrote: > On Sun, Mar 20, 2016 at 06:37:02PM -0700, Vasily Khoruzhick wrote: > >> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > > Applied to u-boot/master, thanks! > NAK. This actually breaks the correct behavior of the PXA framebuffer driver. Please do not ignore comments which these patches have. I will pick them through the PXA tree when this is sorted out.
On Mon, Mar 28, 2016 at 01:26:43AM +0200, Marek Vasut wrote: > On 03/28/2016 12:29 AM, Tom Rini wrote: > > On Sun, Mar 20, 2016 at 06:37:02PM -0700, Vasily Khoruzhick wrote: > > > >> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > > > > Applied to u-boot/master, thanks! > > > NAK. > > This actually breaks the correct behavior of the PXA framebuffer driver. > Please do not ignore comments which these patches have. > I will pick them through the PXA tree when this is sorted out. Sorry, reverted.
diff --git a/drivers/video/pxa_lcd.c b/drivers/video/pxa_lcd.c index 1809fc6..ba4f897 100644 --- a/drivers/video/pxa_lcd.c +++ b/drivers/video/pxa_lcd.c @@ -166,7 +166,7 @@ vidinfo_t panel_info = { #ifdef CONFIG_LMS283GF05 # define LCD_BPP LCD_COLOR8 -/*# define LCD_INVERT_COLORS*/ +# define LCD_INVERT_COLORS /* you have to set lccr0 and lccr3 (including pcd) */ # define REG_LCCR0 0x043008f8
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> --- drivers/video/pxa_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)