| Message ID | 1458297886-19686-1-git-send-email-prabhakar.kushwaha@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | York Sun |
| Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3qRMhc3Ylqz9sR9 for <incoming@patchwork.ozlabs.org>; Fri, 18 Mar 2016 22:00:48 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1F871A76D4; Fri, 18 Mar 2016 12:00:46 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zVpGcJEVIki0; Fri, 18 Mar 2016 12:00:45 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9425BA76C3; Fri, 18 Mar 2016 12:00:45 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A2EA4A767D for <u-boot@lists.denx.de>; Fri, 18 Mar 2016 12:00:41 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xx_1CYofsHlX for <u-boot@lists.denx.de>; Fri, 18 Mar 2016 12:00:41 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0087.outbound.protection.outlook.com [157.56.111.87]) by theia.denx.de (Postfix) with ESMTPS id 2A6BBA76CA for <u-boot@lists.denx.de>; Fri, 18 Mar 2016 12:00:34 +0100 (CET) Received: from BN3PR0301CA0040.namprd03.prod.outlook.com (10.160.180.178) by BY2PR0301MB1589.namprd03.prod.outlook.com (10.163.28.19) with Microsoft SMTP Server (TLS) id 15.1.443.7; Fri, 18 Mar 2016 10:44:55 +0000 Received: from BN1BFFO11OLC002.protection.gbl (2a01:111:f400:7c10::1:188) by BN3PR0301CA0040.outlook.office365.com (2a01:111:e400:4000::50) with Microsoft SMTP Server (TLS) id 15.1.443.12 via Frontend Transport; Fri, 18 Mar 2016 10:44:55 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11OLC002.mail.protection.outlook.com (10.58.145.13) with Microsoft SMTP Server (TLS) id 15.1.443.6 via Frontend Transport; Fri, 18 Mar 2016 10:44:55 +0000 Received: from b32579-VirtualBox.ap.freescale.net (B32579-02.ap.freescale.net [10.232.40.8]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u2IAimB2014551; Fri, 18 Mar 2016 03:44:53 -0700 From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> To: <u-boot@lists.denx.de> Date: Fri, 18 Mar 2016 16:14:46 +0530 Message-ID: <1458297886-19686-1-git-send-email-prabhakar.kushwaha@nxp.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131027714953795330; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(11100500001)(77096005)(87936001)(106466001)(85426001)(1220700001)(1096002)(2351001)(86362001)(229853001)(4326007)(92566002)(47776003)(50466002)(110136002)(48376002)(189998001)(50986999)(105606002)(36756003)(586003)(81166005)(33646002)(5003940100001)(2906002)(19580395003)(5008740100001)(50226001)(6806005)(104016004)(19580405001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB1589; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11OLC002; 1:m45D6RJCc2IdcKKycESPU/QL2k5SYzkP/Sn6ShN1wn3lDSnjvurl1Zaq4qsI9D+o6BGIak2OY2x8ARhXjWcsGPVmIlHDKlx2cKUAE3h6Iwg/SNNHCeQTp0IGjviddifkwn6d14fg01cgUaYwafDz5KNDFIBJT7vc3ulyh62U9jYCi5nsNuJzA34m9zhcN9gC1Gp1CAmfOSNatuHxZSpdhiktnelk3JxVxqNoNtGeqXYpp7eK3XZDVRkMhHANbNnWVT7fw3vPj7iiK4VLnXgrQS5E1OSaaX9vsulaswMuVt1kbAd4IzP/MLSdL11gir8J5oSQ5UfZD13wbFWLvtLk/w4BKCxLZ/8GHxVS341x4l2IvhbUkohnS91Ep1ffF8klr6xhITk9aqdPuDAdRn+Ejs7eTf2zZAN0yRYjPIdA3XZ6H4meAMwlGzv/TNykr/ZAHX3lrQsHmmHoAfQrk1iPE1AOX97aNORHNRYjow4AQhrKR8cKpvOkGsOYoFB4gwV5Ovk9usdpiniO4dmN0aLw3qUn/VfiVrhZtNUsDTvKgLNQXWIbw96PhB6U3OrSkACNtVwhKkD5qWoA6xOS35pQaq7dRcBWiNRHlIATt6iySoCJiuyEWNIAJxh5cJegx0HL MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8c515ba1-e71f-4c7e-f5a8-08d34f1a5801 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1589; 2:0PCFP8t8FVSFVA00jUo3rjxC+p263jk43EV0k6oWkK5p4EnCo6EcF4CSFvfexHA0Dq4gyrO/eJp4IKySUjEVpvoDoq3MSUcRXaGG0SbdCyyRMiQ22j6arzmHMJPw3c50dDn6Z2cKKWEo5e/5HIlSYQkH4DLdewfD1yr7rrF9ecedGBC1DRdgKfgK+P1kpoRx; 3:GetuAHDcnlpRCckrX1smLDydY8FpK5v6/bR8ShsayWy7O8Lc8gHP1LniBrW2pkIdku/CNovwJL0tQlrqIEE4LmDu4+EPS1zW4ozdePXv9VgNRWxtxE34kTLl6FOaY+zex/K24Wq0hon0inIO7rrnp9ZpXO7KKdCX+1KJS1UdAW6oLg/UbGnR1JgrS6qta0P01EnohN+OF8hyoveNELk7CcwgaPcuzT33DwR+a+JW3oA=; 25:liyHeWiXXjuzHBjeSn4Xa5iaG55+OOPgJPYyLzAgmPDM15fgbJQ5W6AMRmYRX1kiZSAkRlp3EsYnzZGmozX23r78bfAF4K3oYchWjI4zFQESNNAP7FHgDgM0P3X5CHkReJbFAIASpzI6qI8ABzJ8t/1KSemp1Xqevwf+VaFvC1xeALmgXCmgzT5DcmvJ1zCBak8X7fczP3cAnAH7Mn/cyNBCkCdf8/TTuYU2Jw2OKuHozhJ0H+PvNIZa83nL6DID6EuYogD3Mk6k+Ickhtov5eBPYJu2quPX/q2PnBez+/TnKaM12UYZ5XSQVyZgVmmkRM5M+TWu5CSZ4kSuojN1/O5PxjAi7qEU5YbEKPbAlLyeG0sE8ahEI2pmf4ntnaTDlaA1+EVlP7ug8d8fuxC17RuwxUzacqcklHlEPKsN309qHzE9C3OIpZ4TrQq+R5w8MY22TSUDsx8yFJCiuU9BpkLv249f78c72H/R8fc3+WhYuxpmxxPSv5+EgEuhiD7vGVYz/8DIdMAOIDPkDozjuA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB1589; X-Microsoft-Antispam-PRVS: <BY2PR0301MB15896E84D31315CE09FFB2D8978C0@BY2PR0301MB1589.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(13015025)(13023025)(5005006)(13018025)(13024025)(13017025)(10201501046)(3002001); SRVR:BY2PR0301MB1589; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB1589; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1589; 4:wMWbV6BhcJuGSghHtIJDfycwlvegKORayKMV2RuHFch5VFCRhAvUjH5gdQ57jG7VldWA6JKXkhJQ/eTneNJ3+ExaYXAjRt6/127olxuOFCWOF8SR1BuF2lWzjGkJ4vBeeTi6vxUnRZgwUG644CkWgC9+MX+W2pEK2TVUmOiWkj7xXD/OZrquxTuKts06wIIDmLZ+NrOkVO8Eumj4BuSOoJRKaiR7F+KYjAwE4FBV79HatgraDW05oSPd3qIQBjZzrYilKJQ/lf6vo0iMkkW0O3FF04j1pNx/lwf6kzmuJifI+D+cSNEj9ah1dpcPoyulfXDzbLdP2rb59A6kCG9GWMmhVxE/NANlvkLs25FCzz1w6LEZ8525uvIat6TMZpZ/9eOhQfCWWMnt8chJD0RfSL4Be1sglkb0+X4OOi8kM1Mzl81RydnQxGwm3SKXMt46qepiWc4BgF3kAlSKz7Zo+A== X-Forefront-PRVS: 088552DE73 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB1589; 23:HbDuQ7RJJNh/GeYDH4aoevQBWdur1Phn5l+oB/e?= =?us-ascii?Q?azatoy8nuHKIgRdA0a36eTenZ/uZKOkxjsLankyg/wLPm9x8Pi8gKYuwpCw2?= =?us-ascii?Q?aFMk03n8cbvysVWJ//ZWhDfDZ9HLflvw23L7cUAiiJ8EJKejaTbDW3A1Xdzy?= =?us-ascii?Q?AV380HrOo+adTqpKrGVbnGqPT1dsfjW9PoaGdxDBpDxXkjEGBknpxnUFYO4Y?= =?us-ascii?Q?8zTfUZ9/pLp8RwWmY+433bMyjxodD9zMbG+avKBSV5nRP67Kfq/xei52NyXq?= =?us-ascii?Q?oGYDYYAYuIUhXaBNJKQ72qVBG0RuQxAt0+Jr039okpLiDJEPMvta+aArT5TX?= =?us-ascii?Q?InYyK9BVE0oRukNRFcFj3Xe/vDGR4iD6kdbMXYHeFWj/X9AmbJQItrRXY1hm?= =?us-ascii?Q?uvO1CZJh+1LPg12eyMWPjihiB/zWzQ30Bahu5OfakCzvCwL+licZyXXEeZ4N?= =?us-ascii?Q?M/1W5FxZFE3nJ7R68+f8u3UzkUpPMdukMWng8WQoLsY1YylLDAtDcqr+DqId?= =?us-ascii?Q?fOlr+n7ZN/GuOlMOJ0ubh+GVTw0XIx/j5bPSGcXQAabD2GE0cT15VKPVAqoV?= =?us-ascii?Q?bEillXL3IM8iQJT45hWtsSiThufNmzI4PMUjmbm2g7H3K+CBmCMDbkewXkmY?= =?us-ascii?Q?flFkyufjmMdlUi3+P/Fsyl/2TalkbLy38KLy0bDbriD1U9KQ2kU1cX+UtVQX?= =?us-ascii?Q?bfhSKposp8u8zXVaoUr0NMXV3aDY5iCoo/8HtHHNfnFLH2zItW+wuNMCn3EN?= =?us-ascii?Q?byXlxzdYg+PKkLeT3RqgXo2O6Qv9TbgLdDKYqq47V9TcGXe73L3GVcuWvZqA?= =?us-ascii?Q?kWvrJm1DH6EHFrTgCb6hQRpqDQKm2nZoXgdSMyxs7ttLQWuAxnlVCzCrbr4I?= =?us-ascii?Q?vVeyPD3zmun3BB79ThfDuh27QTfN2mIPv95p2xd3iuqjOVt3oONqgHcUN9+f?= =?us-ascii?Q?Gtagn4sDTJV6uqakN9Ke3Y8rwh33+4Qia8pWsJW0JL+0iORUabd002eOWkj/?= =?us-ascii?Q?ZhfRPQ0bzYsQUH4iTDDyrGEkR?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1589; 5:Cxub4Q1rwW4zt181MFQs9zPlLLW2PkkiRL9zJPc8CEeDnkDrtafldN+tyt7Q3KrphHHaV5brztZ/aAwLJUVDdOcMC5HFe1D6L/RPOgpo5WHZLvLNr2tdNucL6HpkHIfXKOIqlwpddov5p2TxFEgU4MU6ze6sf/YQrsWaIVUNYcs=; 24:34h3LGDs0XhUaUezu/7HSaDgMFZ1jsOUYEtc9qLRaEWp/ojO2ubRsyi6O1A8sRAErsYgKhUPchmjT8LMe8bgXwbHi/8BL267qT38Rt0sQWE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2016 10:44:55.1923 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB1589 Subject: [U-Boot] [PATCH] driver: net: fsl-mc: Return from DPAA_exit if boot_status !=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <http://lists.denx.de/mailman/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <http://lists.denx.de/mailman/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> |
On 03/18/2016 03:44 AM, Prabhakar Kushwaha wrote: > return value of get_mc_boot_status() in case of failure is not necessary > to be -1. > > So update the error condition check. > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> > Reported-by: Yao Yuan <yao.yuan@nxp.com> > --- > drivers/net/fsl-mc/mc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c > index 53c4966..7ae619d 100644 > --- a/drivers/net/fsl-mc/mc.c > +++ b/drivers/net/fsl-mc/mc.c > @@ -1147,7 +1147,7 @@ int fsl_mc_ldpaa_exit(bd_t *bd) > { > int err = 0; > > - if (bd && get_mc_boot_status() == -1) > + if (bd && get_mc_boot_status() != 0) > return 0; > A comment would be helpful to understand why 0 is returned here. York
diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c index 53c4966..7ae619d 100644 --- a/drivers/net/fsl-mc/mc.c +++ b/drivers/net/fsl-mc/mc.c @@ -1147,7 +1147,7 @@ int fsl_mc_ldpaa_exit(bd_t *bd) { int err = 0; - if (bd && get_mc_boot_status() == -1) + if (bd && get_mc_boot_status() != 0) return 0; if (bd && !get_mc_boot_status() && get_dpl_apply_status() == -1) {
return value of get_mc_boot_status() in case of failure is not necessary to be -1. So update the error condition check. Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> Reported-by: Yao Yuan <yao.yuan@nxp.com> --- drivers/net/fsl-mc/mc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)