diff mbox

[U-Boot,3/4] sniper: Get rid of reset_misc

Message ID 1456597604-10981-4-git-send-email-contact@paulk.fr
State Accepted
Commit 8e643d748e313b22da145101baaa9fa123455722
Delegated to: Tom Rini
Headers show

Commit Message

Paul Kocialkowski Feb. 27, 2016, 6:26 p.m. UTC
There is no need to set the reboot mode to a particular value prior to reboot,
since valid values will have been caught and cleared earlier.

In addition, this breaks the reboot-bootloader fastboot call, by overriding the
required value for fastboot.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 board/lge/sniper/sniper.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Tom Rini March 15, 2016, 11:52 a.m. UTC | #1
On Sat, Feb 27, 2016 at 07:26:43PM +0100, Paul Kocialkowski wrote:

> There is no need to set the reboot mode to a particular value prior to reboot,
> since valid values will have been caught and cleared earlier.
> 
> In addition, this breaks the reboot-bootloader fastboot call, by overriding the
> required value for fastboot.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini March 17, 2016, 1:57 a.m. UTC | #2
On Sat, Feb 27, 2016 at 07:26:43PM +0100, Paul Kocialkowski wrote:

> There is no need to set the reboot mode to a particular value prior to reboot,
> since valid values will have been caught and cleared earlier.
> 
> In addition, this breaks the reboot-bootloader fastboot call, by overriding the
> required value for fastboot.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/board/lge/sniper/sniper.c b/board/lge/sniper/sniper.c
index b2c8e97..6726866 100644
--- a/board/lge/sniper/sniper.c
+++ b/board/lge/sniper/sniper.c
@@ -157,11 +157,6 @@  void get_board_serial(struct tag_serialnr *serialnr)
 	omap_die_id_get_board_serial(serialnr);
 }
 
-void reset_misc(void)
-{
-	omap_reboot_mode_store("u");
-}
-
 int fb_set_reboot_flag(void)
 {
 	return omap_reboot_mode_store("b");