| Message ID | 1455612720-3758-1-git-send-email-ruscur@russell.cc (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, 2016-02-16 at 19:52 +1100, Russell Currey wrote: > Incredibly, IBM online documentation for EEH uses "extended error handling" > and "enhanced error handling" to refer to the same thing, in different > places. In other parts of the kernel, namely the EEH documentation (found > in Documentation/powerpc/eeh-pci-error-recovery.txt), it's referred to as > "extended", and in my opinion "extended" makes more sense for what EEH > does. > > The only place "enhanced error handling" shows up in the kernel is in > MAINTAINERS, so fix it. Unfortunately the document that pretty much defines it (PAPR) uses "Enhanced": 5.4.1 Enhanced I/O Error Handling (EEH) Option And online I see that the AIX manuals use Enhanced: https://www-01.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.kernextc/eeh_intro.htm So I'm going to nack this and ask you to send the inverse patch, that switches the kernel references to Enhanced. > --- > I don't know what kind of things parse MAINTAINERS, and if there's a chance > this will break them. Only scripts/get_maintainer.pl that I know of, and I don't think it cares about the heading much, so it would be safe to change. > Also, the powerpc tree *is* the right place to send this, right? Yep, patches to MAINTAINERS for powerpc specific stuff should go via me. cheers
On Tue, Feb 16, 2016 at 07:52:00PM +1100, Russell Currey wrote: >Incredibly, IBM online documentation for EEH uses "extended error handling" >and "enhanced error handling" to refer to the same thing, in different >places. In other parts of the kernel, namely the EEH documentation (found >in Documentation/powerpc/eeh-pci-error-recovery.txt), it's referred to as >"extended", and in my opinion "extended" makes more sense for what EEH >does. > >The only place "enhanced error handling" shows up in the kernel is in >MAINTAINERS, so fix it. > Russell, Thanks for fixing it up. Since you're at it, Please replace the maintainer to yourself. Also, the components mentioned in this file are listed in alphabetic order according to their names. As the name of EEH is changed, it would be put in front of "Extended Verification Module (EVM)". >Signed-off-by: Russell Currey <ruscur@russell.cc> With above issues fixed: Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> Thanks, Gavin >--- >I don't know what kind of things parse MAINTAINERS, and if there's a chance >this will break them. Also, the powerpc tree *is* the right place to send >this, right? >--- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/MAINTAINERS b/MAINTAINERS >index 28eb61b..e5d9134 100644 >--- a/MAINTAINERS >+++ b/MAINTAINERS >@@ -4222,7 +4222,7 @@ M: Maxim Levitsky <maximlevitsky@gmail.com> > S: Maintained > F: drivers/media/rc/ene_ir.* > >-ENHANCED ERROR HANDLING (EEH) >+EXTENDED ERROR HANDLING (EEH) > M: Gavin Shan <shangw@linux.vnet.ibm.com> > L: linuxppc-dev@lists.ozlabs.org > S: Supported >-- >2.7.1 > >_______________________________________________ >Linuxppc-dev mailing list >Linuxppc-dev@lists.ozlabs.org >https://lists.ozlabs.org/listinfo/linuxppc-dev
On Wed, Feb 17, 2016 at 09:49:08AM +1100, Gavin Shan wrote: >On Tue, Feb 16, 2016 at 07:52:00PM +1100, Russell Currey wrote: >>Incredibly, IBM online documentation for EEH uses "extended error handling" >>and "enhanced error handling" to refer to the same thing, in different >>places. In other parts of the kernel, namely the EEH documentation (found >>in Documentation/powerpc/eeh-pci-error-recovery.txt), it's referred to as >>"extended", and in my opinion "extended" makes more sense for what EEH >>does. >> >>The only place "enhanced error handling" shows up in the kernel is in >>MAINTAINERS, so fix it. >> > >Russell, Thanks for fixing it up. Since you're at it, Please replace the >maintainer to yourself. Also, the components mentioned in this file are >listed in alphabetic order according to their names. As the name of EEH >is changed, it would be put in front of "Extended Verification Module (EVM)". > I agree with Michael as discussed in another thread: we're going to use "enhanced", not "extended" though some chip datasheet (P7IOC) talks about "extended error handling". Russell, please change the maintainer to you and repost. >>Signed-off-by: Russell Currey <ruscur@russell.cc> > >With above issues fixed: > >Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> > Thanks, Gavin >>--- >>I don't know what kind of things parse MAINTAINERS, and if there's a chance >>this will break them. Also, the powerpc tree *is* the right place to send >>this, right? >>--- >> MAINTAINERS | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/MAINTAINERS b/MAINTAINERS >>index 28eb61b..e5d9134 100644 >>--- a/MAINTAINERS >>+++ b/MAINTAINERS >>@@ -4222,7 +4222,7 @@ M: Maxim Levitsky <maximlevitsky@gmail.com> >> S: Maintained >> F: drivers/media/rc/ene_ir.* >> >>-ENHANCED ERROR HANDLING (EEH) >>+EXTENDED ERROR HANDLING (EEH) >> M: Gavin Shan <shangw@linux.vnet.ibm.com> >> L: linuxppc-dev@lists.ozlabs.org >> S: Supported >>-- >>2.7.1 >> >>_______________________________________________ >>Linuxppc-dev mailing list >>Linuxppc-dev@lists.ozlabs.org >>https://lists.ozlabs.org/listinfo/linuxppc-dev > >_______________________________________________ >Linuxppc-dev mailing list >Linuxppc-dev@lists.ozlabs.org >https://lists.ozlabs.org/listinfo/linuxppc-dev
On Wed, 2016-02-17 at 09:58 +1100, Gavin Shan wrote: > On Wed, Feb 17, 2016 at 09:49:08AM +1100, Gavin Shan wrote: > > > > On Tue, Feb 16, 2016 at 07:52:00PM +1100, Russell Currey wrote: > > > > > > Incredibly, IBM online documentation for EEH uses "extended error > > > handling" > > > and "enhanced error handling" to refer to the same thing, in > > > different > > > places. In other parts of the kernel, namely the EEH documentation > > > (found > > > in Documentation/powerpc/eeh-pci-error-recovery.txt), it's referred > > > to as > > > "extended", and in my opinion "extended" makes more sense for what > > > EEH > > > does. > > > > > > The only place "enhanced error handling" shows up in the kernel is in > > > MAINTAINERS, so fix it. > > > > > Russell, Thanks for fixing it up. Since you're at it, Please replace > > the > > maintainer to yourself. Also, the components mentioned in this file are > > listed in alphabetic order according to their names. As the name of EEH > > is changed, it would be put in front of "Extended Verification Module > > (EVM)". > > > I agree with Michael as discussed in another thread: we're going to use > "enhanced", not "extended" though some chip datasheet (P7IOC) talks about > "extended error handling". > > Russell, please change the maintainer to you and repost. Sure. While I'm changing MAINTAINERS, what are your thoughts on renaming the EEH entry from "ENHANCED ERROR HANDLING (EEH)" to something like "PCI EXTENDED ERROR HANDLING (EEH)" or "EXTENDED ERROR HANDLING (EEH) FOR PCI" - so it's clear it refers to PCI and not something more generic? > > > > > > > > > Signed-off-by: Russell Currey <ruscur@russell.cc> > > With above issues fixed: > > > > Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> > > > Thanks, > Gavin > > > > > > > > > --- > > > I don't know what kind of things parse MAINTAINERS, and if there's a > > > chance > > > this will break them. Also, the powerpc tree *is* the right place to > > > send > > > this, right? > > > --- > > > MAINTAINERS | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 28eb61b..e5d9134 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -4222,7 +4222,7 @@ M: Maxim Levitsky <maximlevitsky@gmail.c > > > om> > > > S: Maintained > > > F: drivers/media/rc/ene_ir.* > > > > > > -ENHANCED ERROR HANDLING (EEH) > > > +EXTENDED ERROR HANDLING (EEH) > > > M: Gavin Shan <shangw@linux.vnet.ibm.com> > > > L: linuxppc-dev@lists.ozlabs.org > > > S: Supported
On Wed, 2016-02-17 at 10:49 +1100, Russell Currey wrote: > On Wed, 2016-02-17 at 09:58 +1100, Gavin Shan wrote: > > > > On Wed, Feb 17, 2016 at 09:49:08AM +1100, Gavin Shan wrote: > > > > > > > > > On Tue, Feb 16, 2016 at 07:52:00PM +1100, Russell Currey wrote: > > > > > > > > > > > > Incredibly, IBM online documentation for EEH uses "extended error > > > > handling" > > > > and "enhanced error handling" to refer to the same thing, in > > > > different > > > > places. In other parts of the kernel, namely the EEH documentation > > > > (found > > > > in Documentation/powerpc/eeh-pci-error-recovery.txt), it's referred > > > > to as > > > > "extended", and in my opinion "extended" makes more sense for what > > > > EEH > > > > does. > > > > > > > > The only place "enhanced error handling" shows up in the kernel is > > > > in > > > > MAINTAINERS, so fix it. > > > > > > > Russell, Thanks for fixing it up. Since you're at it, Please replace > > > the > > > maintainer to yourself. Also, the components mentioned in this file > > > are > > > listed in alphabetic order according to their names. As the name of > > > EEH > > > is changed, it would be put in front of "Extended Verification Module > > > (EVM)". > > > > > I agree with Michael as discussed in another thread: we're going to use > > "enhanced", not "extended" though some chip datasheet (P7IOC) talks > > about > > "extended error handling". > > > > Russell, please change the maintainer to you and repost. > Sure. > > While I'm changing MAINTAINERS, what are your thoughts on renaming the > EEH > entry from "ENHANCED ERROR HANDLING (EEH)" to something like "PCI > EXTENDED > ERROR HANDLING (EEH)" or "EXTENDED ERROR HANDLING (EEH) FOR PCI" - so > it's > clear it refers to PCI and not something more generic? and of course, s/EXTENDED/ENHANCED...-ENOCOFFEE > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Russell Currey <ruscur@russell.cc> > > > With above issues fixed: > > > > > > Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> > > > > > Thanks, > > Gavin > > > > > > > > > > > > > > > > > > > > --- > > > > I don't know what kind of things parse MAINTAINERS, and if there's > > > > a > > > > chance > > > > this will break them. Also, the powerpc tree *is* the right place > > > > to > > > > send > > > > this, right? > > > > --- > > > > MAINTAINERS | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index 28eb61b..e5d9134 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -4222,7 +4222,7 @@ M: Maxim Levitsky <maximlevitsky@gmail > > > > .c > > > > om> > > > > S: Maintained > > > > F: drivers/media/rc/ene_ir.* > > > > > > > > -ENHANCED ERROR HANDLING (EEH) > > > > +EXTENDED ERROR HANDLING (EEH) > > > > M: Gavin Shan <shangw@linux.vnet.ibm.com> > > > > L: linuxppc-dev@lists.ozlabs.org > > > > S: Supported > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
On Wed, 2016-02-17 at 10:49 +1100, Russell Currey wrote: > On Wed, 2016-02-17 at 09:58 +1100, Gavin Shan wrote: > > On Wed, Feb 17, 2016 at 09:49:08AM +1100, Gavin Shan wrote: > > > > > > On Tue, Feb 16, 2016 at 07:52:00PM +1100, Russell Currey wrote: > > > > > > > > Incredibly, IBM online documentation for EEH uses "extended error > > > > handling" > > > > and "enhanced error handling" to refer to the same thing, in > > > > different > > > > places. In other parts of the kernel, namely the EEH documentation > > > > (found > > > > in Documentation/powerpc/eeh-pci-error-recovery.txt), it's referred > > > > to as > > > > "extended", and in my opinion "extended" makes more sense for what > > > > EEH > > > > does. > > > > > > > > The only place "enhanced error handling" shows up in the kernel is in > > > > MAINTAINERS, so fix it. > > > > > > > Russell, Thanks for fixing it up. Since you're at it, Please replace > > > the > > > maintainer to yourself. Also, the components mentioned in this file are > > > listed in alphabetic order according to their names. As the name of EEH > > > is changed, it would be put in front of "Extended Verification Module > > > (EVM)". > > > > > I agree with Michael as discussed in another thread: we're going to use > > "enhanced", not "extended" though some chip datasheet (P7IOC) talks about > > "extended error handling". > > > > Russell, please change the maintainer to you and repost. > Sure. > > While I'm changing MAINTAINERS, what are your thoughts on renaming the EEH > entry from "ENHANCED ERROR HANDLING (EEH)" to something like "PCI EXTENDED > ERROR HANDLING (EEH)" or "EXTENDED ERROR HANDLING (EEH) FOR PCI" - so it's > clear it refers to PCI and not something more generic? Yep, having PCI at the front would be good as it will sort next to the other PCI things. Having POWERPC in there is probably also good. cheers
diff --git a/MAINTAINERS b/MAINTAINERS index 28eb61b..e5d9134 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4222,7 +4222,7 @@ M: Maxim Levitsky <maximlevitsky@gmail.com> S: Maintained F: drivers/media/rc/ene_ir.* -ENHANCED ERROR HANDLING (EEH) +EXTENDED ERROR HANDLING (EEH) M: Gavin Shan <shangw@linux.vnet.ibm.com> L: linuxppc-dev@lists.ozlabs.org S: Supported
Incredibly, IBM online documentation for EEH uses "extended error handling" and "enhanced error handling" to refer to the same thing, in different places. In other parts of the kernel, namely the EEH documentation (found in Documentation/powerpc/eeh-pci-error-recovery.txt), it's referred to as "extended", and in my opinion "extended" makes more sense for what EEH does. The only place "enhanced error handling" shows up in the kernel is in MAINTAINERS, so fix it. Signed-off-by: Russell Currey <ruscur@russell.cc> --- I don't know what kind of things parse MAINTAINERS, and if there's a chance this will break them. Also, the powerpc tree *is* the right place to send this, right? --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)