| Message ID | 20160204162114.09AD4692E0@newverein.lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, 2016-01-25 at 16:31 +0100, Torsten Duwe wrote: > This patch complements the "notrace" attribute for selected functions. > It adds -mprofile-kernel to the cc flags to be stripped from the command > line for code-patching.o and feature-fixups.o, in addition to "-pg" This could probably be folded into patch 5, and the combined patch would be "remove -mprofile-kernel in all the same places we remove -pg and for the same reasons". I can't think of anywhere we would want to disable -pg but not disable -mprofile-kernel? Or vice versa. cheers
On Wed, Feb 10, 2016 at 11:33:33AM +1100, Michael Ellerman wrote: > On Mon, 2016-01-25 at 16:31 +0100, Torsten Duwe wrote: > > > This patch complements the "notrace" attribute for selected functions. > > It adds -mprofile-kernel to the cc flags to be stripped from the command > > line for code-patching.o and feature-fixups.o, in addition to "-pg" > > This could probably be folded into patch 5, and the combined patch would be > "remove -mprofile-kernel in all the same places we remove -pg and for the same > reasons". That's right. It has shrunk a lot... > I can't think of anywhere we would want to disable -pg but not disable > -mprofile-kernel? Or vice versa. On patch creation, I had handled them literally, individually. Now they're blended into CC_FLAGS_FTRACE, which greatly simplified things. Done. Torsten
diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile index a47e142..98e22b2 100644 --- a/arch/powerpc/lib/Makefile +++ b/arch/powerpc/lib/Makefile @@ -6,8 +6,8 @@ subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC) -CFLAGS_REMOVE_code-patching.o = -pg -CFLAGS_REMOVE_feature-fixups.o = -pg +CFLAGS_REMOVE_code-patching.o = -pg -mprofile-kernel +CFLAGS_REMOVE_feature-fixups.o = -pg -mprofile-kernel obj-y += string.o alloc.o crtsavres.o ppc_ksyms.o code-patching.o \ feature-fixups.o
This patch complements the "notrace" attribute for selected functions. It adds -mprofile-kernel to the cc flags to be stripped from the command line for code-patching.o and feature-fixups.o, in addition to "-pg" Signed-off-by: Torsten Duwe <duwe@suse.de> --- arch/powerpc/lib/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)