| Message ID | 1454514630-29269-12-git-send-email-b.zolnierkie@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Am 2016-02-03 um 16:50 schrieb Bartlomiej Zolnierkiewicz: > IDE subsystem has been deprecated since 2009 and the majority > (if not all) of Linux distributions have switched to use > libata for ATA support exclusively. However there are still > some users (mostly old or/and embedded non-x86 systems) that > have not converted from using IDE subsystem to libata PATA > drivers. This doesn't seem to be good thing in the long-term > for Linux as while there is less and less PATA systems left > in use: > > * testing efforts are divided between two subsystems > > * having duplicate drivers for same hardware confuses users > > This patch converts amigaone_defconfig to use libata PATA > drivers. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > Build tested only. > If you have affected hardware please test. Thank you. > > arch/powerpc/configs/amigaone_defconfig | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/configs/amigaone_defconfig b/arch/powerpc/configs/amigaone_defconfig > index 84f1b41..55a4929 100644 > --- a/arch/powerpc/configs/amigaone_defconfig > +++ b/arch/powerpc/configs/amigaone_defconfig > @@ -46,12 +46,6 @@ CONFIG_PARPORT_PC_FIFO=y > CONFIG_BLK_DEV_FD=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_RAM=y > -CONFIG_IDE=y > -CONFIG_BLK_DEV_IDECD=y > -# CONFIG_IDEPCI_PCIBUS_ORDER is not set > -CONFIG_BLK_DEV_GENERIC=y > -CONFIG_BLK_DEV_SIIMAGE=y > -CONFIG_BLK_DEV_VIA82CXXX=y > CONFIG_SCSI=y > CONFIG_BLK_DEV_SD=y > CONFIG_CHR_DEV_ST=y > @@ -62,6 +56,10 @@ CONFIG_SCSI_CONSTANTS=y > CONFIG_SCSI_SYM53C8XX_2=y > CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0 > # CONFIG_SCSI_SYM53C8XX_MMIO is not set > +CONFIG_ATA=y > +CONFIG_PATA_SIL680=y > +CONFIG_PATA_VIA=y > +CONFIG_ATA_GENERIC=y > CONFIG_NETDEVICES=y > CONFIG_VORTEX=y > CONFIG_8139CP=y > Thanks for cleaning up the defconfig file! libata drivers work fine on the amigaone platform (tested on all three first-gen AmigaOne machines). BTW: could it be that CONFIG_ATA_SFF=y and CONFIG_ATA_BMDMA=y are missing in the patch? br, Gerhard
Hi, On Wednesday, February 03, 2016 10:17:51 PM Gerhard Pircher wrote: > Am 2016-02-03 um 16:50 schrieb Bartlomiej Zolnierkiewicz: > > IDE subsystem has been deprecated since 2009 and the majority > > (if not all) of Linux distributions have switched to use > > libata for ATA support exclusively. However there are still > > some users (mostly old or/and embedded non-x86 systems) that > > have not converted from using IDE subsystem to libata PATA > > drivers. This doesn't seem to be good thing in the long-term > > for Linux as while there is less and less PATA systems left > > in use: > > > > * testing efforts are divided between two subsystems > > > > * having duplicate drivers for same hardware confuses users > > > > This patch converts amigaone_defconfig to use libata PATA > > drivers. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > --- > > Build tested only. > > If you have affected hardware please test. Thank you. > > > > arch/powerpc/configs/amigaone_defconfig | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/arch/powerpc/configs/amigaone_defconfig b/arch/powerpc/configs/amigaone_defconfig > > index 84f1b41..55a4929 100644 > > --- a/arch/powerpc/configs/amigaone_defconfig > > +++ b/arch/powerpc/configs/amigaone_defconfig > > @@ -46,12 +46,6 @@ CONFIG_PARPORT_PC_FIFO=y > > CONFIG_BLK_DEV_FD=y > > CONFIG_BLK_DEV_LOOP=y > > CONFIG_BLK_DEV_RAM=y > > -CONFIG_IDE=y > > -CONFIG_BLK_DEV_IDECD=y > > -# CONFIG_IDEPCI_PCIBUS_ORDER is not set > > -CONFIG_BLK_DEV_GENERIC=y > > -CONFIG_BLK_DEV_SIIMAGE=y > > -CONFIG_BLK_DEV_VIA82CXXX=y > > CONFIG_SCSI=y > > CONFIG_BLK_DEV_SD=y > > CONFIG_CHR_DEV_ST=y > > @@ -62,6 +56,10 @@ CONFIG_SCSI_CONSTANTS=y > > CONFIG_SCSI_SYM53C8XX_2=y > > CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0 > > # CONFIG_SCSI_SYM53C8XX_MMIO is not set > > +CONFIG_ATA=y > > +CONFIG_PATA_SIL680=y > > +CONFIG_PATA_VIA=y > > +CONFIG_ATA_GENERIC=y > > CONFIG_NETDEVICES=y > > CONFIG_VORTEX=y > > CONFIG_8139CP=y > > > Thanks for cleaning up the defconfig file! > > libata drivers work fine on the amigaone platform (tested on all three > first-gen AmigaOne machines). BTW: could it be that CONFIG_ATA_SFF=y > and CONFIG_ATA_BMDMA=y are missing in the patch? Thank you for testing! When it comes to CONFIG_ATA_SFF and CONFIG_ATA_BMDMA there is no need to explicitly enable them because once CONFIG_ATA is enabled they both are also enabled by default (they both have 'default y' in Kconfig). [ defconfig changes in the patch were obtained by: - doing 'make amigaone_defconfig' - changing IDE options to libata ones using 'make menuconfig' - doing 'make savedefconfig' - doing 'diff -u arch/powerpc/configs/amigaone_defconfig defconfig' so there should be no missing options etc. ] Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On Wed, 2016-03-02 at 15:50:18 UTC, Bartlomiej Zolnierkiewicz wrote: > IDE subsystem has been deprecated since 2009 and the majority > (if not all) of Linux distributions have switched to use > libata for ATA support exclusively. However there are still > some users (mostly old or/and embedded non-x86 systems) that > have not converted from using IDE subsystem to libata PATA > drivers. This doesn't seem to be good thing in the long-term > for Linux as while there is less and less PATA systems left > in use: > > * testing efforts are divided between two subsystems > > * having duplicate drivers for same hardware confuses users > > This patch converts amigaone_defconfig to use libata PATA > drivers. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/67f6d66559930eddea06c6bfdaf0e5 cheers
diff --git a/arch/powerpc/configs/amigaone_defconfig b/arch/powerpc/configs/amigaone_defconfig index 84f1b41..55a4929 100644 --- a/arch/powerpc/configs/amigaone_defconfig +++ b/arch/powerpc/configs/amigaone_defconfig @@ -46,12 +46,6 @@ CONFIG_PARPORT_PC_FIFO=y CONFIG_BLK_DEV_FD=y CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_RAM=y -CONFIG_IDE=y -CONFIG_BLK_DEV_IDECD=y -# CONFIG_IDEPCI_PCIBUS_ORDER is not set -CONFIG_BLK_DEV_GENERIC=y -CONFIG_BLK_DEV_SIIMAGE=y -CONFIG_BLK_DEV_VIA82CXXX=y CONFIG_SCSI=y CONFIG_BLK_DEV_SD=y CONFIG_CHR_DEV_ST=y @@ -62,6 +56,10 @@ CONFIG_SCSI_CONSTANTS=y CONFIG_SCSI_SYM53C8XX_2=y CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0 # CONFIG_SCSI_SYM53C8XX_MMIO is not set +CONFIG_ATA=y +CONFIG_PATA_SIL680=y +CONFIG_PATA_VIA=y +CONFIG_ATA_GENERIC=y CONFIG_NETDEVICES=y CONFIG_VORTEX=y CONFIG_8139CP=y
IDE subsystem has been deprecated since 2009 and the majority (if not all) of Linux distributions have switched to use libata for ATA support exclusively. However there are still some users (mostly old or/and embedded non-x86 systems) that have not converted from using IDE subsystem to libata PATA drivers. This doesn't seem to be good thing in the long-term for Linux as while there is less and less PATA systems left in use: * testing efforts are divided between two subsystems * having duplicate drivers for same hardware confuses users This patch converts amigaone_defconfig to use libata PATA drivers. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- Build tested only. If you have affected hardware please test. Thank you. arch/powerpc/configs/amigaone_defconfig | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)