diff mbox

[U-Boot] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

Message ID 1454035151-28631-1-git-send-email-van.freenix@gmail.com
State Accepted
Commit 214c3f0f9921250eb336c7effadcc16158ea9df5
Delegated to: Stefano Babic
Headers show

Commit Message

Peng Fan Jan. 29, 2016, 2:39 a.m. UTC 
From: Ye Li <ye.li@nxp.com>

The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
Fixed the value to correct one.

The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
to 2015.04.

Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Jan. 29, 2016, 9:24 a.m. UTC | #1 
Hi Peng,

On Fri, Jan 29, 2016 at 12:39 AM, Peng Fan <van.freenix@gmail.com> wrote:
> From: Ye Li <ye.li@nxp.com>
>
> The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
> Fixed the value to correct one.
>
> The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
> to 2015.04.

I would remove this last sentence as it applies to NXP U-boot release, right?

Otherwise the patch looks good.
Stefano Babic Jan. 29, 2016, 9:30 a.m. UTC | #2 
On 29/01/2016 03:39, Peng Fan wrote:
> From: Ye Li <ye.li@nxp.com>
> 
> The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
> Fixed the value to correct one.
> 
> The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
> to 2015.04.
> 
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
> index d20953d..42f89ab 100644
> --- a/board/freescale/mx6sabresd/mx6sabresd.c
> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
> @@ -638,7 +638,7 @@ static const struct boot_mode board_boot_modes[] = {
>  	{"sd2",	 MAKE_CFGVAL(0x40, 0x28, 0x00, 0x00)},
>  	{"sd3",	 MAKE_CFGVAL(0x40, 0x30, 0x00, 0x00)},
>  	/* 8 bit bus width */
> -	{"emmc", MAKE_CFGVAL(0x40, 0x38, 0x00, 0x00)},
> +	{"emmc", MAKE_CFGVAL(0x60, 0x58, 0x00, 0x00)},
>  	{NULL,	 0},
>  };
>  #endif
> 

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index d20953d..42f89ab 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -638,7 +638,7 @@  static const struct boot_mode board_boot_modes[] = {
 	{"sd2",	 MAKE_CFGVAL(0x40, 0x28, 0x00, 0x00)},
 	{"sd3",	 MAKE_CFGVAL(0x40, 0x30, 0x00, 0x00)},
 	/* 8 bit bus width */
-	{"emmc", MAKE_CFGVAL(0x40, 0x38, 0x00, 0x00)},
+	{"emmc", MAKE_CFGVAL(0x60, 0x58, 0x00, 0x00)},
 	{NULL,	 0},
 };
 #endif