| Message ID | 201601252321.57520.marex@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, Jan 25, 2016 at 11:21:57PM +0100, Marek Vasut wrote: > The following changes since commit 12f229ea8f6c8e20f8fd07906eafc853c4c354a9: > > Merge git://git.denx.de/u-boot-fdt (2016-01-22 17:01:22 -0500) > > are available in the git repository at: > > git://git.denx.de/u-boot-usb.git master > > for you to fetch changes up to bdbcbe752e93357226cba12a6ce00bbe54cb5db8: > > usb: kbd: Prevent out of bound access (2016-01-25 22:00:46 +0100) > Applied to u-boot/master, thanks!
+Stephen, Ted Hi, On 25 January 2016 at 15:21, Marek Vasut <marex@denx.de> wrote: > The following changes since commit 12f229ea8f6c8e20f8fd07906eafc853c4c354a9: > > Merge git://git.denx.de/u-boot-fdt (2016-01-22 17:01:22 -0500) > > are available in the git repository at: > > git://git.denx.de/u-boot-usb.git master > > for you to fetch changes up to bdbcbe752e93357226cba12a6ce00bbe54cb5db8: > > usb: kbd: Prevent out of bound access (2016-01-25 22:00:46 +0100) > > ---------------------------------------------------------------- > Marek Vasut (1): > usb: kbd: Prevent out of bound access > > Masahiro Yamada (1): > usb: add clock support for generic EHCI > > Stefan Brüns (7): > usb: dwc2: Fix out-of-bounds access, fix chunk size > usb: dwc2: Simplify wait_for_chhltd(), remove ignore_ack > usb: dwc2: split transfer core from outer loop > usb: dwc2: add helper function for setting SPLIT HC registers > usb: dwc2: Implement SPLIT transaction support > usb: dwc2: Add SPLIT INTERRUPT transaction support > usb: dwc2: Do not mix data toggle for IN and OUT endpoints, check bounds > > Stephen Warren (1): > ARM: rpi: enable USB keyboard > > Ted Chen (1): > usb: eth: add Realtek RTL8152B/RTL8153 DRIVER This brings in a driver that does not support driver model. There was one more to convert and then we would be able to move everything to driver model for USB Ethernet. This makes the job harder. Stephen or Ted, are you able to send a patch to convert it? Regards, Simon
On 02/11/2016 04:59 PM, Simon Glass wrote: > +Stephen, Ted > > Hi, > > On 25 January 2016 at 15:21, Marek Vasut <marex@denx.de> wrote: >> The following changes since commit 12f229ea8f6c8e20f8fd07906eafc853c4c354a9: >> >> Merge git://git.denx.de/u-boot-fdt (2016-01-22 17:01:22 -0500) >> >> are available in the git repository at: >> >> git://git.denx.de/u-boot-usb.git master >> >> for you to fetch changes up to bdbcbe752e93357226cba12a6ce00bbe54cb5db8: >> >> usb: kbd: Prevent out of bound access (2016-01-25 22:00:46 +0100) >> >> ---------------------------------------------------------------- >> Marek Vasut (1): >> usb: kbd: Prevent out of bound access >> >> Masahiro Yamada (1): >> usb: add clock support for generic EHCI >> >> Stefan Brüns (7): >> usb: dwc2: Fix out-of-bounds access, fix chunk size >> usb: dwc2: Simplify wait_for_chhltd(), remove ignore_ack >> usb: dwc2: split transfer core from outer loop >> usb: dwc2: add helper function for setting SPLIT HC registers >> usb: dwc2: Implement SPLIT transaction support >> usb: dwc2: Add SPLIT INTERRUPT transaction support >> usb: dwc2: Do not mix data toggle for IN and OUT endpoints, check bounds >> >> Stephen Warren (1): >> ARM: rpi: enable USB keyboard >> >> Ted Chen (1): >> usb: eth: add Realtek RTL8152B/RTL8153 DRIVER > > This brings in a driver that does not support driver model. There was > one more to convert and then we would be able to move everything to > driver model for USB Ethernet. This makes the job harder. > > Stephen or Ted, are you able to send a patch to convert it? I thought the patch wasn't going to be accepted until it was converted. Perhaps it was applied too early? Anyway, I am not likely to be able to use the driver in the near future due to lack of HW to test it on, so Ted is the best candidate to port it over.
Hi, On 11 February 2016 at 17:07, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 02/11/2016 04:59 PM, Simon Glass wrote: >> >> +Stephen, Ted >> >> Hi, >> >> On 25 January 2016 at 15:21, Marek Vasut <marex@denx.de> wrote: >>> >>> The following changes since commit >>> 12f229ea8f6c8e20f8fd07906eafc853c4c354a9: >>> >>> Merge git://git.denx.de/u-boot-fdt (2016-01-22 17:01:22 -0500) >>> >>> are available in the git repository at: >>> >>> git://git.denx.de/u-boot-usb.git master >>> >>> for you to fetch changes up to bdbcbe752e93357226cba12a6ce00bbe54cb5db8: >>> >>> usb: kbd: Prevent out of bound access (2016-01-25 22:00:46 +0100) >>> >>> ---------------------------------------------------------------- >>> Marek Vasut (1): >>> usb: kbd: Prevent out of bound access >>> >>> Masahiro Yamada (1): >>> usb: add clock support for generic EHCI >>> >>> Stefan Brüns (7): >>> usb: dwc2: Fix out-of-bounds access, fix chunk size >>> usb: dwc2: Simplify wait_for_chhltd(), remove ignore_ack >>> usb: dwc2: split transfer core from outer loop >>> usb: dwc2: add helper function for setting SPLIT HC registers >>> usb: dwc2: Implement SPLIT transaction support >>> usb: dwc2: Add SPLIT INTERRUPT transaction support >>> usb: dwc2: Do not mix data toggle for IN and OUT endpoints, check >>> bounds >>> >>> Stephen Warren (1): >>> ARM: rpi: enable USB keyboard >>> >>> Ted Chen (1): >>> usb: eth: add Realtek RTL8152B/RTL8153 DRIVER >> >> >> This brings in a driver that does not support driver model. There was >> one more to convert and then we would be able to move everything to >> driver model for USB Ethernet. This makes the job harder. >> >> Stephen or Ted, are you able to send a patch to convert it? > > > I thought the patch wasn't going to be accepted until it was converted. > Perhaps it was applied too early? > > Anyway, I am not likely to be able to use the driver in the near future due > to lack of HW to test it on, so Ted is the best candidate to port it over. Possibly, although I'd settle for just converting it and testing it later. It's a new driver. Also at present it's dead code as no board includes it. Plus it should use Kconfig... Regards, Simon
The following changes since commit 12f229ea8f6c8e20f8fd07906eafc853c4c354a9: Merge git://git.denx.de/u-boot-fdt (2016-01-22 17:01:22 -0500) are available in the git repository at: git://git.denx.de/u-boot-usb.git master for you to fetch changes up to bdbcbe752e93357226cba12a6ce00bbe54cb5db8: usb: kbd: Prevent out of bound access (2016-01-25 22:00:46 +0100) ---------------------------------------------------------------- Marek Vasut (1): usb: kbd: Prevent out of bound access Masahiro Yamada (1): usb: add clock support for generic EHCI Stefan Brüns (7): usb: dwc2: Fix out-of-bounds access, fix chunk size usb: dwc2: Simplify wait_for_chhltd(), remove ignore_ack usb: dwc2: split transfer core from outer loop usb: dwc2: add helper function for setting SPLIT HC registers usb: dwc2: Implement SPLIT transaction support usb: dwc2: Add SPLIT INTERRUPT transaction support usb: dwc2: Do not mix data toggle for IN and OUT endpoints, check bounds Stephen Warren (1): ARM: rpi: enable USB keyboard Ted Chen (1): usb: eth: add Realtek RTL8152B/RTL8153 DRIVER common/usb_kbd.c | 2 +- drivers/usb/eth/Makefile | 1 + drivers/usb/eth/r8152.c | 1456 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/usb/eth/r8152.h | 631 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/usb/eth/r8152_fw.c | 980 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/usb/eth/usb_ether.c | 7 + drivers/usb/host/dwc2.c | 301 ++++++++++++++-------- drivers/usb/host/dwc2.h | 1 + drivers/usb/host/ehci-generic.c | 14 ++ include/configs/rpi-common.h | 6 +- include/usb_ether.h | 6 + 11 files changed, 3303 insertions(+), 102 deletions(-) create mode 100644 drivers/usb/eth/r8152.c create mode 100644 drivers/usb/eth/r8152.h create mode 100644 drivers/usb/eth/r8152_fw.c