| Message ID | 1452775350-31397-1-git-send-email-Ashish.Kumar@freescale.com |
|---|---|
| State | Accepted |
| Delegated to: | York Sun |
| Headers | show |
On 01/14/2016 04:42 AM, Ashish Kumar wrote: > * Increase default hugepage count to 256 from 16 > * Note: default env variables are stored at 0x580200000/0x584200000 > of size 0x2000 > Ashish, What does the default env location have anything to do with this patch? York > Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com> > --- > include/configs/ls2080a_common.h | 2 +- > include/configs/ls2080ardb.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h > index 4ae7d11..a503934 100644 > --- a/include/configs/ls2080a_common.h > +++ b/include/configs/ls2080a_common.h > @@ -272,7 +272,7 @@ unsigned long long get_qixis_addr(void); > #define CONFIG_BOOTARGS "console=ttyS0,115200 root=/dev/ram0 " \ > "earlycon=uart8250,mmio,0x21c0500" \ > "ramdisk_size=0x2000000 default_hugepagesz=2m" \ > - " hugepagesz=2m hugepages=16" > + " hugepagesz=2m hugepages=256" > #define CONFIG_BOOTCOMMAND "cp.b $kernel_start $kernel_load " \ > "$kernel_size && bootm $kernel_load" > #define CONFIG_BOOTDELAY 10 > diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h > index 116dbcd..356d254 100644 > --- a/include/configs/ls2080ardb.h > +++ b/include/configs/ls2080ardb.h > @@ -333,7 +333,7 @@ unsigned long get_board_sys_clk(void); > #define CONFIG_BOOTARGS "console=ttyS1,115200 root=/dev/ram0 " \ > "earlycon=uart8250,mmio,0x21c0600" \ > "ramdisk_size=0x2000000 default_hugepagesz=2m" \ > - " hugepagesz=2m hugepages=16" > + " hugepagesz=2m hugepages=256" > > /* MAC/PHY configuration */ > #ifdef CONFIG_FSL_MC_ENET >
Hello York, It is like a heads-up, that user needs to erase the environment variable location before flashing a new uboot for the changes to reflect. Regards Ashish -----Original Message----- From: york sun [mailto:york.sun@nxp.com] Sent: Monday, February 01, 2016 10:17 PM To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot@lists.denx.de Subject: Re: [PATCH] ls2-2085a: Increase default hugepage count On 01/14/2016 04:42 AM, Ashish Kumar wrote: > * Increase default hugepage count to 256 from 16 > * Note: default env variables are stored at 0x580200000/0x584200000 > of size 0x2000 > Ashish, What does the default env location have anything to do with this patch? York > Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com> > --- > include/configs/ls2080a_common.h | 2 +- > include/configs/ls2080ardb.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/configs/ls2080a_common.h > b/include/configs/ls2080a_common.h > index 4ae7d11..a503934 100644 > --- a/include/configs/ls2080a_common.h > +++ b/include/configs/ls2080a_common.h > @@ -272,7 +272,7 @@ unsigned long long get_qixis_addr(void); > #define CONFIG_BOOTARGS "console=ttyS0,115200 root=/dev/ram0 " \ > "earlycon=uart8250,mmio,0x21c0500" \ > "ramdisk_size=0x2000000 default_hugepagesz=2m" \ > - " hugepagesz=2m hugepages=16" > + " hugepagesz=2m hugepages=256" > #define CONFIG_BOOTCOMMAND "cp.b $kernel_start $kernel_load " \ > "$kernel_size && bootm $kernel_load" > #define CONFIG_BOOTDELAY 10 > diff --git a/include/configs/ls2080ardb.h > b/include/configs/ls2080ardb.h index 116dbcd..356d254 100644 > --- a/include/configs/ls2080ardb.h > +++ b/include/configs/ls2080ardb.h > @@ -333,7 +333,7 @@ unsigned long get_board_sys_clk(void); > #define CONFIG_BOOTARGS "console=ttyS1,115200 root=/dev/ram0 " \ > "earlycon=uart8250,mmio,0x21c0600" \ > "ramdisk_size=0x2000000 default_hugepagesz=2m" \ > - " hugepagesz=2m hugepages=16" > + " hugepagesz=2m hugepages=256" > > /* MAC/PHY configuration */ > #ifdef CONFIG_FSL_MC_ENET >
On 02/01/2016 10:09 PM, Ashish Kumar wrote: > Hello York, > > It is like a heads-up, that user needs to erase the environment variable location before flashing a new uboot for the changes to reflect. You are changing default environmental variables. It is up to the users to set correct variables. I don't believe the note clarifies anything in the context of this patch. You don't need to send an update if you agree. I can drop the note when merging the patch. York > > Regards > Ashish > > -----Original Message----- > From: york sun [mailto:york.sun@nxp.com] > Sent: Monday, February 01, 2016 10:17 PM > To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot@lists.denx.de > Subject: Re: [PATCH] ls2-2085a: Increase default hugepage count > > On 01/14/2016 04:42 AM, Ashish Kumar wrote: >> * Increase default hugepage count to 256 from 16 >> * Note: default env variables are stored at 0x580200000/0x584200000 >> of size 0x2000 >> > > Ashish, > > What does the default env location have anything to do with this patch? > > York >
Agree, Please drop this while merging. Regards Ashish -----Original Message----- From: york sun Sent: Tuesday, February 02, 2016 11:50 AM To: Ashish Kumar <ashish.kumar@nxp.com>; u-boot@lists.denx.de Subject: Re: [PATCH] ls2-2085a: Increase default hugepage count On 02/01/2016 10:09 PM, Ashish Kumar wrote: > Hello York, > > It is like a heads-up, that user needs to erase the environment variable location before flashing a new uboot for the changes to reflect. You are changing default environmental variables. It is up to the users to set correct variables. I don't believe the note clarifies anything in the context of this patch. You don't need to send an update if you agree. I can drop the note when merging the patch. York > > Regards > Ashish > > -----Original Message----- > From: york sun [mailto:york.sun@nxp.com] > Sent: Monday, February 01, 2016 10:17 PM > To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot@lists.denx.de > Subject: Re: [PATCH] ls2-2085a: Increase default hugepage count > > On 01/14/2016 04:42 AM, Ashish Kumar wrote: >> * Increase default hugepage count to 256 from 16 >> * Note: default env variables are stored at 0x580200000/0x584200000 >> of size 0x2000 >> > > Ashish, > > What does the default env location have anything to do with this patch? > > York >
On 01/14/2016 04:42 AM, Ashish Kumar wrote: > * Increase default hugepage count to 256 from 16 > * Note: default env variables are stored at 0x580200000/0x584200000 > of size 0x2000 > > Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com> > --- Dropped the note of default env. Applied to fsl-qoriq master. Awaiting upstream. York
diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h index 4ae7d11..a503934 100644 --- a/include/configs/ls2080a_common.h +++ b/include/configs/ls2080a_common.h @@ -272,7 +272,7 @@ unsigned long long get_qixis_addr(void); #define CONFIG_BOOTARGS "console=ttyS0,115200 root=/dev/ram0 " \ "earlycon=uart8250,mmio,0x21c0500" \ "ramdisk_size=0x2000000 default_hugepagesz=2m" \ - " hugepagesz=2m hugepages=16" + " hugepagesz=2m hugepages=256" #define CONFIG_BOOTCOMMAND "cp.b $kernel_start $kernel_load " \ "$kernel_size && bootm $kernel_load" #define CONFIG_BOOTDELAY 10 diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h index 116dbcd..356d254 100644 --- a/include/configs/ls2080ardb.h +++ b/include/configs/ls2080ardb.h @@ -333,7 +333,7 @@ unsigned long get_board_sys_clk(void); #define CONFIG_BOOTARGS "console=ttyS1,115200 root=/dev/ram0 " \ "earlycon=uart8250,mmio,0x21c0600" \ "ramdisk_size=0x2000000 default_hugepagesz=2m" \ - " hugepagesz=2m hugepages=16" + " hugepagesz=2m hugepages=256" /* MAC/PHY configuration */ #ifdef CONFIG_FSL_MC_ENET
* Increase default hugepage count to 256 from 16 * Note: default env variables are stored at 0x580200000/0x584200000 of size 0x2000 Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com> --- include/configs/ls2080a_common.h | 2 +- include/configs/ls2080ardb.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)