| Message ID | 1452593909-16184-2-git-send-email-purna.mandal@microchip.com |
|---|---|
| State | Superseded |
| Delegated to: | Daniel Schwierzeck |
| Headers | show |
2016-01-12 11:18 GMT+01:00 Purna Chandra Mandal <purna.mandal@microchip.com>: > Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> > --- > > Changes in v3: None > Changes in v2: None > > arch/mips/cpu/start.S | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/cpu/start.S b/arch/mips/cpu/start.S > index e95cdca..35d9650 100644 > --- a/arch/mips/cpu/start.S > +++ b/arch/mips/cpu/start.S > @@ -185,6 +185,8 @@ reset: > PTR_ADDU t0, k0, GD_MALLOC_BASE # gd->malloc_base offset > sw sp, 0(t0) > #endif > + /* Initialize args to zero */ > + move a0, zero the comment should be on the same line and more precise. That is useful in disassemblies or when debugging. E.g. move a0, zero # a0 <-- boot_flags = 0 Also add a commit message please explaining why the change is required. Something like that the boot_flags of board_init_f should be set to 0 because $a0 may be utilized in lowlevel_init or mips_cache_reset. > > PTR_LA t9, board_init_f > jr t9 > -- > 1.8.3.1 >
On 01/12/2016 05:59 PM, Daniel Schwierzeck wrote: > 2016-01-12 11:18 GMT+01:00 Purna Chandra Mandal <purna.mandal@microchip.com>: >> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> >> --- >> >> Changes in v3: None >> Changes in v2: None >> >> arch/mips/cpu/start.S | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/mips/cpu/start.S b/arch/mips/cpu/start.S >> index e95cdca..35d9650 100644 >> --- a/arch/mips/cpu/start.S >> +++ b/arch/mips/cpu/start.S >> @@ -185,6 +185,8 @@ reset: >> PTR_ADDU t0, k0, GD_MALLOC_BASE # gd->malloc_base offset >> sw sp, 0(t0) >> #endif >> + /* Initialize args to zero */ >> + move a0, zero > the comment should be on the same line and more precise. That is > useful in disassemblies or when debugging. E.g. > > move a0, zero # a0 <-- boot_flags = 0 > > Also add a commit message please explaining why the change is > required. Something like that the boot_flags of board_init_f should be > set to 0 because $a0 may be utilized in lowlevel_init or > mips_cache_reset. ack. Will add accordingly, >> PTR_LA t9, board_init_f >> jr t9 >> -- >> 1.8.3.1 >> > >
Hi Purna, Am Donnerstag, den 14.01.2016, 10:59 +0530 schrieb Purna Chandra Mandal: > On 01/12/2016 05:59 PM, Daniel Schwierzeck wrote: > > > 2016-01-12 11:18 GMT+01:00 Purna Chandra Mandal < > > purna.mandal@microchip.com>: > > > Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> > > > --- > > > > > > Changes in v3: None > > > Changes in v2: None > > > > > > arch/mips/cpu/start.S | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/mips/cpu/start.S b/arch/mips/cpu/start.S > > > index e95cdca..35d9650 100644 > > > --- a/arch/mips/cpu/start.S > > > +++ b/arch/mips/cpu/start.S > > > @@ -185,6 +185,8 @@ reset: > > > PTR_ADDU t0, k0, GD_MALLOC_BASE # gd->malloc_base offset > > > sw sp, 0(t0) > > > #endif > > > + /* Initialize args to zero */ > > > + move a0, zero > > the comment should be on the same line and more precise. That is > > useful in disassemblies or when debugging. E.g. > > > > move a0, zero # a0 <-- boot_flags = 0 > > > > Also add a commit message please explaining why the change is > > required. Something like that the boot_flags of board_init_f should > > be > > set to 0 because $a0 may be utilized in lowlevel_init or > > mips_cache_reset. > > ack. Will add accordingly, > can you send an updated version as separate patch promptly? I'd like to apply this patch as soon as possible because I have some follow-up patches for start.S. Thanks.
diff --git a/arch/mips/cpu/start.S b/arch/mips/cpu/start.S index e95cdca..35d9650 100644 --- a/arch/mips/cpu/start.S +++ b/arch/mips/cpu/start.S @@ -185,6 +185,8 @@ reset: PTR_ADDU t0, k0, GD_MALLOC_BASE # gd->malloc_base offset sw sp, 0(t0) #endif + /* Initialize args to zero */ + move a0, zero PTR_LA t9, board_init_f jr t9
Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> --- Changes in v3: None Changes in v2: None arch/mips/cpu/start.S | 2 ++ 1 file changed, 2 insertions(+)