| Message ID | 1450745989-2764-2-git-send-email-clsee@altera.com |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
On Tuesday, December 22, 2015 at 01:59:46 AM, Chin Liang See wrote: > Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI > and UBIFS support on serial NOR flash > > Signed-off-by: Chin Liang See <clsee@altera.com> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > Cc: Dinh Nguyen <dinh.linux@gmail.com> > Cc: Pavel Machek <pavel@denx.de> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefan Roese <sr@denx.de> > --- > Changes for v2 > - move CONFIG_SPI_FLASH_USE_4K_SECTORS to Kconfig > --- > configs/socfpga_cyclone5_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/socfpga_cyclone5_defconfig > b/configs/socfpga_cyclone5_defconfig index 864358c..4216b55 100644 > --- a/configs/socfpga_cyclone5_defconfig > +++ b/configs/socfpga_cyclone5_defconfig > @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y > CONFIG_DM_MMC=y > CONFIG_USB=y > CONFIG_DM_USB=y > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n And for arriaV ... ? And sockit ? ;-) Best regards, Marek Vasut
On Tue, 2015-12-22 at 02:15 +0100, Marek Vasut wrote: > On Tuesday, December 22, 2015 at 01:59:46 AM, Chin Liang See wrote: > > Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI > > and UBIFS support on serial NOR flash > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > Cc: Pavel Machek <pavel@denx.de> > > Cc: Marek Vasut <marex@denx.de> > > Cc: Stefan Roese <sr@denx.de> > > --- > > Changes for v2 > > - move CONFIG_SPI_FLASH_USE_4K_SECTORS to Kconfig > > --- > > configs/socfpga_cyclone5_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/configs/socfpga_cyclone5_defconfig > > b/configs/socfpga_cyclone5_defconfig index 864358c..4216b55 100644 > > --- a/configs/socfpga_cyclone5_defconfig > > +++ b/configs/socfpga_cyclone5_defconfig > > @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y > > CONFIG_DM_MMC=y > > CONFIG_USB=y > > CONFIG_DM_USB=y > > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n > > And for arriaV ... ? And sockit ? ;-) haha too obsess testing on CV board :) Let me include them into these series. Thanks Chin Liang > > Best regards, > Marek Vasut
On Tuesday, December 22, 2015 at 02:55:05 AM, Chin Liang See wrote: > On Tue, 2015-12-22 at 02:15 +0100, Marek Vasut wrote: > > On Tuesday, December 22, 2015 at 01:59:46 AM, Chin Liang See wrote: > > > Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI > > > and UBIFS support on serial NOR flash > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > Cc: Pavel Machek <pavel@denx.de> > > > Cc: Marek Vasut <marex@denx.de> > > > Cc: Stefan Roese <sr@denx.de> > > > --- > > > Changes for v2 > > > - move CONFIG_SPI_FLASH_USE_4K_SECTORS to Kconfig > > > --- > > > > > > configs/socfpga_cyclone5_defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/configs/socfpga_cyclone5_defconfig > > > b/configs/socfpga_cyclone5_defconfig index 864358c..4216b55 100644 > > > --- a/configs/socfpga_cyclone5_defconfig > > > +++ b/configs/socfpga_cyclone5_defconfig > > > @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y > > > > > > CONFIG_DM_MMC=y > > > CONFIG_USB=y > > > CONFIG_DM_USB=y > > > > > > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n > > > > And for arriaV ... ? And sockit ? ;-) > > haha too obsess testing on CV board :) > Let me include them into these series. These should be the only three boards which use QSPI NOR. SoCrates, MCV and DE0 do not have QSPI NOR. SR1500 I believe also doesn't have one. Best regards, Marek Vasut
On Tue, 2015-12-22 at 03:09 +0100, Marek Vasut wrote: > On Tuesday, December 22, 2015 at 02:55:05 AM, Chin Liang See wrote: > > On Tue, 2015-12-22 at 02:15 +0100, Marek Vasut wrote: > > > On Tuesday, December 22, 2015 at 01:59:46 AM, Chin Liang See > > > wrote: > > > > Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI > > > > and UBIFS support on serial NOR flash > > > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > > Cc: Pavel Machek <pavel@denx.de> > > > > Cc: Marek Vasut <marex@denx.de> > > > > Cc: Stefan Roese <sr@denx.de> > > > > --- > > > > Changes for v2 > > > > - move CONFIG_SPI_FLASH_USE_4K_SECTORS to Kconfig > > > > --- > > > > > > > > configs/socfpga_cyclone5_defconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/configs/socfpga_cyclone5_defconfig > > > > b/configs/socfpga_cyclone5_defconfig index 864358c..4216b55 > > > > 100644 > > > > --- a/configs/socfpga_cyclone5_defconfig > > > > +++ b/configs/socfpga_cyclone5_defconfig > > > > @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y > > > > > > > > CONFIG_DM_MMC=y > > > > CONFIG_USB=y > > > > CONFIG_DM_USB=y > > > > > > > > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n > > > > > > And for arriaV ... ? And sockit ? ;-) > > > > haha too obsess testing on CV board :) > > Let me include them into these series. > > These should be the only three boards which use QSPI NOR. > > SoCrates, MCV and DE0 do not have QSPI NOR. SR1500 I believe also > doesn't have > one. Nice, dun need to scratch my head :) Thanks Chin Liang > > Best regards, > Marek Vasut
On 22.12.2015 03:09, Marek Vasut wrote: > On Tuesday, December 22, 2015 at 02:55:05 AM, Chin Liang See wrote: >> On Tue, 2015-12-22 at 02:15 +0100, Marek Vasut wrote: >>> On Tuesday, December 22, 2015 at 01:59:46 AM, Chin Liang See wrote: >>>> Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI >>>> and UBIFS support on serial NOR flash >>>> >>>> Signed-off-by: Chin Liang See <clsee@altera.com> >>>> Cc: Dinh Nguyen <dinguyen@opensource.altera.com> >>>> Cc: Dinh Nguyen <dinh.linux@gmail.com> >>>> Cc: Pavel Machek <pavel@denx.de> >>>> Cc: Marek Vasut <marex@denx.de> >>>> Cc: Stefan Roese <sr@denx.de> >>>> --- >>>> Changes for v2 >>>> - move CONFIG_SPI_FLASH_USE_4K_SECTORS to Kconfig >>>> --- >>>> >>>> configs/socfpga_cyclone5_defconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/configs/socfpga_cyclone5_defconfig >>>> b/configs/socfpga_cyclone5_defconfig index 864358c..4216b55 100644 >>>> --- a/configs/socfpga_cyclone5_defconfig >>>> +++ b/configs/socfpga_cyclone5_defconfig >>>> @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y >>>> >>>> CONFIG_DM_MMC=y >>>> CONFIG_USB=y >>>> CONFIG_DM_USB=y >>>> >>>> +CONFIG_SPI_FLASH_USE_4K_SECTORS=n >>> >>> And for arriaV ... ? And sockit ? ;-) >> >> haha too obsess testing on CV board :) >> Let me include them into these series. > > These should be the only three boards which use QSPI NOR. > > SoCrates, MCV and DE0 do not have QSPI NOR. SR1500 I believe also doesn't have > one. SR1500 does have QSPI NOR. Its the boot device. Thanks, Stefan
On Tue, 2015-12-22 at 07:07 +0100, Stefan Roese wrote: > On 22.12.2015 03:09, Marek Vasut wrote: > > On Tuesday, December 22, 2015 at 02:55:05 AM, Chin Liang See wrote: > > > On Tue, 2015-12-22 at 02:15 +0100, Marek Vasut wrote: > > > > On Tuesday, December 22, 2015 at 01:59:46 AM, Chin Liang See > > > > wrote: [..] > > > > > > > > > > > > > > > diff --git a/configs/socfpga_cyclone5_defconfig > > > > > b/configs/socfpga_cyclone5_defconfig index 864358c..4216b55 > > > > > 100644 > > > > > --- a/configs/socfpga_cyclone5_defconfig > > > > > +++ b/configs/socfpga_cyclone5_defconfig > > > > > @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y > > > > > > > > > > CONFIG_DM_MMC=y > > > > > CONFIG_USB=y > > > > > CONFIG_DM_USB=y > > > > > > > > > > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n > > > > > > > > And for arriaV ... ? And sockit ? ;-) > > > > > > haha too obsess testing on CV board :) > > > Let me include them into these series. > > > > These should be the only three boards which use QSPI NOR. > > > > SoCrates, MCV and DE0 do not have QSPI NOR. SR1500 I believe also > > doesn't have > > one. > > SR1500 does have QSPI NOR. Its the boot device. Just in time as going to create v3 now :) Thanks Chin Liang Thanks, > Stefan >
On Tue 2015-12-22 08:59:46, Chin Liang See wrote: > Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI > and UBIFS support on serial NOR flash > > Signed-off-by: Chin Liang See <clsee@altera.com> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > Cc: Dinh Nguyen <dinh.linux@gmail.com> > Cc: Pavel Machek <pavel@denx.de> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefan Roese <sr@denx.de> > --- > Changes for v2 > - move CONFIG_SPI_FLASH_USE_4K_SECTORS to Kconfig > --- > configs/socfpga_cyclone5_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/socfpga_cyclone5_defconfig b/configs/socfpga_cyclone5_defconfig > index 864358c..4216b55 100644 > --- a/configs/socfpga_cyclone5_defconfig > +++ b/configs/socfpga_cyclone5_defconfig > @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y > CONFIG_DM_MMC=y > CONFIG_USB=y > CONFIG_DM_USB=y > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n Actually, do we usually specify =n in config files? It seems to be so rare it is an error. Normally, we have something like "# CONFIG_SYS_MALLOC_F is not set" in config files. Pavel
On Wed, 2015-12-23 at 19:13 +0100, Pavel Machek wrote: > On Tue 2015-12-22 08:59:46, Chin Liang See wrote: > > Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI > > and UBIFS support on serial NOR flash > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > Cc: Pavel Machek <pavel@denx.de> > > Cc: Marek Vasut <marex@denx.de> > > Cc: Stefan Roese <sr@denx.de> > > --- > > Changes for v2 > > - move CONFIG_SPI_FLASH_USE_4K_SECTORS to Kconfig > > --- > > configs/socfpga_cyclone5_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/configs/socfpga_cyclone5_defconfig > > b/configs/socfpga_cyclone5_defconfig > > index 864358c..4216b55 100644 > > --- a/configs/socfpga_cyclone5_defconfig > > +++ b/configs/socfpga_cyclone5_defconfig > > @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y > > CONFIG_DM_MMC=y > > CONFIG_USB=y > > CONFIG_DM_USB=y > > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n > > Actually, do we usually specify =n in config files? It seems to be so > rare it is an error. > > Normally, we have something like "# CONFIG_SYS_MALLOC_F is not set" > in > config files. yah, this was fixed by Marek. Thanks Chin Liang > > > Pavel >
diff --git a/configs/socfpga_cyclone5_defconfig b/configs/socfpga_cyclone5_defconfig index 864358c..4216b55 100644 --- a/configs/socfpga_cyclone5_defconfig +++ b/configs/socfpga_cyclone5_defconfig @@ -23,3 +23,4 @@ CONFIG_DESIGNWARE_SPI=y CONFIG_DM_MMC=y CONFIG_USB=y CONFIG_DM_USB=y +CONFIG_SPI_FLASH_USE_4K_SECTORS=n
Undefine CONFIG_SPI_FLASH_USE_4K_SECTORS for UBI and UBIFS support on serial NOR flash Signed-off-by: Chin Liang See <clsee@altera.com> Cc: Dinh Nguyen <dinguyen@opensource.altera.com> Cc: Dinh Nguyen <dinh.linux@gmail.com> Cc: Pavel Machek <pavel@denx.de> Cc: Marek Vasut <marex@denx.de> Cc: Stefan Roese <sr@denx.de> --- Changes for v2 - move CONFIG_SPI_FLASH_USE_4K_SECTORS to Kconfig --- configs/socfpga_cyclone5_defconfig | 1 + 1 file changed, 1 insertion(+)